diff mbox series

[1/2] hv_netvsc: Add comment of netvsc_xdp_xmit()

Message ID 20220510144534.9338-2-tim.gardner@canonical.com
State New
Headers show
Series hv_netvsc: Add support for XDP_REDIRECT | expand

Commit Message

Tim Gardner May 10, 2022, 2:45 p.m. UTC 
From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

BugLink: https://bugs.launchpad.net/bugs/1972832

Adding comment to avoid the misusing of netvsc_xdp_xmit().
Otherwise the value of skb->queue_mapping could be 0 and
then the return value of skb_get_rx_queue() could be MAX_U16
cause by overflow.

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Link: https://lore.kernel.org/r/1634174786-1810351-1-git-send-email-jiasheng@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit 78e0a006914b9fc0dd714d68f0bb6e0f50c944f2)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/net/hyperv/netvsc_drv.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 7d1763624e8e..7cbf0b0a00d7 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -803,6 +803,7 @@  void netvsc_linkstatus_callback(struct net_device *net,
 	schedule_delayed_work(&ndev_ctx->dwork, 0);
 }
 
+/* This function should only be called after skb_record_rx_queue() */
 static void netvsc_xdp_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
 	int rc;