diff mbox series

UBUNTU: [Config] updateconfigs after AMX patchset

Message ID 20220407093922.94762-1-dimitri.ledkov@canonical.com
State New
Headers show
Series UBUNTU: [Config] updateconfigs after AMX patchset | expand

Commit Message

Dimitri John Ledkov April 7, 2022, 9:39 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1967750

Update configs after applying AMX patchset. Enforce
STRICT_SIGALTSTACK_SIZE as off, because:

CONFIG_STRICT_SIGALTSTACK_SIZE is intend for enforcing strict checking
of the sigaltstack size against the *real size of the FPU frame*,
enabling it is risky since it may lead to the broken of legacy
applications which already allocate a too small sigaltstack but can
still work because they never get a signal delivered. (lin-x-wang)

Fixes: cf1383fe60 ("x86/signal: Implement sigaltstack size validation")
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
---
 debian.master/config/annotations          | 2 ++
 debian.master/config/config.common.ubuntu | 2 ++
 2 files changed, 4 insertions(+)

Comments

Andrea Righi April 7, 2022, 9:53 a.m. UTC | #1
On Thu, Apr 07, 2022 at 10:39:22AM +0100, Dimitri John Ledkov wrote:
> BugLink: https://bugs.launchpad.net/bugs/1967750
> 
> Update configs after applying AMX patchset. Enforce
> STRICT_SIGALTSTACK_SIZE as off, because:
> 
> CONFIG_STRICT_SIGALTSTACK_SIZE is intend for enforcing strict checking
> of the sigaltstack size against the *real size of the FPU frame*,
> enabling it is risky since it may lead to the broken of legacy
> applications which already allocate a too small sigaltstack but can
> still work because they never get a signal delivered. (lin-x-wang)
> 
> Fixes: cf1383fe60 ("x86/signal: Implement sigaltstack size validation")
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>

The target of this patch is obviously jammy (5.15). We can ignore this
for all the other kernels.

Apart than that, the patch makes sense, therefore: applied to
jammy/linux.

Thanks,
-Andrea
diff mbox series

Patch

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 15759fa435..bb9ca38e7e 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -11272,12 +11272,14 @@  CONFIG_VMAP_STACK                               policy<{'amd64': 'y', 'arm64': '
 CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT          policy<{'amd64': 'y', 'arm64': 'y', 's390x': 'y'}>
 CONFIG_STRICT_KERNEL_RWX                        policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
 CONFIG_STRICT_MODULE_RWX                        policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
+CONFIG_STRICT_SIGALTSTACK_SIZE                  policy<{'amd64': 'n'}>
 CONFIG_LOCK_EVENT_COUNTS                        policy<{'amd64': 'n', 'arm64': 'n', 'armhf': 'n', 'ppc64el': 'n', 's390x': 'n'}>
 #
 CONFIG_SECCOMP                                  mark<ENFORCED>
 CONFIG_JUMP_LABEL                               flag<REVIEW>
 CONFIG_STRICT_KERNEL_RWX                        mark<ENFORCED>
 CONFIG_STRICT_MODULE_RWX                        mark<ENFORCED>
+CONFIG_STRICT_SIGALTSTACK_SIZE                  mark<ENFORCED>
 
 # Menu: General architecture-dependent options >> Architecture: arm
 
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 0fffe06795..0addbd1d63 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -3309,6 +3309,7 @@  CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS=y
 CONFIG_DYNAMIC_FTRACE_WITH_REGS=y
 CONFIG_DYNAMIC_MEMORY_LAYOUT=y
 CONFIG_DYNAMIC_PHYSICAL_MASK=y
+CONFIG_DYNAMIC_SIGFRAME=y
 CONFIG_E100=m
 CONFIG_E1000=m
 CONFIG_E1000E=m
@@ -10801,6 +10802,7 @@  CONFIG_STREAM_PARSER=y
 CONFIG_STRICT_DEVMEM=y
 CONFIG_STRICT_KERNEL_RWX=y
 CONFIG_STRICT_MODULE_RWX=y
+# CONFIG_STRICT_SIGALTSTACK_SIZE is not set
 # CONFIG_STRING_SELFTEST is not set
 # CONFIG_STRIP_ASM_SYMS is not set
 CONFIG_STUB_CLK_HI3660=y