From patchwork Mon Feb 21 05:53:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1595344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=GF8b6/9Q; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4K2BLh6MBLz9sFn for ; Mon, 21 Feb 2022 16:53:48 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1nM1dk-00011m-6Q; Mon, 21 Feb 2022 05:53:40 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1nM1di-0000ym-8C for kernel-team@lists.ubuntu.com; Mon, 21 Feb 2022 05:53:38 +0000 Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0DE9C3F1B6 for ; Mon, 21 Feb 2022 05:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645422818; bh=rlM5VCI1uwG333LVKRs8XCcssKEQEt3ZeB6fgkafsg0=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GF8b6/9QW3yrYdYXjykzGDZUNUmyysj9YcbvZHz+Y8hMFHz64MaYj0k2zQhXi2hYF q3Z+DI0tZaLwZOaDmTzaOhLqbSn4E/WZJ8Se6kiaFVcRHB0bZ0gOUlLFoBqg0hsmir qUnPxhlyT/NTv1gMUA7eE+1QZKPvNlVA5JKSMYAArrZx8Zbd9hhx7YnBRmR3O8c2lb vZIyWvJZGrUop+jCmy2H4ST2poXUedNuCknckNIONxzyUOzAyc+m5zvUrPkJ81jDJD uiBSkJ7cXqInItHNN1XXb0Mi5D5/hFcLflFvfDW4RC8kTGXCSXNfyrEe7+gdCMlzBF 1tAvgh68k9JsA== Received: by mail-pj1-f70.google.com with SMTP id y15-20020a17090a390f00b001b9fde42fd4so13646923pjb.0 for ; Sun, 20 Feb 2022 21:53:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rlM5VCI1uwG333LVKRs8XCcssKEQEt3ZeB6fgkafsg0=; b=rvXS9+2XfUhTwxBOyj4AqHVIKoY10F56U2ZvU2R+v1kb4yKvYu6ssSYJG9ncA36bJs 2zNE/mNNvECtc+PxarzDI3OiGCjjotgmNifRLIKpCmWD3sAue0HDhBpHLcXfNr78OGb3 BtILGkZ1pmWRvYs6yoejH4Lp1vjSYY9fHNNihzytSqpxW37oY83cV/WOe8hlC7iFGNIT OiHRahqxh/1PSr6TGLugBPyxP6UxrLszLNpsiuNvz29u/d6mhTxxr8t/4yKv7to/H7a6 gjZuZMiSohPEXOk7e+rybU3K4Qedlly8rmZAPdn6Wb/sn5DftMc7zADSOr8jLJIZLB+y /IHg== X-Gm-Message-State: AOAM532W5tRJ8TjPFQg2T1DE5IoQ6Xzfh5m+chwgBtueiGmJNcpOyQ7T KPEZh5yMwq1ps3/VpwTxbjc8Lh3ULyZYcP51e4pebrupZggDRhMLOGhO0F4o6rC2EQvbZkjjxXu uZxNb+1F2IU3z47w9EzrsCPnWwuZ5Z5FD0t0happ3Vw== X-Received: by 2002:a05:6a00:1c46:b0:4e1:82cb:e39c with SMTP id s6-20020a056a001c4600b004e182cbe39cmr18855561pfw.18.1645422816497; Sun, 20 Feb 2022 21:53:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW4mh1V6/ajpQF8oZdvWFpW87IIzZIUI6fQnAy3weq3VFUqAaKXQJY/VPq8dwQDBfDLOw6OQ== X-Received: by 2002:a05:6a00:1c46:b0:4e1:82cb:e39c with SMTP id s6-20020a056a001c4600b004e182cbe39cmr18855548pfw.18.1645422816192; Sun, 20 Feb 2022 21:53:36 -0800 (PST) Received: from canonical.com (node-1w7jr9yebujeq5th4a1ypmfmg.ipv6.telus.net. [2001:56a:78ed:fb00::998]) by smtp.gmail.com with ESMTPSA id l23sm3765571pji.2.2022.02.20.21.53.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 21:53:35 -0800 (PST) From: Alex Hung To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/5][SRU][J] HID: amd_sfh: Handle amd_sfh work buffer in PM ops Date: Sun, 20 Feb 2022 22:53:29 -0700 Message-Id: <20220221055333.1169827-2-alex.hung@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220221055333.1169827-1-alex.hung@canonical.com> References: <20220221055333.1169827-1-alex.hung@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Basavaraj Natikar BugLink: https://bugs.launchpad.net/bugs/1961121 Since in the current amd_sfh design the sensor data is periodically obtained in the form of poll data, during the suspend/resume cycle, scheduling a delayed work adds no value. So, cancel the work and restart back during the suspend/resume cycle respectively. Signed-off-by: Basavaraj Natikar Signed-off-by: Jiri Kosina (cherry picked from commit 0cf74235f4403b760a37f77271d2ca3424001ff9) Signed-off-by: Alex Hung --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c index f7a4eaf..4198a8a 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -287,6 +287,8 @@ static int __maybe_unused amd_mp2_pci_resume(struct device *dev) } } + schedule_delayed_work(&cl_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP)); + return 0; } @@ -310,6 +312,8 @@ static int __maybe_unused amd_mp2_pci_suspend(struct device *dev) } } + cancel_delayed_work_sync(&cl_data->work_buffer); + return 0; }