From patchwork Tue Dec 28 07:48:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1573626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=nJ5/Z/7G; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JNRWJ66Rnz9sR4 for ; Tue, 28 Dec 2021 18:49:15 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1n27EK-00024W-B9; Tue, 28 Dec 2021 07:49:08 +0000 Received: from mail-pg1-f170.google.com ([209.85.215.170]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1n27EG-00023s-RT for kernel-team@lists.ubuntu.com; Tue, 28 Dec 2021 07:49:05 +0000 Received: by mail-pg1-f170.google.com with SMTP id 7so2702210pgn.0 for ; Mon, 27 Dec 2021 23:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8ZLaMeI6Xlfo/a1Lx7T5jeKSw3Sv1WV+lCbsMWCbyIQ=; b=nJ5/Z/7G93/Xd5cPaue38+AULpGcYFVEVb5wdUBXn7V9T5dJSnQTuLClpGvXbr17Gm O1SQH3sZL5bIOkr2m75sOP22/3Dh/GJmnDKzWtmXw2QJ4BJtueGWJHVXrghIDlzAtix7 S/G/It1kFeinp/qKj9s4sXVPx+W2iGuboKq+iPzE9Vox9Yv9GVYgCJzyK500HTy0lRv0 2Mbl7nSQXZjpoULNYn3GnFjHA1NYkpvDZAddadTmYTlnYY62zRRCF1PmjoG8rKgrAl9W d6kJxwjlMQptxhANpQki/T/anMt2ui+Q3aNJEyOrpO/1YWKwSP3FsQ8zsI+5Dw3N+chf z/rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=8ZLaMeI6Xlfo/a1Lx7T5jeKSw3Sv1WV+lCbsMWCbyIQ=; b=XMaxIgVBf7deEO42+4PBdRoh5LNwxHRhc8AOOjoxVxA2egGttcuhPQZoJvms+afuLp ib6/sZeLaRaWr+oEYaWRH3OHa3kz4ia3yfVvW06evL2tR+DmR3lfTcVZ8ZawnfzPpVJd GgsaDGekHqcFJWw0HL4LD/4/dmsel5X9e92RfTfi6DFo6enSRy8VQ24gR7qsdHpGLU0W Xh5MDz2TMVXOUKgoeeEKzJ/pqR7isYOm+X9yNBb9e4Rr8YMagRYbLnaTtIPMj7vMPA3X FdC24Yap5+WsB+fCkqMtZOG/Jyzm/YWJ9hvioHigz2UgmA5esXlwtKuwcFjDOlsRXV3h rZeA== X-Gm-Message-State: AOAM533Flcasns7JEoepJBykgpCgzS/LCuTdto7S+qMYy6jf0MVpEjol 0HqeGyR7r7gomAInZPXv9Z3G6mTxOAo= X-Google-Smtp-Source: ABdhPJzP7tbHDGSUgUnMtQ6+J9vQQywf1jJyOLWu6RmjOEUL9hgO/nuwhmsqF9G8R5uUZ9jNtmVgSg== X-Received: by 2002:a05:6a00:2134:b0:4b0:bf74:a64d with SMTP id n20-20020a056a00213400b004b0bf74a64dmr21513698pfj.56.1640677742480; Mon, 27 Dec 2021 23:49:02 -0800 (PST) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id v25sm19821483pfg.175.2021.12.27.23.49.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Dec 2021 23:49:01 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][J][OEM-5.14] mt76: mt7921: enable aspm by default Date: Tue, 28 Dec 2021 15:48:56 +0800 Message-Id: <20211228074856.9680-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211228074856.9680-1-acelan.kao@canonical.com> References: <20211228074856.9680-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.215.170; envelope-from=acelan@gmail.com; helo=mail-pg1-f170.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Sean Wang BugLink: https://bugs.launchpad.net/bugs/1955882 mt7921 is mainly used in NB, CE and IoT application where battery life is much concerned so the patch enabled PCIe ASPM by default to shut off the clocks related PCIe as much as possible when MT7921 is either in suspend state or in runtime pm to lower power consumption. We still leave disable aspm as an option with module_param for users to disable ASPM if necessary. Signed-off-by: Sean Wang Signed-off-by: Felix Fietkau (cherry picked from commit bf3747ae2e25dda6a9e6c464a717c66118c588c8) Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c index c3905bcab3604..33782e1ee3128 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c @@ -17,6 +17,10 @@ static const struct pci_device_id mt7921_pci_device_table[] = { { }, }; +static bool mt7921_disable_aspm; +module_param_named(disable_aspm, mt7921_disable_aspm, bool, 0644); +MODULE_PARM_DESC(disable_aspm, "disable PCI ASPM support"); + static void mt7921_rx_poll_complete(struct mt76_dev *mdev, enum mt76_rxq_id q) { @@ -132,7 +136,8 @@ static int mt7921_pci_probe(struct pci_dev *pdev, if (ret) goto err_free_pci_vec; - mt76_pci_disable_aspm(pdev); + if (mt7921_disable_aspm) + mt76_pci_disable_aspm(pdev); mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7921_ops, &drv_ops);