From patchwork Mon Dec 13 14:29:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1567348 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JCP604MZPz9s3q for ; Tue, 14 Dec 2021 01:29:28 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mwmKQ-00015a-HH; Mon, 13 Dec 2021 14:29:22 +0000 Received: from mail-pj1-f49.google.com ([209.85.216.49]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mwmKO-00013V-8u for kernel-team@lists.ubuntu.com; Mon, 13 Dec 2021 14:29:20 +0000 Received: by mail-pj1-f49.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so12621615pjb.1 for ; Mon, 13 Dec 2021 06:29:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=79bFf5N+Y0MCmqXm8qUgF/UeGNLOvTjdyPwwbxrO9qY=; b=BM+J6OKbINUs3n5g7tCMDC9ojoQkFpOzslToKFFpCn6dMb+DEorcIFcNUS9caaQ8oi weTTnqGE+z8CCq7kzqsFpOah717A+qISaT0eFIbgW5Iu45NfTlFzoyWiueGeq3U0hZ+q KK3U27PASPT2LqWl8RmvUVjCrBZSe6k+hiz/MhPO3cqqO2MvfcMW4rlReNC8ga52TsTC 0mr7YnyB44UvPPy2yLIRGO+lUgRr+HLTf0ktmH55wz+vfmWQaxTupEWyboQLDJLd7u3a Nrv0+8KscjuvK90c0wbfj+Djp3T5DDhwxtV/AGP9FQLG2fW1z/3dA57pPjLxjbg9qCOQ DI/g== X-Gm-Message-State: AOAM532zlzR9i+U4GGZeTAPZ416hGwXxy7zLSou5mJ5BQRXV4Y0IOFik mcQmHD3CJu93/DMxzdD6V66CXDZspdOudg== X-Google-Smtp-Source: ABdhPJw/oBTghsvlmHOsj4XaxE8X9CADdqvYE4oOcK1egE1xPFMjQQ1PxPwsZWGiWpOjdjLk+IGCHQ== X-Received: by 2002:a17:90b:4b4e:: with SMTP id mi14mr45099807pjb.122.1639405758396; Mon, 13 Dec 2021 06:29:18 -0800 (PST) Received: from localhost (218-173-164-169.dynamic-ip.hinet.net. [218.173.164.169]) by smtp.gmail.com with ESMTPSA id n71sm13030194pfd.50.2021.12.13.06.29.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 06:29:18 -0800 (PST) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][oem-5.13/oem-5.14/impish/jammy] platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops Date: Mon, 13 Dec 2021 22:29:14 +0800 Message-Id: <20211213142914.3665037-2-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211213142914.3665037-1-vicamo.yang@canonical.com> References: <20211213142914.3665037-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.49; envelope-from=vicamo@gmail.com; helo=mail-pj1-f49.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Fabrizio Bertocci BugLink: https://bugs.launchpad.net/bugs/1954633 On some AMD hardware laptops, the system fails communicating with the PMC when entering s2idle and the machine is battery powered. Hardware description: HP Pavilion Aero Laptop 13-be0097nr CPU: AMD Ryzen 7 5800U with Radeon Graphics GPU: 03:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Device [1002:1638] (rev c1) Detailed description of the problem (and investigation) here: https://gitlab.freedesktop.org/drm/amd/-/issues/1799 Patch is a single line: reduce the polling delay in half, from 100uSec to 50uSec when waiting for a change in state from the PMC after a write command operation. After changing the delay, I did not see a single failure on this machine (I have this fix for now more than one week and s2idle worked every single time on battery power). Cc: stable@vger.kernel.org Acked-by: Shyam Sundar S K Signed-off-by: Fabrizio Bertocci Link: https://lore.kernel.org/r/CADtzkx7TdfbwtaVEXUdD6YXPey52E-nZVQNs+Z41DTx7gqMqtw@mail.gmail.com Signed-off-by: Hans de Goede (cherry picked from commit 49201b90af818654c5506a0decc18e111eadcb66) Signed-off-by: You-Sheng Yang --- drivers/platform/x86/amd-pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index fa28a476faa5..7c919422d751 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -76,7 +76,7 @@ #define AMD_CPU_ID_CZN AMD_CPU_ID_RN #define AMD_CPU_ID_YC 0x14B5 -#define PMC_MSG_DELAY_MIN_US 100 +#define PMC_MSG_DELAY_MIN_US 50 #define RESPONSE_REGISTER_LOOP_MAX 20000 #define SOC_SUBSYSTEM_IP_MAX 12