| Message ID | 20211014170010.581679-4-kai.heng.feng@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Realtek 8852AE WiFi | expand |
Do you think the DEBUG config options are necessary ? That turns on a lot of code. On 10/14/21 11:00 AM, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1945967 > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > debian.master/config/annotations | 9 +++++++++ > debian.master/config/config.common.ubuntu | 7 +++++++ > 2 files changed, 16 insertions(+) > > diff --git a/debian.master/config/annotations b/debian.master/config/annotations > index e0b9f55acae85..c9c4740609d10 100644 > --- a/debian.master/config/annotations > +++ b/debian.master/config/annotations > @@ -6934,6 +6934,15 @@ CONFIG_RTW88_8821CE policy<{'amd64': 'm', 'arm64': ' > CONFIG_RTW88_DEBUG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > CONFIG_RTW88_DEBUGFS policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > > +# Menu: Device Drivers >> Network device support >> Wireless LAN >> Realtek devices >> Realtek 802.11ax wireless chips support > +CONFIG_RTW89 policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > +CONFIG_RTW89_CORE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > +CONFIG_RTW89_PCI policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > +CONFIG_RTW89_8852AE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > +CONFIG_RTW89_DEBUG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > +CONFIG_RTW89_DEBUGMSG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > +CONFIG_RTW89_DEBUGFS policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > + > # Menu: Device Drivers >> Network device support >> Wireless LAN >> Realtek devices >> Realtek rtlwifi family of devices > CONFIG_RTL_CARDS policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > CONFIG_RTL8192CE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu > index 20c1ec9552be6..f189b2ae20265 100644 > --- a/debian.master/config/config.common.ubuntu > +++ b/debian.master/config/config.common.ubuntu > @@ -9099,6 +9099,13 @@ CONFIG_RTW88_CORE=m > CONFIG_RTW88_DEBUG=y > CONFIG_RTW88_DEBUGFS=y > CONFIG_RTW88_PCI=m > +CONFIG_RTW89=m > +CONFIG_RTW89_8852AE=m > +CONFIG_RTW89_CORE=m > +CONFIG_RTW89_DEBUG=y > +CONFIG_RTW89_DEBUGFS=y > +CONFIG_RTW89_DEBUGMSG=y > +CONFIG_RTW89_PCI=m > # CONFIG_RT_GROUP_SCHED is not set > CONFIG_RT_MUTEXES=y > CONFIG_RUNTIME_TESTING_MENU=y >
On Fri, Oct 15, 2021 at 1:34 AM Tim Gardner <tim.gardner@canonical.com> wrote: > > Do you think the DEBUG config options are necessary ? That turns on a > lot of code. The DEBUG options are recommended to be enabled in the Kconfig. It's also a good idea to enable debug as the driver is still quite new and can be buggy. Kai-Heng > > On 10/14/21 11:00 AM, Kai-Heng Feng wrote: > > BugLink: https://bugs.launchpad.net/bugs/1945967 > > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > --- > > debian.master/config/annotations | 9 +++++++++ > > debian.master/config/config.common.ubuntu | 7 +++++++ > > 2 files changed, 16 insertions(+) > > > > diff --git a/debian.master/config/annotations b/debian.master/config/annotations > > index e0b9f55acae85..c9c4740609d10 100644 > > --- a/debian.master/config/annotations > > +++ b/debian.master/config/annotations > > @@ -6934,6 +6934,15 @@ CONFIG_RTW88_8821CE policy<{'amd64': 'm', 'arm64': ' > > CONFIG_RTW88_DEBUG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > > CONFIG_RTW88_DEBUGFS policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > > > > +# Menu: Device Drivers >> Network device support >> Wireless LAN >> Realtek devices >> Realtek 802.11ax wireless chips support > > +CONFIG_RTW89 policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > > +CONFIG_RTW89_CORE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > > +CONFIG_RTW89_PCI policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > > +CONFIG_RTW89_8852AE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > > +CONFIG_RTW89_DEBUG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > > +CONFIG_RTW89_DEBUGMSG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > > +CONFIG_RTW89_DEBUGFS policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> > > + > > # Menu: Device Drivers >> Network device support >> Wireless LAN >> Realtek devices >> Realtek rtlwifi family of devices > > CONFIG_RTL_CARDS policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > > CONFIG_RTL8192CE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> > > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu > > index 20c1ec9552be6..f189b2ae20265 100644 > > --- a/debian.master/config/config.common.ubuntu > > +++ b/debian.master/config/config.common.ubuntu > > @@ -9099,6 +9099,13 @@ CONFIG_RTW88_CORE=m > > CONFIG_RTW88_DEBUG=y > > CONFIG_RTW88_DEBUGFS=y > > CONFIG_RTW88_PCI=m > > +CONFIG_RTW89=m > > +CONFIG_RTW89_8852AE=m > > +CONFIG_RTW89_CORE=m > > +CONFIG_RTW89_DEBUG=y > > +CONFIG_RTW89_DEBUGFS=y > > +CONFIG_RTW89_DEBUGMSG=y > > +CONFIG_RTW89_PCI=m > > # CONFIG_RT_GROUP_SCHED is not set > > CONFIG_RT_MUTEXES=y > > CONFIG_RUNTIME_TESTING_MENU=y > > > > -- > ----------- > Tim Gardner > Canonical, Inc
diff --git a/debian.master/config/annotations b/debian.master/config/annotations index e0b9f55acae85..c9c4740609d10 100644 --- a/debian.master/config/annotations +++ b/debian.master/config/annotations @@ -6934,6 +6934,15 @@ CONFIG_RTW88_8821CE policy<{'amd64': 'm', 'arm64': ' CONFIG_RTW88_DEBUG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> CONFIG_RTW88_DEBUGFS policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> +# Menu: Device Drivers >> Network device support >> Wireless LAN >> Realtek devices >> Realtek 802.11ax wireless chips support +CONFIG_RTW89 policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> +CONFIG_RTW89_CORE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> +CONFIG_RTW89_PCI policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> +CONFIG_RTW89_8852AE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> +CONFIG_RTW89_DEBUG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> +CONFIG_RTW89_DEBUGMSG policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> +CONFIG_RTW89_DEBUGFS policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y'}> + # Menu: Device Drivers >> Network device support >> Wireless LAN >> Realtek devices >> Realtek rtlwifi family of devices CONFIG_RTL_CARDS policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> CONFIG_RTL8192CE policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu index 20c1ec9552be6..f189b2ae20265 100644 --- a/debian.master/config/config.common.ubuntu +++ b/debian.master/config/config.common.ubuntu @@ -9099,6 +9099,13 @@ CONFIG_RTW88_CORE=m CONFIG_RTW88_DEBUG=y CONFIG_RTW88_DEBUGFS=y CONFIG_RTW88_PCI=m +CONFIG_RTW89=m +CONFIG_RTW89_8852AE=m +CONFIG_RTW89_CORE=m +CONFIG_RTW89_DEBUG=y +CONFIG_RTW89_DEBUGFS=y +CONFIG_RTW89_DEBUGMSG=y +CONFIG_RTW89_PCI=m # CONFIG_RT_GROUP_SCHED is not set CONFIG_RT_MUTEXES=y CONFIG_RUNTIME_TESTING_MENU=y
BugLink: https://bugs.launchpad.net/bugs/1945967 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- debian.master/config/annotations | 9 +++++++++ debian.master/config/config.common.ubuntu | 7 +++++++ 2 files changed, 16 insertions(+)