| Message ID | 20210920201606.67892-1-dimitri.ledkov@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,FOCAL,hwe-5.13[PATCH] UBUNTU: [Packaging] Re-enable dbgsyms | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 9/20/21 2:16 PM, Dimitri John Ledkov wrote: > BugLink: https://bugs.launchpad.net/bugs/1939287 > > During v5.13 cycle, debug symbols building got fixed by running > install step during build, instead of binary. Allowing to build > multiple flavours with debug symbols without breaching disk space on > Launchpad builder. > > The packaging change that disabled dbgsyms unconditionally however > remained in the hwe-5.13 packaging, but can now be safely reverted to > reenable debug symbols builds. > > Fixes: a175d9b3c0 ("UBUNTU: [Packaging] Initial packaging import from linux-hwe-5.13") > Link: https://bugs.launchpad.net/bugs/1930713 > Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> > --- > debian/rules.d/0-common-vars.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/debian/rules.d/0-common-vars.mk b/debian/rules.d/0-common-vars.mk > index ef056f8426..3f045aa4d4 100644 > --- a/debian/rules.d/0-common-vars.mk > +++ b/debian/rules.d/0-common-vars.mk > @@ -77,7 +77,9 @@ endif > # The debug packages are ginormous, so you probably want to skip > # building them (as a developer). > # > +ifeq ($(full_build),false) > skipdbg=true > +endif > > abinum := $(shell echo $(revision) | sed -r -e 's/([^\+~]*)\.[^\.]+(~.*)?(\+.*)?$$/\1/')$(abi_suffix) > prev_abinum := $(shell echo $(prev_revision) | sed -r -e 's/([^\+~]*)\.[^\.]+(~.*)?(\+.*)?$$/\1/')$(abi_suffix) >
Sample builds of this change have been done in launchpad focal https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4672/+packages and one can see ~1GB large ddebs for all flavours and arches there.
On Mon, Sep 20, 2021 at 09:16:06PM +0100, Dimitri John Ledkov wrote: > BugLink: https://bugs.launchpad.net/bugs/1939287 > > During v5.13 cycle, debug symbols building got fixed by running > install step during build, instead of binary. Allowing to build > multiple flavours with debug symbols without breaching disk space on > Launchpad builder. > > The packaging change that disabled dbgsyms unconditionally however > remained in the hwe-5.13 packaging, but can now be safely reverted to > reenable debug symbols builds. > > Fixes: a175d9b3c0 ("UBUNTU: [Packaging] Initial packaging import from linux-hwe-5.13") > Link: https://bugs.launchpad.net/bugs/1930713 > Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> > --- Thanks for spotting this! Acked-by: Andrea Righi <andrea.righi@canonical.com>
Applied to hwe-5.13-next
diff --git a/debian/rules.d/0-common-vars.mk b/debian/rules.d/0-common-vars.mk index ef056f8426..3f045aa4d4 100644 --- a/debian/rules.d/0-common-vars.mk +++ b/debian/rules.d/0-common-vars.mk @@ -77,7 +77,9 @@ endif # The debug packages are ginormous, so you probably want to skip # building them (as a developer). # +ifeq ($(full_build),false) skipdbg=true +endif abinum := $(shell echo $(revision) | sed -r -e 's/([^\+~]*)\.[^\.]+(~.*)?(\+.*)?$$/\1/')$(abi_suffix) prev_abinum := $(shell echo $(prev_revision) | sed -r -e 's/([^\+~]*)\.[^\.]+(~.*)?(\+.*)?$$/\1/')$(abi_suffix)
BugLink: https://bugs.launchpad.net/bugs/1939287 During v5.13 cycle, debug symbols building got fixed by running install step during build, instead of binary. Allowing to build multiple flavours with debug symbols without breaching disk space on Launchpad builder. The packaging change that disabled dbgsyms unconditionally however remained in the hwe-5.13 packaging, but can now be safely reverted to reenable debug symbols builds. Fixes: a175d9b3c0 ("UBUNTU: [Packaging] Initial packaging import from linux-hwe-5.13") Link: https://bugs.launchpad.net/bugs/1930713 Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> --- debian/rules.d/0-common-vars.mk | 2 ++ 1 file changed, 2 insertions(+)