diff mbox series

[I/oracle] UBUNTU: [Config] oracle: Disable KCSAN

Message ID 20210906072020.14181-1-krzysztof.kozlowski@canonical.com
State New
Headers show
Series [I/oracle] UBUNTU: [Config] oracle: Disable KCSAN | expand

Commit Message

Krzysztof Kozlowski Sept. 6, 2021, 7:20 a.m. UTC
KCSAN reports several data-races when booted on Oracle instances (and on
other kernels as well). There are around 100 reports during boot, like:

    BUG: KCSAN: data-race in __mutex_lock.constprop.0+0xd0/0x750
    BUG: KCSAN: data-race in osq_lock / osq_lock
    BUG: KCSAN: data-race in tick_nohz_next_event / tick_nohz_stop_tick

Since main kernel has KCSAN disabled, remove it also from derivative.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 debian.oracle/config/config.common.ubuntu | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

Comments

Andrea Righi Sept. 6, 2021, 7:24 a.m. UTC | #1
On Mon, Sep 06, 2021 at 09:20:20AM +0200, Krzysztof Kozlowski wrote:
> KCSAN reports several data-races when booted on Oracle instances (and on
> other kernels as well). There are around 100 reports during boot, like:
> 
>     BUG: KCSAN: data-race in __mutex_lock.constprop.0+0xd0/0x750
>     BUG: KCSAN: data-race in osq_lock / osq_lock
>     BUG: KCSAN: data-race in tick_nohz_next_event / tick_nohz_stop_tick
> 
> Since main kernel has KCSAN disabled, remove it also from derivative.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

It's always a good thing to re-align config options with the main
kernel, therefore:

Acked-by: Andrea Righi <andrea.righi@canonical.com>

> ---
>  debian.oracle/config/config.common.ubuntu | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/debian.oracle/config/config.common.ubuntu b/debian.oracle/config/config.common.ubuntu
> index 89078f0655e7..22d256de537f 100644
> --- a/debian.oracle/config/config.common.ubuntu
> +++ b/debian.oracle/config/config.common.ubuntu
> @@ -4447,22 +4447,7 @@ CONFIG_KARMA_PARTITION=y
>  # CONFIG_KASAN is not set
>  CONFIG_KCMP=y
>  # CONFIG_KCOV is not set
> -CONFIG_KCSAN=y
> -CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=y
> -# CONFIG_KCSAN_DEBUG is not set
> -CONFIG_KCSAN_DELAY_RANDOMIZE=y
> -CONFIG_KCSAN_EARLY_ENABLE=y
> -# CONFIG_KCSAN_IGNORE_ATOMICS is not set
> -# CONFIG_KCSAN_INTERRUPT_WATCHER is not set
> -CONFIG_KCSAN_NUM_WATCHPOINTS=64
> -CONFIG_KCSAN_REPORT_ONCE_IN_MS=3000
> -CONFIG_KCSAN_REPORT_RACE_UNKNOWN_ORIGIN=y
> -CONFIG_KCSAN_REPORT_VALUE_CHANGE_ONLY=y
> -CONFIG_KCSAN_SELFTEST=y
> -CONFIG_KCSAN_SKIP_WATCH=4000
> -CONFIG_KCSAN_SKIP_WATCH_RANDOMIZE=y
> -CONFIG_KCSAN_UDELAY_INTERRUPT=20
> -CONFIG_KCSAN_UDELAY_TASK=80
> +# CONFIG_KCSAN is not set
>  CONFIG_KDB_CONTINUE_CATASTROPHIC=0
>  CONFIG_KDB_DEFAULT_ENABLE=0x1
>  CONFIG_KDB_KEYBOARD=y
> -- 
> 2.30.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza Sept. 6, 2021, 11:02 a.m. UTC | #2
On 06.09.21 09:20, Krzysztof Kozlowski wrote:
> KCSAN reports several data-races when booted on Oracle instances (and on
> other kernels as well). There are around 100 reports during boot, like:
> 
>      BUG: KCSAN: data-race in __mutex_lock.constprop.0+0xd0/0x750
>      BUG: KCSAN: data-race in osq_lock / osq_lock
>      BUG: KCSAN: data-race in tick_nohz_next_event / tick_nohz_stop_tick
> 
> Since main kernel has KCSAN disabled, remove it also from derivative.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks

> ---
>   debian.oracle/config/config.common.ubuntu | 17 +----------------
>   1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/debian.oracle/config/config.common.ubuntu b/debian.oracle/config/config.common.ubuntu
> index 89078f0655e7..22d256de537f 100644
> --- a/debian.oracle/config/config.common.ubuntu
> +++ b/debian.oracle/config/config.common.ubuntu
> @@ -4447,22 +4447,7 @@ CONFIG_KARMA_PARTITION=y
>   # CONFIG_KASAN is not set
>   CONFIG_KCMP=y
>   # CONFIG_KCOV is not set
> -CONFIG_KCSAN=y
> -CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=y
> -# CONFIG_KCSAN_DEBUG is not set
> -CONFIG_KCSAN_DELAY_RANDOMIZE=y
> -CONFIG_KCSAN_EARLY_ENABLE=y
> -# CONFIG_KCSAN_IGNORE_ATOMICS is not set
> -# CONFIG_KCSAN_INTERRUPT_WATCHER is not set
> -CONFIG_KCSAN_NUM_WATCHPOINTS=64
> -CONFIG_KCSAN_REPORT_ONCE_IN_MS=3000
> -CONFIG_KCSAN_REPORT_RACE_UNKNOWN_ORIGIN=y
> -CONFIG_KCSAN_REPORT_VALUE_CHANGE_ONLY=y
> -CONFIG_KCSAN_SELFTEST=y
> -CONFIG_KCSAN_SKIP_WATCH=4000
> -CONFIG_KCSAN_SKIP_WATCH_RANDOMIZE=y
> -CONFIG_KCSAN_UDELAY_INTERRUPT=20
> -CONFIG_KCSAN_UDELAY_TASK=80
> +# CONFIG_KCSAN is not set
>   CONFIG_KDB_CONTINUE_CATASTROPHIC=0
>   CONFIG_KDB_DEFAULT_ENABLE=0x1
>   CONFIG_KDB_KEYBOARD=y
>
Krzysztof Kozlowski Sept. 6, 2021, 11:03 a.m. UTC | #3
On 06/09/2021 09:20, Krzysztof Kozlowski wrote:
> KCSAN reports several data-races when booted on Oracle instances (and on
> other kernels as well). There are around 100 reports during boot, like:
> 
>     BUG: KCSAN: data-race in __mutex_lock.constprop.0+0xd0/0x750
>     BUG: KCSAN: data-race in osq_lock / osq_lock
>     BUG: KCSAN: data-race in tick_nohz_next_event / tick_nohz_stop_tick
> 
> Since main kernel has KCSAN disabled, remove it also from derivative.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  debian.oracle/config/config.common.ubuntu | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 

Applied


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/debian.oracle/config/config.common.ubuntu b/debian.oracle/config/config.common.ubuntu
index 89078f0655e7..22d256de537f 100644
--- a/debian.oracle/config/config.common.ubuntu
+++ b/debian.oracle/config/config.common.ubuntu
@@ -4447,22 +4447,7 @@  CONFIG_KARMA_PARTITION=y
 # CONFIG_KASAN is not set
 CONFIG_KCMP=y
 # CONFIG_KCOV is not set
-CONFIG_KCSAN=y
-CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=y
-# CONFIG_KCSAN_DEBUG is not set
-CONFIG_KCSAN_DELAY_RANDOMIZE=y
-CONFIG_KCSAN_EARLY_ENABLE=y
-# CONFIG_KCSAN_IGNORE_ATOMICS is not set
-# CONFIG_KCSAN_INTERRUPT_WATCHER is not set
-CONFIG_KCSAN_NUM_WATCHPOINTS=64
-CONFIG_KCSAN_REPORT_ONCE_IN_MS=3000
-CONFIG_KCSAN_REPORT_RACE_UNKNOWN_ORIGIN=y
-CONFIG_KCSAN_REPORT_VALUE_CHANGE_ONLY=y
-CONFIG_KCSAN_SELFTEST=y
-CONFIG_KCSAN_SKIP_WATCH=4000
-CONFIG_KCSAN_SKIP_WATCH_RANDOMIZE=y
-CONFIG_KCSAN_UDELAY_INTERRUPT=20
-CONFIG_KCSAN_UDELAY_TASK=80
+# CONFIG_KCSAN is not set
 CONFIG_KDB_CONTINUE_CATASTROPHIC=0
 CONFIG_KDB_DEFAULT_ENABLE=0x1
 CONFIG_KDB_KEYBOARD=y