From patchwork Thu Aug 19 06:14:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1518433 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GqvdD2vnsz9sVw; Thu, 19 Aug 2021 16:15:12 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mGbKW-00007W-R0; Thu, 19 Aug 2021 06:15:08 +0000 Received: from mail-pj1-f44.google.com ([209.85.216.44]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mGbK5-0008IM-I6 for kernel-team@lists.ubuntu.com; Thu, 19 Aug 2021 06:14:41 +0000 Received: by mail-pj1-f44.google.com with SMTP id w13-20020a17090aea0db029017897a5f7bcso4004296pjy.5 for ; Wed, 18 Aug 2021 23:14:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sCAYZGJBKbUAfqK7MwTGjAkunMkw2F6rcLC700+6JjU=; b=f3RX3Vry7+YITVP3RMohln6q/b7tazy3jGWLJoCD9vBQeCFdVQjQHVhhZpmSAiSF/W 9Y8Zu1OuWeVX5oaC445TBuCWfCZ1uHlS+vztzymGy3SAPTEjzzqFbOnU95Fappet2h3X 02SaC0b3ReE+PBGlTsnsrUM3U/A6NyXvSKe/PxElxfGHg4TtwsXR/MkW2tC+SbbgSf8e jYARdkYKOiIuQwr8Ff9imJ+FJV8QlHAGbGjSuSkMiXehlg8TIORWJYUuTwT55TVGc69a e+MuJWVbxtSlU90ghUeT/CagjOBpnwXUfRd9b7AaNi0cugacoREAqR2uXW0FNXtKEUBD tPHg== X-Gm-Message-State: AOAM532O1K2HLjomnMRzTtw3j4Z4LGsAGXzI9swkUYspwH6f3oD1AbQk aBGqXgX/q1COuqngNf9pOQdvSN9Gk7rn2w== X-Google-Smtp-Source: ABdhPJzO+u6xJS7aLc/E9PCRZgIAs1DgDLNQG0x8K6MqQIpk0Xk+VpO42ubQoAOvWo+vYnxp1QA/BQ== X-Received: by 2002:a17:90b:e18:: with SMTP id ge24mr13298406pjb.59.1629353679757; Wed, 18 Aug 2021 23:14:39 -0700 (PDT) Received: from localhost (114-47-140-65.dynamic-ip.hinet.net. [114.47.140.65]) by smtp.gmail.com with ESMTPSA id bv4sm1692924pjb.27.2021.08.18.23.14.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 23:14:39 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 05/30][SRU][OEM-5.13][I][U] ALSA: hda/cs8409: Reduce HS pops/clicks for Cyborg Date: Thu, 19 Aug 2021 14:14:01 +0800 Message-Id: <20210819061427.900601-6-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210819061427.900601-1-vicamo.yang@canonical.com> References: <20210819061427.900601-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.44; envelope-from=vicamo@gmail.com; helo=mail-pj1-f44.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Stefan Binding BugLink: https://bugs.launchpad.net/bugs/1939541 Enable HSBIAS_SENSE_EN for Cyborg during jack detect to reduce pops and clicks. Do not enable this for Warlock/Bullseye, as it causes ESD issues. Signed-off-by: Stefan Binding Signed-off-by: Vitaly Rodionov Link: https://lore.kernel.org/r/20210811185654.6837-6-vitalyr@opensource.cirrus.com Signed-off-by: Takashi Iwai (cherry picked from commit 29dbb9bcd3ea7f6c0385dfe714a5511865cd00c6) Signed-off-by: You-Sheng Yang --- sound/pci/hda/patch_cs8409.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_cs8409.c b/sound/pci/hda/patch_cs8409.c index e4319a0b9cf6..1745f8b188c6 100644 --- a/sound/pci/hda/patch_cs8409.c +++ b/sound/pci/hda/patch_cs8409.c @@ -390,8 +390,14 @@ static void cs8409_cs42l42_enable_jack_detect(struct hda_codec *codec) mutex_lock(&spec->cs8409_i2c_mux); - /* Set TIP_SENSE_EN for analog front-end of tip sense. */ - cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b70, 0x0020, 1); + /* Set TIP_SENSE_EN for analog front-end of tip sense. + * Additionally set HSBIAS_SENSE_EN for some variants. + */ + if (codec->fixup_id == CS8409_WARLOCK || codec->fixup_id == CS8409_BULLSEYE) + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b70, 0x0020, 1); + else + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b70, 0x00a0, 1); + /* Clear WAKE# */ cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b71, 0x0001, 1); /* Wait ~2.5ms */