diff mbox series

[3/3,SRU,Unstable] UBUTNU: [Config] Update configs for Dell's E-Privacy

Message ID 20210519032135.395668-11-koba.ko@canonical.com
State New
Headers show
Series None | expand

Commit Message

Koba Ko May 19, 2021, 3:21 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1928750

Signed-off-by: Koba Ko <koba.ko@canonical.com>
---
 debian.master/config/annotations          | 1 +
 debian.master/config/config.common.ubuntu | 1 +
 2 files changed, 2 insertions(+)

Comments

Timo Aaltonen May 22, 2021, 6:32 a.m. UTC | #1
On 19.5.2021 6.21, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928750
> 
> Signed-off-by: Koba Ko <koba.ko@canonical.com>
> ---
>   debian.master/config/annotations          | 1 +
>   debian.master/config/config.common.ubuntu | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 03e3dacba02d..d34a894c4306 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -10245,6 +10245,7 @@ CONFIG_DELL_SMO8800                             policy<{'amd64': 'm'}>
>   CONFIG_DELL_WMI_AIO                             policy<{'amd64': 'm'}>
>   CONFIG_DELL_WMI_LED                             policy<{'amd64': 'm'}>
>   CONFIG_DELL_WMI_SYSMAN                          policy<{'amd64': 'm'}>
> +CONFIG_DELL_PRIVACY                            	policy<{'amd64': 'm'}>
>   
>   # Menu: Device Drivers >> X86 Platform Specific Device Drivers >> Dell X86 Platform Specific Device Drivers >> Dell SMBIOS driver
>   CONFIG_DELL_SMBIOS                              policy<{'amd64': 'm'}>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 1caa404e4a2f..76ef35bc979f 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -2613,6 +2613,7 @@ CONFIG_DELL_SMBIOS=m
>   CONFIG_DELL_SMBIOS_SMM=y
>   CONFIG_DELL_SMBIOS_WMI=y
>   CONFIG_DELL_SMO8800=m
> +CONFIG_DELL_PRIVACY=m
>   CONFIG_DELL_UART_BACKLIGHT=m
>   CONFIG_DELL_WMI=m
>   CONFIG_DELL_WMI_AIO=m
> 

The config needs to be sorted, and annotations uses spaces, not tabs.
Koba Ko May 24, 2021, 8:09 a.m. UTC | #2
On Sat, May 22, 2021 at 2:32 PM Timo Aaltonen <tjaalton@ubuntu.com> wrote:

> On 19.5.2021 6.21, Koba Ko wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1928750
> >
> > Signed-off-by: Koba Ko <koba.ko@canonical.com>
> > ---
> >   debian.master/config/annotations          | 1 +
> >   debian.master/config/config.common.ubuntu | 1 +
> >   2 files changed, 2 insertions(+)
> >
> > diff --git a/debian.master/config/annotations
> b/debian.master/config/annotations
> > index 03e3dacba02d..d34a894c4306 100644
> > --- a/debian.master/config/annotations
> > +++ b/debian.master/config/annotations
> > @@ -10245,6 +10245,7 @@ CONFIG_DELL_SMO8800
>  policy<{'amd64': 'm'}>
> >   CONFIG_DELL_WMI_AIO                             policy<{'amd64': 'm'}>
> >   CONFIG_DELL_WMI_LED                             policy<{'amd64': 'm'}>
> >   CONFIG_DELL_WMI_SYSMAN                          policy<{'amd64': 'm'}>
> > +CONFIG_DELL_PRIVACY                                  policy<{'amd64':
> 'm'}>
> >
> >   # Menu: Device Drivers >> X86 Platform Specific Device Drivers >> Dell
> X86 Platform Specific Device Drivers >> Dell SMBIOS driver
> >   CONFIG_DELL_SMBIOS                              policy<{'amd64': 'm'}>
> > diff --git a/debian.master/config/config.common.ubuntu
> b/debian.master/config/config.common.ubuntu
> > index 1caa404e4a2f..76ef35bc979f 100644
> > --- a/debian.master/config/config.common.ubuntu
> > +++ b/debian.master/config/config.common.ubuntu
> > @@ -2613,6 +2613,7 @@ CONFIG_DELL_SMBIOS=m
> >   CONFIG_DELL_SMBIOS_SMM=y
> >   CONFIG_DELL_SMBIOS_WMI=y
> >   CONFIG_DELL_SMO8800=m
> > +CONFIG_DELL_PRIVACY=m
> >   CONFIG_DELL_UART_BACKLIGHT=m
> >   CONFIG_DELL_WMI=m
> >   CONFIG_DELL_WMI_AIO=m
> >
>
> The config needs to be sorted, and annotations uses spaces, not tabs.
>
Should I reSRU this?

> --
> t
>
Timo Aaltonen May 24, 2021, 8:12 a.m. UTC | #3
On 24.5.2021 11.09, Koba Ko wrote:
> 
> On Sat, May 22, 2021 at 2:32 PM Timo Aaltonen <tjaalton@ubuntu.com 
> <mailto:tjaalton@ubuntu.com>> wrote:
> 
>     On 19.5.2021 6.21, Koba Ko wrote:
>      > BugLink: https://bugs.launchpad.net/bugs/1928750
>     <https://bugs.launchpad.net/bugs/1928750>
>      >
>      > Signed-off-by: Koba Ko <koba.ko@canonical.com
>     <mailto:koba.ko@canonical.com>>
>      > ---
>      >   debian.master/config/annotations          | 1 +
>      >   debian.master/config/config.common.ubuntu | 1 +
>      >   2 files changed, 2 insertions(+)
>      >
>      > diff --git a/debian.master/config/annotations
>     b/debian.master/config/annotations
>      > index 03e3dacba02d..d34a894c4306 100644
>      > --- a/debian.master/config/annotations
>      > +++ b/debian.master/config/annotations
>      > @@ -10245,6 +10245,7 @@ CONFIG_DELL_SMO8800                     
>             policy<{'amd64': 'm'}>
>      >   CONFIG_DELL_WMI_AIO                           
>       policy<{'amd64': 'm'}>
>      >   CONFIG_DELL_WMI_LED                           
>       policy<{'amd64': 'm'}>
>      >   CONFIG_DELL_WMI_SYSMAN                         
>     policy<{'amd64': 'm'}>
>      > +CONFIG_DELL_PRIVACY                                 
>     policy<{'amd64': 'm'}>
>      >
>      >   # Menu: Device Drivers >> X86 Platform Specific Device Drivers
>      >> Dell X86 Platform Specific Device Drivers >> Dell SMBIOS driver
>      >   CONFIG_DELL_SMBIOS                             
>     policy<{'amd64': 'm'}>
>      > diff --git a/debian.master/config/config.common.ubuntu
>     b/debian.master/config/config.common.ubuntu
>      > index 1caa404e4a2f..76ef35bc979f 100644
>      > --- a/debian.master/config/config.common.ubuntu
>      > +++ b/debian.master/config/config.common.ubuntu
>      > @@ -2613,6 +2613,7 @@ CONFIG_DELL_SMBIOS=m
>      >   CONFIG_DELL_SMBIOS_SMM=y
>      >   CONFIG_DELL_SMBIOS_WMI=y
>      >   CONFIG_DELL_SMO8800=m
>      > +CONFIG_DELL_PRIVACY=m
>      >   CONFIG_DELL_UART_BACKLIGHT=m
>      >   CONFIG_DELL_WMI=m
>      >   CONFIG_DELL_WMI_AIO=m
>      >
> 
>     The config needs to be sorted, and annotations uses spaces, not tabs.
> 
> Should I reSRU this?

for unstable, yes
Koba Ko May 24, 2021, 8:25 a.m. UTC | #4
On Mon, May 24, 2021 at 4:12 PM Timo Aaltonen <tjaalton@ubuntu.com> wrote:

> On 24.5.2021 11.09, Koba Ko wrote:
> >
> > On Sat, May 22, 2021 at 2:32 PM Timo Aaltonen <tjaalton@ubuntu.com
> > <mailto:tjaalton@ubuntu.com>> wrote:
> >
> >     On 19.5.2021 6.21, Koba Ko wrote:
> >      > BugLink: https://bugs.launchpad.net/bugs/1928750
> >     <https://bugs.launchpad.net/bugs/1928750>
> >      >
> >      > Signed-off-by: Koba Ko <koba.ko@canonical.com
> >     <mailto:koba.ko@canonical.com>>
> >      > ---
> >      >   debian.master/config/annotations          | 1 +
> >      >   debian.master/config/config.common.ubuntu | 1 +
> >      >   2 files changed, 2 insertions(+)
> >      >
> >      > diff --git a/debian.master/config/annotations
> >     b/debian.master/config/annotations
> >      > index 03e3dacba02d..d34a894c4306 100644
> >      > --- a/debian.master/config/annotations
> >      > +++ b/debian.master/config/annotations
> >      > @@ -10245,6 +10245,7 @@ CONFIG_DELL_SMO8800
> >             policy<{'amd64': 'm'}>
> >      >   CONFIG_DELL_WMI_AIO
> >       policy<{'amd64': 'm'}>
> >      >   CONFIG_DELL_WMI_LED
> >       policy<{'amd64': 'm'}>
> >      >   CONFIG_DELL_WMI_SYSMAN
> >     policy<{'amd64': 'm'}>
> >      > +CONFIG_DELL_PRIVACY
> >     policy<{'amd64': 'm'}>
> >      >
> >      >   # Menu: Device Drivers >> X86 Platform Specific Device Drivers
> >      >> Dell X86 Platform Specific Device Drivers >> Dell SMBIOS driver
> >      >   CONFIG_DELL_SMBIOS
> >     policy<{'amd64': 'm'}>
> >      > diff --git a/debian.master/config/config.common.ubuntu
> >     b/debian.master/config/config.common.ubuntu
> >      > index 1caa404e4a2f..76ef35bc979f 100644
> >      > --- a/debian.master/config/config.common.ubuntu
> >      > +++ b/debian.master/config/config.common.ubuntu
> >      > @@ -2613,6 +2613,7 @@ CONFIG_DELL_SMBIOS=m
> >      >   CONFIG_DELL_SMBIOS_SMM=y
> >      >   CONFIG_DELL_SMBIOS_WMI=y
> >      >   CONFIG_DELL_SMO8800=m
> >      > +CONFIG_DELL_PRIVACY=m
> >      >   CONFIG_DELL_UART_BACKLIGHT=m
> >      >   CONFIG_DELL_WMI=m
> >      >   CONFIG_DELL_WMI_AIO=m
> >      >
> >
> >     The config needs to be sorted, and annotations uses spaces, not tabs.
> >
> > Should I reSRU this?
>
> for unstable, yes
>
ok, i will sru it for unstable.
Thanks

>
> --
> t
>
Koba Ko May 27, 2021, 2:54 a.m. UTC | #5
NACK for Unstable

On Wed, May 19, 2021 at 11:22 AM Koba Ko <koba.ko@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1928750
>
> Signed-off-by: Koba Ko <koba.ko@canonical.com>
> ---
>  debian.master/config/annotations          | 1 +
>  debian.master/config/config.common.ubuntu | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 03e3dacba02d..d34a894c4306 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -10245,6 +10245,7 @@ CONFIG_DELL_SMO8800                             policy<{'amd64': 'm'}>
>  CONFIG_DELL_WMI_AIO                             policy<{'amd64': 'm'}>
>  CONFIG_DELL_WMI_LED                             policy<{'amd64': 'm'}>
>  CONFIG_DELL_WMI_SYSMAN                          policy<{'amd64': 'm'}>
> +CONFIG_DELL_PRIVACY                                    policy<{'amd64': 'm'}>
>
>  # Menu: Device Drivers >> X86 Platform Specific Device Drivers >> Dell X86 Platform Specific Device Drivers >> Dell SMBIOS driver
>  CONFIG_DELL_SMBIOS                              policy<{'amd64': 'm'}>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 1caa404e4a2f..76ef35bc979f 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -2613,6 +2613,7 @@ CONFIG_DELL_SMBIOS=m
>  CONFIG_DELL_SMBIOS_SMM=y
>  CONFIG_DELL_SMBIOS_WMI=y
>  CONFIG_DELL_SMO8800=m
> +CONFIG_DELL_PRIVACY=m
>  CONFIG_DELL_UART_BACKLIGHT=m
>  CONFIG_DELL_WMI=m
>  CONFIG_DELL_WMI_AIO=m
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 03e3dacba02d..d34a894c4306 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -10245,6 +10245,7 @@  CONFIG_DELL_SMO8800                             policy<{'amd64': 'm'}>
 CONFIG_DELL_WMI_AIO                             policy<{'amd64': 'm'}>
 CONFIG_DELL_WMI_LED                             policy<{'amd64': 'm'}>
 CONFIG_DELL_WMI_SYSMAN                          policy<{'amd64': 'm'}>
+CONFIG_DELL_PRIVACY                            	policy<{'amd64': 'm'}>
 
 # Menu: Device Drivers >> X86 Platform Specific Device Drivers >> Dell X86 Platform Specific Device Drivers >> Dell SMBIOS driver
 CONFIG_DELL_SMBIOS                              policy<{'amd64': 'm'}>
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 1caa404e4a2f..76ef35bc979f 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -2613,6 +2613,7 @@  CONFIG_DELL_SMBIOS=m
 CONFIG_DELL_SMBIOS_SMM=y
 CONFIG_DELL_SMBIOS_WMI=y
 CONFIG_DELL_SMO8800=m
+CONFIG_DELL_PRIVACY=m
 CONFIG_DELL_UART_BACKLIGHT=m
 CONFIG_DELL_WMI=m
 CONFIG_DELL_WMI_AIO=m