From patchwork Thu May 13 22:10:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 1478219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fh5TZ2GLkz9sWX; Fri, 14 May 2021 08:11:14 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lhJXz-0000L6-Kc; Thu, 13 May 2021 22:11:11 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lhJXu-0000K4-Tc for kernel-team@lists.ubuntu.com; Thu, 13 May 2021 22:11:06 +0000 Received: from mail-pf1-f197.google.com ([209.85.210.197]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lhJXu-0007i7-Me for kernel-team@lists.ubuntu.com; Thu, 13 May 2021 22:11:06 +0000 Received: by mail-pf1-f197.google.com with SMTP id 125-20020a6215830000b029028ef0e94e38so18653365pfv.13 for ; Thu, 13 May 2021 15:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gL8TdQioJET/A69Ct3nMvO3k9GciZK9KjcsV7OMJJw4=; b=fT/i9V2u6S2lkzo2rarqJiCWjhMmMYocjcQ7KvXbxd0M2E1KKAs5puitzoaWFRokCq Hf1OroV/qT8H/Ks6hKJ0fNbi8K/6SNG4lhEzolNR6DSdY1dpG60ZI7SuJ0tCGfqdyhir d8t2i/buGmq2N7UrKyyhSxhiyP35td8JsFS0QvfwZnJqxAd1ibSkovjoJDRWilkJauDl KaTsHOKTnQL+KzskvFyBesmBINPPoMmJ3/DGYYa5+mzbdvJlNnNXryj3GqnC+UslGSU3 P7lSNaoiDLE6y321ZycGOmG0H7padsplSB1SocobiB5pQ7GnXQyyfDXXQfgOD5g63SzO He5A== X-Gm-Message-State: AOAM532ffas5VVTR3TrJiYzO0j7eHf9b7aX53LEVGqvf86B2AU7L8wyl WvALDDZt4Tr6W/D1jarJfdEdnmM5V0YB97xidckpDv1scJKI4mE7NcN45ziYEkBs2m1NfTieqnI 2K6jh3ytkKWlns2zOswLU679JPK9L3amfSc0nve7S5g== X-Received: by 2002:a17:90b:4a02:: with SMTP id kk2mr3903083pjb.105.1620943865113; Thu, 13 May 2021 15:11:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2Fx1UqpLc0MK01iSo1yvLIPraOjVwsvQVNeMEoZDXL1y/zYapc2clhAeGZij3DBC2+HJj7w== X-Received: by 2002:a17:90b:4a02:: with SMTP id kk2mr3903072pjb.105.1620943864920; Thu, 13 May 2021 15:11:04 -0700 (PDT) Received: from localhost.localdomain (mail.tpi.com. [50.126.108.186]) by smtp.gmail.com with ESMTPSA id n9sm2945748pgt.35.2021.05.13.15.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 15:11:04 -0700 (PDT) From: Tim Gardner To: kernel-team@lists.ubuntu.com Subject: [PATCH][bionic:linux-raspi2] UBUNTU: [Config] raspi2: CONFIG_LATENCYTOP=n Date: Thu, 13 May 2021 15:10:58 -0700 Message-Id: <20210513221058.12977-2-tim.gardner@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210513221058.12977-1-tim.gardner@canonical.com> References: <20210513221058.12977-1-tim.gardner@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1928394 There were some recent changes on the main kernels to fix some syntax issues with the annotations files (Propagate "Update annotations and fix errors" to all derivatives), after I replicated the changes from bionic/linux to bionic/linux-raspi2 I started getting this enforcement error: check-config: FAIL (y != n): CONFIG_LATENCYTOP policy<{'amd64-generic': 'n', 'amd64-lowlatency': 'y', 'arm64': 'n', 'armhf': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}> mark note It seems we were supposed to have the same enforcement as the main kernel (= n) but the raspi2 config has it actually enabled. Looking at the url and the bug reference on the enforcement notes, it seems it doesn't make much sense to keep it enabled for non-lowlatency kernels. @juerghaefliger confirmed we should disable this option: Yes, it should be disabled. I did the same for hirsute earlier this year after Seth fixed the master config annotations: ~ubuntu-kernel/ubuntu/+source/linux-raspi/+git/hirsute - [no description] If I remember correctly I made some other config changes due to Seth's changes. Signed-off-by: Tim Gardner Acked-by: Colin Ian King Acked-by: Kamal Mostafa --- debian.raspi2/config/config.common.ubuntu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian.raspi2/config/config.common.ubuntu b/debian.raspi2/config/config.common.ubuntu index e024862197840..51b19efdfba9c 100644 --- a/debian.raspi2/config/config.common.ubuntu +++ b/debian.raspi2/config/config.common.ubuntu @@ -3032,7 +3032,7 @@ CONFIG_L2TP_IP=m CONFIG_L2TP_V3=y CONFIG_LAPB=m CONFIG_LAPBETHER=m -CONFIG_LATENCYTOP=y +# CONFIG_LATENCYTOP is not set CONFIG_LATTICE_ECP3_CONFIG=m CONFIG_LBDAF=y CONFIG_LCD_AMS369FG06=m