| Message ID | 20210414160037.15265-2-tim.gardner@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | Revert "cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath." | expand |
On 14.04.21 18:00, Tim Gardner wrote: > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > BugLink: https://bugs.launchpad.net/bugs/1923670 > > This reverts commit a2c5e4a083a7e24b35b3eb808b760af6de15bac2 which is > commit a738c93fb1c17e386a09304b517b1c6b2a6a5a8b upstream. > > It is reported to cause problems in older kernels, so revert it for now > until we can figure it out... > > Reported-by: Salvatore Bonaccorso <carnil@debian.org> > Link: https://lore.kernel.org/r/YG7r0UaivWZL762N@eldamar.lan > Cc: Shyam Prasad N <sprasad@microsoft.com> > Cc: Aurelien Aptel <aaptel@suse.com> > Cc: Steve French <stfrench@microsoft.com> > Cc: Sasha Levin <sashal@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > (cherry picked from commit ea42fd91d3041b81d704624b87f35b56f3a00841 v5.4.y) > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Thanks > --- > fs/cifs/connect.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 67c2e6487479..ab9eeb5ff8e5 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -4198,7 +4198,6 @@ int cifs_setup_cifs_sb(struct smb_vol *pvolume_info, > cifs_sb->prepath = kstrdup(pvolume_info->prepath, GFP_KERNEL); > if (cifs_sb->prepath == NULL) > return -ENOMEM; > - cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_USE_PREFIX_PATH; > } > > return 0; >
Acked-by: Kamal Mostafa <kamal@canonical.com> -Kamal On Wed, Apr 14, 2021 at 10:00:37AM -0600, Tim Gardner wrote: > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > BugLink: https://bugs.launchpad.net/bugs/1923670 > > This reverts commit a2c5e4a083a7e24b35b3eb808b760af6de15bac2 which is > commit a738c93fb1c17e386a09304b517b1c6b2a6a5a8b upstream. > > It is reported to cause problems in older kernels, so revert it for now > until we can figure it out... > > Reported-by: Salvatore Bonaccorso <carnil@debian.org> > Link: https://lore.kernel.org/r/YG7r0UaivWZL762N@eldamar.lan > Cc: Shyam Prasad N <sprasad@microsoft.com> > Cc: Aurelien Aptel <aaptel@suse.com> > Cc: Steve French <stfrench@microsoft.com> > Cc: Sasha Levin <sashal@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > (cherry picked from commit ea42fd91d3041b81d704624b87f35b56f3a00841 v5.4.y) > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > fs/cifs/connect.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 67c2e6487479..ab9eeb5ff8e5 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -4198,7 +4198,6 @@ int cifs_setup_cifs_sb(struct smb_vol *pvolume_info, > cifs_sb->prepath = kstrdup(pvolume_info->prepath, GFP_KERNEL); > if (cifs_sb->prepath == NULL) > return -ENOMEM; > - cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_USE_PREFIX_PATH; > } > > return 0; > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 67c2e6487479..ab9eeb5ff8e5 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -4198,7 +4198,6 @@ int cifs_setup_cifs_sb(struct smb_vol *pvolume_info, cifs_sb->prepath = kstrdup(pvolume_info->prepath, GFP_KERNEL); if (cifs_sb->prepath == NULL) return -ENOMEM; - cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_USE_PREFIX_PATH; } return 0;