From patchwork Wed Feb 24 08:48:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1443752 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DlqNP0hVpz9sVV; Wed, 24 Feb 2021 19:49:23 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lEprC-0002I0-EX; Wed, 24 Feb 2021 08:49:18 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lEprA-0002Hc-Eg for kernel-team@lists.ubuntu.com; Wed, 24 Feb 2021 08:49:16 +0000 Received: from mail-pg1-f197.google.com ([209.85.215.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lEprA-0002bn-1c for kernel-team@lists.ubuntu.com; Wed, 24 Feb 2021 08:49:16 +0000 Received: by mail-pg1-f197.google.com with SMTP id o11so1219743pgv.6 for ; Wed, 24 Feb 2021 00:49:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yCxJw0KH3JnIX7JPeV7s74QC+Lyvi2FSrcAuHp7xlFQ=; b=JplU+NYjYTtpbrx+/maHrsZrCXPalEPrfFdAsWfbPr5o6oLHCfg9JWfTekZWQviibi nHsW7KnUmxA+OLDbu8vGkOuUo1DCQVIYJt1gdYHilfXw2IM/sbD92PsFLzqiq1oR4bbJ nFUTm7XCmNs3m/jHYdOLI05A+eOWgAsmJcVOn45ZM0OZ5mlme6FooTw26hzJFMzLfWb9 tU0FbWsWTLLwSWgXOepLV+rN+9MHuLAasAbWMBLxvHBU9E+3x+rSDOR+kNVgSmHKIo5D MubFFaTwsvTIio1ppSgArmZUUgCu1flX4cYWvcqoKHnCWgVNfmBo8ulq3f21rg825L1k qzsw== X-Gm-Message-State: AOAM5337sNaUwOAYVi3l8JPw2VHeyppfmUq4lc3KRlSmrI6JtIlELTqR HSTfgYNmzaR2qnytoZeO/qjZ35b+vnYx2DJjaGnZNJT+xq7dhhHITchoEqPRfmprqLCNCnUMsUF ANX3pYe++Nk2gGM9X+MTMKmEm8KypjIxV4szFbkUN X-Received: by 2002:a17:90a:4301:: with SMTP id q1mr3364927pjg.57.1614156554748; Wed, 24 Feb 2021 00:49:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpbs3lvRfyWtj1+UklR8qcScClm7XrK0yBBr4BThxgZH/kejyquZmP6RuefzOO6hgF1QryFA== X-Received: by 2002:a17:90a:4301:: with SMTP id q1mr3364911pjg.57.1614156554524; Wed, 24 Feb 2021 00:49:14 -0800 (PST) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id gj12sm1701061pjb.25.2021.02.24.00.49.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 00:49:13 -0800 (PST) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [F/G/H][Unstable][SRU][PATCH 1/1] selftests/powerpc: Make the test check in eeh-basic.sh posix compliant Date: Wed, 24 Feb 2021 16:48:00 +0800 Message-Id: <20210224084800.34528-2-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210224084800.34528-1-po-hsu.lin@canonical.com> References: <20210224084800.34528-1-po-hsu.lin@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1909428 The == operand is a bash extension, thus this will fail on Ubuntu with: ./eeh-basic.sh: 89: test: 2: unexpected operator As the /bin/sh on Ubuntu is pointed to DASH. Use -eq to fix this posix compatibility issue. Fixes: 996f9e0f93f162 ("selftests/powerpc: Fix eeh-basic.sh exit codes") Signed-off-by: Po-Hsu Lin Reviewed-by: Frederic Barrat Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20201228043459.14281-1-po-hsu.lin@canonical.com --- tools/testing/selftests/powerpc/eeh/eeh-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh index cf001a2c6942..7c2cb04569da 100755 --- a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh +++ b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh @@ -81,5 +81,5 @@ echo "$failed devices failed to recover ($dev_count tested)" lspci | diff -u $pre_lspci - rm -f $pre_lspci -test "$failed" == 0 +test "$failed" -eq 0 exit $?