diff mbox series

[1/1] UBUNTU: SAUCE: drm/i915: Force DPCD backlight mode for BOE 2270 panel

Message ID 20201210081644.293291-2-aaron.ma@canonical.com
State New
Headers show
Series UBUNTU: SAUCE: Fix brightness control on BOE 2270 panel | expand

Commit Message

Aaron Ma Dec. 10, 2020, 8:16 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1904991

BOE 2270 panel failed to control backlight brightness.
Add it in edid quirks to force using DPCD backlight control.
Then the brightness can be controlled.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201009085750.88490-2-aaron.ma@canonical.com
(backported from commit 055f8458d95a38c20e8360634255f684378179eb
https://anongit.freedesktop.org/git/drm-intel.git)
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 drivers/gpu/drm/drm_dp_helper.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kleber Souza Dec. 15, 2020, 10:24 a.m. UTC | #1
On 10.12.20 09:16, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1904991
> 
> BOE 2270 panel failed to control backlight brightness.
> Add it in edid quirks to force using DPCD backlight control.
> Then the brightness can be controlled.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201009085750.88490-2-aaron.ma@canonical.com
> (backported from commit 055f8458d95a38c20e8360634255f684378179eb
> https://anongit.freedesktop.org/git/drm-intel.git)
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>   drivers/gpu/drm/drm_dp_helper.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index c8b70b52b4d9..ee9fb6569e7a 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1326,6 +1326,7 @@ static const struct edid_quirk edid_quirk_list[] = {
>   	 * PSR being enabled.
>   	 */
>   	{ MFG(0x0d, 0xae), PROD_ID(0x19, 0x15), BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT) },
> +	{ MFG(0x09, 0xe5), PROD_ID(0xde, 0x08), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>   };
>   
>   #undef MFG
>
Stefan Bader Dec. 16, 2020, 8:51 a.m. UTC | #2
On 10.12.20 09:16, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1904991
> 
> BOE 2270 panel failed to control backlight brightness.
> Add it in edid quirks to force using DPCD backlight control.
> Then the brightness can be controlled.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201009085750.88490-2-aaron.ma@canonical.com(backported from commit 055f8458d95a38c20e8360634255f684378179eb)
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

This is upstream now, so we should adjust provenance and drop the "UBUNTU:
SAUCE:" when applying.

-Stefan

>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index c8b70b52b4d9..ee9fb6569e7a 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1326,6 +1326,7 @@ static const struct edid_quirk edid_quirk_list[] = {
>  	 * PSR being enabled.
>  	 */
>  	{ MFG(0x0d, 0xae), PROD_ID(0x19, 0x15), BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT) },
> +	{ MFG(0x09, 0xe5), PROD_ID(0xde, 0x08), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  };
>  
>  #undef MFG
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index c8b70b52b4d9..ee9fb6569e7a 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1326,6 +1326,7 @@  static const struct edid_quirk edid_quirk_list[] = {
 	 * PSR being enabled.
 	 */
 	{ MFG(0x0d, 0xae), PROD_ID(0x19, 0x15), BIT(DP_QUIRK_FORCE_PSR_CHIP_DEFAULT) },
+	{ MFG(0x09, 0xe5), PROD_ID(0xde, 0x08), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
 };
 
 #undef MFG