diff mbox series

[v2] UBUNTU: SAUCE: PCI: Enable ACS quirk on all CML root ports

Message ID 20201022055146.15875-2-kai.heng.feng@canonical.com
State New
Headers show
Series [v2] UBUNTU: SAUCE: PCI: Enable ACS quirk on all CML root ports | expand

Commit Message

Kai-Heng Feng Oct. 22, 2020, 5:51 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1895718

In addition to KIOXIA NVMe, Intel NVMe under another root port also has
the same ACS violation issue.

According to Intel, all CML root ports need this workaround, so add all
root ports from [1] to existing quirk.

[1] Intel® 400 Series Chipset Family Platform Controller Hub (PCH) Datasheet, Volume 1 of 2, Content ID: 620854	Version: 002

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/pci/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Bader Oct. 22, 2020, 6:43 a.m. UTC | #1
On 22.10.20 07:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1895718

BugLink: https://bugs.launchpad.net/bugs/1900847

> 
> In addition to KIOXIA NVMe, Intel NVMe under another root port also has
> the same ACS violation issue.
> 
> According to Intel, all CML root ports need this workaround, so add all
> root ports from [1] to existing quirk.
> 
> [1] Intel® 400 Series Chipset Family Platform Controller Hub (PCH) Datasheet, Volume 1 of 2, Content ID: 620854	Version: 002
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

Maybe you should use titles in bug reports which differ in more than just a
word. ;) The BugLink in the patch needs to be adjusted before applying.

-Stefan

>  drivers/pci/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index cfa7387a12b9..706f27a86a8e 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4665,7 +4665,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
>  		return false;
>  
>  	switch (dev->device) {
> -	case 0x06ac: /* Comet Lake */
> +	case 0x06ac ... 0x06c3: /* Comet Lake */
>  	case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
>  	case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
>  	case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
>
Kleber Souza Oct. 22, 2020, 7:51 a.m. UTC | #2
On 22.10.20 07:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1895718
> 
> In addition to KIOXIA NVMe, Intel NVMe under another root port also has
> the same ACS violation issue.
> 
> According to Intel, all CML root ports need this workaround, so add all
> root ports from [1] to existing quirk.
> 
> [1] Intel® 400 Series Chipset Family Platform Controller Hub (PCH) Datasheet, Volume 1 of 2, Content ID: 620854	Version: 002
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

With the BugLink fixed:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  drivers/pci/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index cfa7387a12b9..706f27a86a8e 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4665,7 +4665,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
>  		return false;
>  
>  	switch (dev->device) {
> -	case 0x06ac: /* Comet Lake */
> +	case 0x06ac ... 0x06c3: /* Comet Lake */
>  	case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
>  	case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
>  	case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
>
Ian May Oct. 22, 2020, 6:28 p.m. UTC | #3
Applied to Focal/master-next

Also adjusted Buglink on patch to 1900847

Thanks,
Ian

On 2020-10-22 13:51:46 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1895718
> 
> In addition to KIOXIA NVMe, Intel NVMe under another root port also has
> the same ACS violation issue.
> 
> According to Intel, all CML root ports need this workaround, so add all
> root ports from [1] to existing quirk.
> 
> [1] Intel® 400 Series Chipset Family Platform Controller Hub (PCH) Datasheet, Volume 1 of 2, Content ID: 620854	Version: 002
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/pci/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index cfa7387a12b9..706f27a86a8e 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4665,7 +4665,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
>  		return false;
>  
>  	switch (dev->device) {
> -	case 0x06ac: /* Comet Lake */
> +	case 0x06ac ... 0x06c3: /* Comet Lake */
>  	case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
>  	case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
>  	case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Souza Oct. 27, 2020, 10:33 a.m. UTC | #4
On 22.10.20 07:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1895718
> 
> In addition to KIOXIA NVMe, Intel NVMe under another root port also has
> the same ACS violation issue.
> 
> According to Intel, all CML root ports need this workaround, so add all
> root ports from [1] to existing quirk.
> 
> [1] Intel® 400 Series Chipset Family Platform Controller Hub (PCH) Datasheet, Volume 1 of 2, Content ID: 620854	Version: 002
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied to groovy/linux with the adjusted BugLink.

Thanks,
Kleber

> ---
>   drivers/pci/quirks.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index cfa7387a12b9..706f27a86a8e 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4665,7 +4665,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
>   		return false;
>   
>   	switch (dev->device) {
> -	case 0x06ac: /* Comet Lake */
> +	case 0x06ac ... 0x06c3: /* Comet Lake */
>   	case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
>   	case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
>   	case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
>
diff mbox series

Patch

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index cfa7387a12b9..706f27a86a8e 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4665,7 +4665,7 @@  static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
 		return false;
 
 	switch (dev->device) {
-	case 0x06ac: /* Comet Lake */
+	case 0x06ac ... 0x06c3: /* Comet Lake */
 	case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
 	case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
 	case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */