From patchwork Tue Aug 18 18:43:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 1347227 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BWKbz1P9pz9sTT; Wed, 19 Aug 2020 04:45:33 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1k86bw-0001p1-G3; Tue, 18 Aug 2020 18:45:28 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k86bu-0001or-Rd for kernel-team@lists.ubuntu.com; Tue, 18 Aug 2020 18:45:26 +0000 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k86bu-0001xM-7K for kernel-team@lists.ubuntu.com; Tue, 18 Aug 2020 18:45:26 +0000 Received: by mail-qk1-f199.google.com with SMTP id 3so13758373qkv.13 for ; Tue, 18 Aug 2020 11:45:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ycuBU7+sMvU8rB9N3VGfjsX3Nkw+Y6GpnH4jyGRNanI=; b=EluztGQNTh0dyjyCA/XK1bo8Yh73cj3jKD+6iVQm0Wwb3ChtxIaewEsqfZs2I9IIlu yGE1+QZ0EBcLYYxLIhzTyYpYeA89jiE4uQqkIC41r+jNGGtQ3PbOHmslAjghUUXmjazK E8r3ONorTqEoDhxUXQbhytR0L+nll0QVb5FrhxxAdZAwEK6CiNo+b4GtL88jUs9uCsK3 KaBwiX+yO1RDL0hugzC2CujUR9cMyXs+SUqXakdURlzpnlrxtniLuL0OVVI/R9ZtG/3i z3aJdaXVfbccHrU5cwDgY29I19BYEaKA/zmYqpWFpnlVn+fHueEd7VhHOil59MSNqUHj 2FbA== X-Gm-Message-State: AOAM531UtQQirM/8/EZUqk8y1qYXYeNNc9HdvV6yq0lOVVT44+q0IsF3 6dkHqbPIK06poS0NPy1r7WEYbZ0PiEBiRXMyx6FMCq40N19jzqsUvsCuF1mdawNIL/ELza8k8bt vVm4SzUvUi4Ntph+3dJY9blNKV+4JgYdy4wuX5otuWA== X-Received: by 2002:a37:d201:: with SMTP id f1mr18251345qkj.188.1597776324723; Tue, 18 Aug 2020 11:45:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVpCal92wNGyJXMczqEdtKo2oqhcaYRMgg4yxn3rptOAJ9lZaJut4c899pSwd4H/ypnbqhWQ== X-Received: by 2002:a37:d201:: with SMTP id f1mr18251332qkj.188.1597776324437; Tue, 18 Aug 2020 11:45:24 -0700 (PDT) Received: from localhost.localdomain (072-189-064-225.res.spectrum.com. [72.189.64.225]) by smtp.gmail.com with ESMTPSA id d16sm21280699qkk.106.2020.08.18.11.45.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 11:45:23 -0700 (PDT) From: William Breathitt Gray To: kernel-team@lists.ubuntu.com Subject: [SRU][FOCAL/linux-azure][BIONIC/linux-azure-4.15][PATCH 1/1] Drivers: hv: vmbus: Only notify Hyper-V for die events that are oops Date: Tue, 18 Aug 2020 14:43:03 -0400 Message-Id: <20200818184303.56912-2-william.gray@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200818184303.56912-1-william.gray@canonical.com> References: <20200818184303.56912-1-william.gray@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Michael Kelley Hyper-V currently may be notified of a panic for any die event. But this results in false panic notifications for various user space traps that are die events. Fix this by ignoring die events that aren't oops. Fixes: 510f7aef65bb ("Drivers: hv: vmbus: prefer 'die' notification chain to 'panic'") Signed-off-by: Michael Kelley Reviewed-by: Vitaly Kuznetsov Link: https://lore.kernel.org/r/1596730935-11564-1-git-send-email-mikelley@microsoft.com Signed-off-by: Wei Liu BugLink: https://bugs.launchpad.net/bugs/1891222 (cherry picked from commit 608a973bd52ef1705941b18f55e39655fcfe9cdb) Signed-off-by: William Breathitt Gray Acked-by: Thadeu Lima de Souza Cascardo --- drivers/hv/vmbus_drv.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 0f168f0b1a8f..c97f1964d9ed 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -97,6 +97,10 @@ static int hyperv_die_event(struct notifier_block *nb, unsigned long val, struct die_args *die = (struct die_args *)args; struct pt_regs *regs = die->regs; + /* Don't notify Hyper-V if the die event is other than oops */ + if (val != DIE_OOPS) + return NOTIFY_DONE; + /* * Hyper-V should be notified only once about a panic. If we will be * doing hyperv_report_panic_msg() later with kmsg data, don't do