| Message ID | 20200623090118.26107-1-juergh@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,focal/linux-raspi] UBUNTU: [Packaging] raspi: Depend on crda | expand |
What about bionic that is also listed in the bug? On Tue, Jun 23, 2020 at 11:01:18AM +0200, Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1877415 > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- > debian.raspi/control.d/flavour-control.stub | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.raspi/control.d/flavour-control.stub b/debian.raspi/control.d/flavour-control.stub > index ce8b81a11f60..9f5d47e91d75 100644 > --- a/debian.raspi/control.d/flavour-control.stub > +++ b/debian.raspi/control.d/flavour-control.stub > @@ -49,7 +49,7 @@ Build-Profiles: <!stage1> > Architecture: ARCH > Section: kernel > Priority: optional > -Depends: ${misc:Depends}, ${shlibs:Depends} > +Depends: ${misc:Depends}, ${shlibs:Depends}, crda > Built-Using: ${linux:BuiltUsing} > Description: Linux kernel extra modules for version PKGVER on DESC > Contains the corresponding System.map file, the modules built by the > -- > 2.20.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 23.06.20 11:01, Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1877415 > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- This needs more information in the commit itself. Looking at the bug report there is a comment from Brian about doing the dependency on the modules extra package which, looking at the context, you did. But nothing explains anything anywhere. Let alone no formal sru justification. -Stefan > debian.raspi/control.d/flavour-control.stub | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.raspi/control.d/flavour-control.stub b/debian.raspi/control.d/flavour-control.stub > index ce8b81a11f60..9f5d47e91d75 100644 > --- a/debian.raspi/control.d/flavour-control.stub > +++ b/debian.raspi/control.d/flavour-control.stub > @@ -49,7 +49,7 @@ Build-Profiles: <!stage1> > Architecture: ARCH > Section: kernel > Priority: optional > -Depends: ${misc:Depends}, ${shlibs:Depends} > +Depends: ${misc:Depends}, ${shlibs:Depends}, crda > Built-Using: ${linux:BuiltUsing} > Description: Linux kernel extra modules for version PKGVER on DESC > Contains the corresponding System.map file, the modules built by the >
> What about bionic that is also listed in the bug? Bionic will inherit this automatically when we switch over to the hwe kernel. ...Juerg > On Tue, Jun 23, 2020 at 11:01:18AM +0200, Juerg Haefliger wrote: > > BugLink: https://bugs.launchpad.net/bugs/1877415 > > > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > > --- > > debian.raspi/control.d/flavour-control.stub | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/debian.raspi/control.d/flavour-control.stub b/debian.raspi/control.d/flavour-control.stub > > index ce8b81a11f60..9f5d47e91d75 100644 > > --- a/debian.raspi/control.d/flavour-control.stub > > +++ b/debian.raspi/control.d/flavour-control.stub > > @@ -49,7 +49,7 @@ Build-Profiles: <!stage1> > > Architecture: ARCH > > Section: kernel > > Priority: optional > > -Depends: ${misc:Depends}, ${shlibs:Depends} > > +Depends: ${misc:Depends}, ${shlibs:Depends}, crda > > Built-Using: ${linux:BuiltUsing} > > Description: Linux kernel extra modules for version PKGVER on DESC > > Contains the corresponding System.map file, the modules built by the > > -- > > 2.20.1 > > > > > > -- > > kernel-team mailing list > > kernel-team@lists.ubuntu.com > > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
On Wed, 24 Jun 2020 09:08:02 +0200 Stefan Bader <stefan.bader@canonical.com> wrote: > On 23.06.20 11:01, Juerg Haefliger wrote: > > BugLink: https://bugs.launchpad.net/bugs/1877415 > > > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > > --- > > This needs more information in the commit itself. Looking at the bug report > there is a comment from Brian about doing the dependency on the modules extra > package which, looking at the context, you did. But nothing explains anything > anywhere. Let alone no formal sru justification. Fair enough. Will send a v2 and update the bug. ...Juerg > -Stefan > > debian.raspi/control.d/flavour-control.stub | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/debian.raspi/control.d/flavour-control.stub b/debian.raspi/control.d/flavour-control.stub > > index ce8b81a11f60..9f5d47e91d75 100644 > > --- a/debian.raspi/control.d/flavour-control.stub > > +++ b/debian.raspi/control.d/flavour-control.stub > > @@ -49,7 +49,7 @@ Build-Profiles: <!stage1> > > Architecture: ARCH > > Section: kernel > > Priority: optional > > -Depends: ${misc:Depends}, ${shlibs:Depends} > > +Depends: ${misc:Depends}, ${shlibs:Depends}, crda > > Built-Using: ${linux:BuiltUsing} > > Description: Linux kernel extra modules for version PKGVER on DESC > > Contains the corresponding System.map file, the modules built by the > > > >
diff --git a/debian.raspi/control.d/flavour-control.stub b/debian.raspi/control.d/flavour-control.stub index ce8b81a11f60..9f5d47e91d75 100644 --- a/debian.raspi/control.d/flavour-control.stub +++ b/debian.raspi/control.d/flavour-control.stub @@ -49,7 +49,7 @@ Build-Profiles: <!stage1> Architecture: ARCH Section: kernel Priority: optional -Depends: ${misc:Depends}, ${shlibs:Depends} +Depends: ${misc:Depends}, ${shlibs:Depends}, crda Built-Using: ${linux:BuiltUsing} Description: Linux kernel extra modules for version PKGVER on DESC Contains the corresponding System.map file, the modules built by the
BugLink: https://bugs.launchpad.net/bugs/1877415 Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- debian.raspi/control.d/flavour-control.stub | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)