From patchwork Fri Jun 19 16:49:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1313159 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49pPvQ5MrrzB4CJ; Sat, 20 Jun 2020 02:50:58 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jmKE7-00079r-KS; Fri, 19 Jun 2020 16:50:51 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmKDm-0006s8-C6 for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:50:30 +0000 Received: from mail-io1-f70.google.com ([209.85.166.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmKDl-0006Kb-93 for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:50:29 +0000 Received: by mail-io1-f70.google.com with SMTP id z12so7250332iow.15 for ; Fri, 19 Jun 2020 09:50:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BL5yL7oY/9Qnleyl5Itl0tw0Tibek5I6ZYbO8678NgE=; b=QyR2KUaW5Kgb9VugQ33dKokuc7/Hjo1+Et3y2OqR/c7bd+cxoHstodjnTKq2MdVTHT j08Ttkr3UdO8Oi2DNqv/Htxzk556oQJitDyvupUlOY6/O9ueE1aTAcDIxLsTTKn8QD54 J3ZkeSl14bjptK8w1kqw8jrhBSTrwA3Qkie0z9XJPTCIAnjCyRHhgufWLSBIYSh5V6Xv mbxBTHd965L5KBwWXUaNQZZLkEGBMBJSM/LScen5y5t7Aqt2Bvols7iXWpIBPjErq/rf ir29OZm1FfyvavBgA6VadFz3tdbF1rcqjLFZgcIXFrIjlGwnhPR7h+d2Xtii8yrTbWF/ gBlQ== X-Gm-Message-State: AOAM530OQ/DZ70Xqbg6QKsc1nIiSAl+VG8nNHqZkYuy2DKEurQ5cyXap lKgEhXQoLTkIN2mvIEzrQBoWnqvG+joxr/Z2JYOO2lz6v1p0AAIRTzctY/IW84ECARMtYM/w7fP oyWSMuFYOGeMaAxXCblfgW0G3jWC2I3w2dt537eggbQ== X-Received: by 2002:a5d:8f0b:: with SMTP id f11mr3065799iof.200.1592585428131; Fri, 19 Jun 2020 09:50:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt4WW51uE8X3VWcSamxiF3YuB7/Q2nTqQMtWWdjiUM+UzV3lxpsunIVJpz9Tbuz5cyVCoMfQ== X-Received: by 2002:a5d:8f0b:: with SMTP id f11mr3065779iof.200.1592585427819; Fri, 19 Jun 2020 09:50:27 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id j11sm3514092iof.25.2020.06.19.09.50.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 09:50:27 -0700 (PDT) From: Seth Forshee To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 13/57][X] Annotate hardware config module parameters in drivers/gpio/ Date: Fri, 19 Jun 2020 11:49:26 -0500 Message-Id: <20200619165010.645925-14-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619165010.645925-1-seth.forshee@canonical.com> References: <20200619165010.645925-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: David Howells BugLink: https://bugs.launchpad.net/bugs/1884159 When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/gpio/. Suggested-by: Alan Cox Signed-off-by: David Howells Acked-by: William Breathitt Gray Acked-by: Linus Walleij cc: Alexandre Courbot cc: linux-gpio@vger.kernel.org (backported from commit d759f906794b3b2894780870227c3c05895d83c1) Signed-off-by: Seth Forshee --- drivers/gpio/gpio-104-idio-16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c index 5400d7d4d8fd..f48f72e20f2e 100644 --- a/drivers/gpio/gpio-104-idio-16.c +++ b/drivers/gpio/gpio-104-idio-16.c @@ -23,7 +23,7 @@ #include static unsigned idio_16_base; -module_param(idio_16_base, uint, 0); +module_param_hw(idio_16_base, uint, ioport, 0); MODULE_PARM_DESC(idio_16_base, "ACCES 104-IDIO-16 base address"); /**