Message ID | 20200619161621.644540-48-seth.forshee@canonical.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49pPBS1q63zB47s; Sat, 20 Jun 2020 02:18:56 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1jmJj9-00043e-DA; Fri, 19 Jun 2020 16:18:51 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <seth.forshee@canonical.com>) id 1jmJhk-0002qK-QG for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:17:24 +0000 Received: from mail-io1-f70.google.com ([209.85.166.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <seth.forshee@canonical.com>) id 1jmJhj-0003jy-08 for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:17:23 +0000 Received: by mail-io1-f70.google.com with SMTP id t23so7139273iog.21 for <kernel-team@lists.ubuntu.com>; Fri, 19 Jun 2020 09:17:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cDiUWJmO/4e623ftdF6yZteuPUtF3hoQ9IbVPfDqVWY=; b=jv35orr7XNtLUTVW05jHk5we/Qemcgg+sgcEPorELuAL4iv94zoTH3Nv4tRhhQSivf 59iIe1NcIQVbUcdjm6LuYp0QKCbchgeQHU9w4Bzl1MVfGnuAL9ZQJVXPC7I0iBNdCfKk XmiBGMY+LXI5FDLd/bOKh77LKUZhEws49/tNm7t/AaIjpsFfKkJgk2rdwxpGJhG2Jqp5 +PzuSHoyZ/PMFplJRLFI0XBtyyXREXLT+qftB9POjrl6Pov/v54z5FF6URvRZHKAhpRM CjHCjx9I2IBAiKKUBYbFTkqVWaaJg2LOyrWckfGNMHZYpf6qBCHjcNvbrL9WGzL+Cekr v5ew== X-Gm-Message-State: AOAM533BfdIZUXUG975mRems+gPpJUJRJ77aVcT4sRkq9vJnfyU3eV+r 0o+xjI3epTagTYtAGWwoTt27iPP3hdcImvYo+fNLORzLCG66hWBHo7WF+YHhCmZD53azy07eAk+ uPLEV3xbkyjuHF7SVu5toZAR4RNQBquS2jc3zC08pnA== X-Received: by 2002:a92:5fcd:: with SMTP id i74mr4299662ill.169.1592583441882; Fri, 19 Jun 2020 09:17:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrxW7OzltWsHR0Z/DyW9K7DVfiPP9AJkEvHDK+F8mwRUDI0SCM4SEUNFy94hX/LiZxdFpwQw== X-Received: by 2002:a92:5fcd:: with SMTP id i74mr4299641ill.169.1592583441640; Fri, 19 Jun 2020 09:17:21 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id n17sm3384032iom.22.2020.06.19.09.17.21 for <kernel-team@lists.ubuntu.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 09:17:21 -0700 (PDT) From: Seth Forshee <seth.forshee@canonical.com> To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 47/57][B] efi/efi_test: Lock down /dev/efi_test and require CAP_SYS_ADMIN Date: Fri, 19 Jun 2020 11:16:11 -0500 Message-Id: <20200619161621.644540-48-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619161621.644540-1-seth.forshee@canonical.com> References: <20200619161621.644540-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
Lockdown updates
|
expand
|
diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c index f61bb52be318..3dc55ac0af73 100644 --- a/drivers/firmware/efi/test/efi_test.c +++ b/drivers/firmware/efi/test/efi_test.c @@ -696,6 +696,13 @@ static long efi_test_ioctl(struct file *file, unsigned int cmd, static int efi_test_open(struct inode *inode, struct file *file) { + bool locked_down = secure_modules(); + + if (locked_down) + return -EPERM; + + if (!capable(CAP_SYS_ADMIN)) + return -EACCES; /* * nothing special to do here * We do accept multiple open files at the same time as we