From patchwork Fri Jun 19 16:15:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1313075 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49pP8R3vwkzB471; Sat, 20 Jun 2020 02:17:11 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jmJhR-0002Zp-Ca; Fri, 19 Jun 2020 16:17:05 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmJh3-0002Eq-Ff for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:16:41 +0000 Received: from mail-io1-f70.google.com ([209.85.166.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmJh2-0003aW-KJ for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:16:40 +0000 Received: by mail-io1-f70.google.com with SMTP id l22so7087833iob.23 for ; Fri, 19 Jun 2020 09:16:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2LUEeHhPc0QLdUDAtM7h+fXX/Xde04MwmYmNnrJbCSs=; b=sba5TebKgHh8RglfZyBVOvPRNOoi2LJPnx6LNXuG9zWuQT5tkdRlyFeyNrzw6XfpoA gMZR0DAqZZIHU+WmA14lr1iILSMdDTNC8aNJTYSr+8RfRWgvXkhPhk9l/f39LLOV0XVL GxkhK2HVUsWHYj8V52uMnO1Qj6YCE3mcWfCvC4zH2vWR6vZCgfwzbPYnDGvDVH5FD6DV O85QtKqcEK2TPndXqcoxers1/ckWAUeXdbusNXvwoyqMbF+nEoS1jpelzfP/ZvSMhwge hSl1WaFLDVIFw4hZ+ZZaTevPZwWSRgSl8I1j1X2oVJ7bNs5brBDcMsOkdA4L6fM/1s/L XE2Q== X-Gm-Message-State: AOAM532kgXlziRs4jxFiDJMd44+5VDXPpiIASXuLzWs6jHtu7TaImzBc 4hS6QNg5if+THLbzwukqb8Idl/haPA+deyeF1SyWSgFDe0+1kk6wfv3pNdQnhlTdlqWhCmEkBfs k5xCyCuzN7xFsRKlNXadB6RD5iySA7AiN5KYOrpUlYA== X-Received: by 2002:a05:6602:1601:: with SMTP id x1mr5249301iow.129.1592583399214; Fri, 19 Jun 2020 09:16:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsG9i/hgEh23/X/PSwJ+MUpqvXza0Nn9tDpxvH6nzFzIns/xUaj4sEG8BL6tmQ+Yi0TXWOLA== X-Received: by 2002:a05:6602:1601:: with SMTP id x1mr5249214iow.129.1592583398231; Fri, 19 Jun 2020 09:16:38 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id y2sm3341786ilg.69.2020.06.19.09.16.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 09:16:37 -0700 (PDT) From: Seth Forshee To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 12/57][B] Annotate hardware config module parameters in drivers/cpufreq/ Date: Fri, 19 Jun 2020 11:15:36 -0500 Message-Id: <20200619161621.644540-13-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619161621.644540-1-seth.forshee@canonical.com> References: <20200619161621.644540-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: David Howells BugLink: https://bugs.launchpad.net/bugs/1884159 When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/cpufreq/. Suggested-by: Alan Cox Signed-off-by: David Howells Acked-by: "Rafael J. Wysocki" Acked-by: Viresh Kumar cc: linux-pm@vger.kernel.org (cherry picked from commit 40059ec6701bd10d7d972ed302cca61cf8b6f2cf) Signed-off-by: Seth Forshee --- drivers/cpufreq/speedstep-smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c index 819229e824fb..b5691317b6dd 100644 --- a/drivers/cpufreq/speedstep-smi.c +++ b/drivers/cpufreq/speedstep-smi.c @@ -377,7 +377,7 @@ static void __exit speedstep_exit(void) cpufreq_unregister_driver(&speedstep_driver); } -module_param(smi_port, int, 0444); +module_param_hw(smi_port, int, ioport, 0444); module_param(smi_cmd, int, 0444); module_param(smi_sig, uint, 0444);