From patchwork Tue Jun 2 07:43:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1302139 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49bkbQ6bCGz9sSd; Tue, 2 Jun 2020 17:45:06 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jg1bX-0002Pe-Sp; Tue, 02 Jun 2020 07:44:59 +0000 Received: from mail-pl1-f193.google.com ([209.85.214.193]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jg1bM-0002JG-Lv for kernel-team@lists.ubuntu.com; Tue, 02 Jun 2020 07:44:48 +0000 Received: by mail-pl1-f193.google.com with SMTP id y18so1022128plr.4 for ; Tue, 02 Jun 2020 00:44:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZEhWrf9sq98r/QzJM+JvDcWTO1k4M1D7QM5cIWVWvd8=; b=SEtgHARFlUv55gMy2VnGC34K/AdXTdISxBYJrSiZcwN2VPPB2XQWNdCRD2rmKXiIY7 sg0Xxz/fILRcPNEGVLZ1R0949xk9GlmLsTK5bpBRO71P8BM5z4hbhwtUNBChrXLrUqRi Xvdqc7Wqf4dF38Zq4badBHULb4Gv5Adp3Qu9Gc1Ue8jy3SupJ7GKlwQ/npv/OyeOOz9Z Z+QS2zoBSq6oCywEpuFQDY0uAn9NLGxCNaoGlLcjuGQTV3wt3CLYtFrufutba5v+9BCb BTpR8f5+GvTz4aZqYPQBsz9EIPCHNur18GMbQFB/uSbNOBM7ArF10FxhVNOGu+CiqVze ob8w== X-Gm-Message-State: AOAM533JxuDrSmjx/9cK88BuAI8eXz0xI0FcNcDZGa1PJk+IX3Q9FKQl 7yrlM3+QImHIatlB/Y7Yiwv03+RjYYc= X-Google-Smtp-Source: ABdhPJxRtam1ZKZxnjRb2N2ZntRYz/DDc1qGEVar9gDHVQNXvrA6lW30JPi+213trxV+QFuA2wPR9g== X-Received: by 2002:a17:90a:e00a:: with SMTP id u10mr3949217pjy.17.1591083885802; Tue, 02 Jun 2020 00:44:45 -0700 (PDT) Received: from localhost (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id w124sm1459174pfc.213.2020.06.02.00.44.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 00:44:45 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 08/60][SRU][OEM-5.6] iommu/arm-smmu: Fix uninitilized variable warning Date: Tue, 2 Jun 2020 15:43:29 +0800 Message-Id: <20200602074421.1742802-9-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200602074421.1742802-1-vicamo.yang@canonical.com> References: <20200602074421.1742802-1-vicamo.yang@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Joerg Roedel BugLink: https://bugs.launchpad.net/bugs/1876707 Some unrelated changes in the iommu code caused a new warning to appear in the arm-smmu driver: CC drivers/iommu/arm-smmu.o drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device': drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized] arm_smmu_rpm_put(smmu); ^~~~~~~~~~~~~~~~~~~~~~ The warning is a false positive, but initialize the variable to NULL to get rid of it. Signed-off-by: Joerg Roedel Tested-by: Will Deacon # arm-smmu Reviewed-by: Jean-Philippe Brucker Link: https://lore.kernel.org/r/20200326150841.10083-8-joro@8bytes.org (cherry picked from commit 0b242ebbb7fca818323d02d2bbb08ff7d425f594) Signed-off-by: You-Sheng Yang --- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 16c4b87af42b..980aae73b45b 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode) static int arm_smmu_add_device(struct device *dev) { - struct arm_smmu_device *smmu; + struct arm_smmu_device *smmu = NULL; struct arm_smmu_master_cfg *cfg; struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); int i, ret;