| Message ID | 20200225161626.59060-2-paolo.pisati@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | F/master: kselftests/timers: disable timeout | expand |
I think this is the same patch that was ACK'd from Sam on 2/21/2020 ? ACK: [B][D][E][F][SRU][PATCH 0/1] Turn off timeout setting for ftrace test in kselftests -Sean On 2/25/20 11:16 AM, Paolo Pisati wrote: > From: Po-Hsu Lin <po-hsu.lin@canonical.com> > > Tests in timers especially nsleep-lat, set-timer-lat, > inconsistency-check and raw_skew these 4 tests can take longer than > the default 45 seconds that introduced in commit 852c8cbf > (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run. > > Disable the timeout setting for timers instead of looking for an proper > value to make it more general. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> > --- > tools/testing/selftests/timers/settings | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tools/testing/selftests/timers/settings > > diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings > new file mode 100644 > index 000000000000..e7b9417537fb > --- /dev/null > +++ b/tools/testing/selftests/timers/settings > @@ -0,0 +1 @@ > +timeout=0
On Tue, Feb 25, 2020 at 11:29:56AM -0500, Sean Feole wrote: > I think this is the same patch that was ACK'd from Sam on 2/21/2020 ? > > ACK: [B][D][E][F][SRU][PATCH 0/1] Turn off timeout setting for ftrace test > in kselftests Same rationale, but that one applies to tools/testing/selftests/ftrace/settings: https://lists.ubuntu.com/archives/kernel-team/2020-February/107693.html while this one is for tools/testing/selftests/timers/settings
Hi Paolo, (you're really fast, the patch was just out from my inbox not for long) I have sent out patch V2 [1], hope upstream will take it (well, v1 works anyway) And if you need a bug link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1864626 Also to note that powerpc test is facing the same issue, and should be fixed in upstream: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1864642 Please feel free to take over. Thanks Sam [1] https://lists.linaro.org/pipermail/linux-kselftest-mirror/2020-February/011044.html On Wed, Feb 26, 2020 at 12:56 AM Paolo Pisati <paolo.pisati@canonical.com> wrote: > > On Tue, Feb 25, 2020 at 11:29:56AM -0500, Sean Feole wrote: > > I think this is the same patch that was ACK'd from Sam on 2/21/2020 ? > > > > ACK: [B][D][E][F][SRU][PATCH 0/1] Turn off timeout setting for ftrace test > > in kselftests > > Same rationale, but that one applies to tools/testing/selftests/ftrace/settings: > > https://lists.ubuntu.com/archives/kernel-team/2020-February/107693.html > > while this one is for tools/testing/selftests/timers/settings > -- > bye, > p. > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Tue, Feb 25, 2020 at 05:16:26PM +0100, Paolo Pisati wrote: > From: Po-Hsu Lin <po-hsu.lin@canonical.com> > > Tests in timers especially nsleep-lat, set-timer-lat, > inconsistency-check and raw_skew these 4 tests can take longer than > the default 45 seconds that introduced in commit 852c8cbf > (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run. > > Disable the timeout setting for timers instead of looking for an proper > value to make it more general. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> This patch is missing the makefile changes from [1]. Are they not needed for some reason? [1] https://lists.linaro.org/pipermail/linux-kselftest-mirror/2020-February/011044.html
On Tue, Feb 25, 2020 at 04:29:08PM -0600, Seth Forshee wrote: > This patch is missing the makefile changes from [1]. Are they not needed > for some reason? > > [1] https://lists.linaro.org/pipermail/linux-kselftest-mirror/2020-February/011044.html That's a V2, i'll NAK this and send the other.
On Tue, Feb 25, 2020 at 05:16:26PM +0100, Paolo Pisati wrote: > From: Po-Hsu Lin <po-hsu.lin@canonical.com> > > Tests in timers especially nsleep-lat, set-timer-lat, > inconsistency-check and raw_skew these 4 tests can take longer than > the default 45 seconds that introduced in commit 852c8cbf > (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run. > > Disable the timeout setting for timers instead of looking for an proper > value to make it more general. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings new file mode 100644 index 000000000000..e7b9417537fb --- /dev/null +++ b/tools/testing/selftests/timers/settings @@ -0,0 +1 @@ +timeout=0