mbox series

[PULL,SRU,OEM-OSP1-B] enable realtek ethernet EEE function

Message ID 20200103032909.29896-1-acelan.kao@canonical.com
State New
Headers show
Series [PULL,SRU,OEM-OSP1-B] enable realtek ethernet EEE function | expand

Pull-request

git://git.launchpad.net/~acelankao/+git/ubuntu-disco r8169-eee

Message

AceLan Kao Jan. 3, 2020, 3:29 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1858159

[Impact]
Energy Start 8 requires EEE(Energy Efficient Ethernet) feature, so we
need to backport this from v5.1 kernel.

[Fix]
This feature is already in v5.1 mainline kernel, just backport some
commits to enable it.

[Test]
Verified on the target machine, and confirm "ethtool --show-eee" shows
this feature is enabled

[Regression Potential]
Medium. It's hard to evaluate the impact since the code changes a lot.
Only one commit is backported, and others are clear cherry picked,
so the quality of the code should be good enough.

The following changes since commit e1d9d9976bc32df35415b59a1bd34ee487892ce5:

  UBUNTU: Ubuntu-oem-osp1-5.0.0-1033.38 (2019-12-16 16:07:10 +0200)

are available in the Git repository at:

  git://git.launchpad.net/~acelankao/+git/ubuntu-disco r8169-eee

for you to fetch changes up to c6dbe600a3030eecd9b429d416232611af615ddb:

  r8169: enable EEE per default on RTL8168f (2020-01-03 11:10:02 +0800)

----------------------------------------------------------------
Heiner Kallweit (17):
      r8169: remove rtl_get_events
      r8169: remove unneeded call in pcierr
      r8169: initialize task workqueue only once
      r8169: improve rtl_pcie_state_l2l3_enable
      r8169: add helpers for locking / unlocking the config registers
      r8169: reset chip synchronously in __rtl8169_resume
      r8169: replace mii_bus member with phy_device member in struct rtl8169_private
      r8169: factor out getting ether_clk
      r8169: improve rx buffer allocation
      r8169: remove PCI DAC support
      r8169: improve firmware handling
      r8169: factor out disabling ALDPS
      r8169: factor out PHY init sequence adjusting 10M and ALDPS
      r8169: add general EEE support for chip versions from RTL8168g
      r8169: enable EEE per default on chip versions from RTL8168g
      r8169: add EEE support for RTL8168f
      r8169: enable EEE per default on RTL8168f

 drivers/net/ethernet/realtek/r8169.c | 647 +++++++++++++++++++++--------------
 1 file changed, 396 insertions(+), 251 deletions(-)

Comments

Timo Aaltonen Jan. 9, 2020, 10:44 a.m. UTC | #1
On 3.1.2020 5.29, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1858159
> 
> [Impact]
> Energy Start 8 requires EEE(Energy Efficient Ethernet) feature, so we
> need to backport this from v5.1 kernel.
> 
> [Fix]
> This feature is already in v5.1 mainline kernel, just backport some
> commits to enable it.
> 
> [Test]
> Verified on the target machine, and confirm "ethtool --show-eee" shows
> this feature is enabled
> 
> [Regression Potential]
> Medium. It's hard to evaluate the impact since the code changes a lot.
> Only one commit is backported, and others are clear cherry picked,
> so the quality of the code should be good enough.
> 
> The following changes since commit e1d9d9976bc32df35415b59a1bd34ee487892ce5:
> 
>   UBUNTU: Ubuntu-oem-osp1-5.0.0-1033.38 (2019-12-16 16:07:10 +0200)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~acelankao/+git/ubuntu-disco r8169-eee
> 
> for you to fetch changes up to c6dbe600a3030eecd9b429d416232611af615ddb:
> 
>   r8169: enable EEE per default on RTL8168f (2020-01-03 11:10:02 +0800)
> 
> ----------------------------------------------------------------
> Heiner Kallweit (17):
>       r8169: remove rtl_get_events
>       r8169: remove unneeded call in pcierr
>       r8169: initialize task workqueue only once
>       r8169: improve rtl_pcie_state_l2l3_enable
>       r8169: add helpers for locking / unlocking the config registers
>       r8169: reset chip synchronously in __rtl8169_resume
>       r8169: replace mii_bus member with phy_device member in struct rtl8169_private
>       r8169: factor out getting ether_clk
>       r8169: improve rx buffer allocation
>       r8169: remove PCI DAC support
>       r8169: improve firmware handling
>       r8169: factor out disabling ALDPS
>       r8169: factor out PHY init sequence adjusting 10M and ALDPS
>       r8169: add general EEE support for chip versions from RTL8168g
>       r8169: enable EEE per default on chip versions from RTL8168g
>       r8169: add EEE support for RTL8168f
>       r8169: enable EEE per default on RTL8168f
> 
>  drivers/net/ethernet/realtek/r8169.c | 647 +++++++++++++++++++++--------------
>  1 file changed, 396 insertions(+), 251 deletions(-)
> 

applied to osp1 oem-next, thanks