diff mbox series

[SRU,Eoan/master] UBUNTU: [Config] FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER=y

Message ID 20191121122520.10711-1-paolo.pisati@canonical.com
State New
Headers show
Series [SRU,Eoan/master] UBUNTU: [Config] FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER=y | expand

Commit Message

Paolo Pisati Nov. 21, 2019, 12:25 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1836858

Impact:

Flickerfree boot doesn't work with Eoan and Focal kernels - the flicker
occurs seemingly during kernel startup following this pattern:

1. BIOS logo on a black background
2. Display mode resets, no image on a black background briefly
3. BIOS logo on a black background

According to upstream, the required kernel option to achieve it (coupled
with the quiet cmdline) is FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER.

Fix:

Apply the config change, recompile and reboot - a test kernel was
provided and the reporter of this bug said "it doesn't completely
solve the issue, but it's a step in the right direction, so please
enable it".

Regression potential:

Low, config change for an option that is upstream.

Proposing for Eoan and Focal.

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.master/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Bader Nov. 28, 2019, 3:19 p.m. UTC | #1
On 21.11.19 13:25, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836858
> 
> Impact:
> 
> Flickerfree boot doesn't work with Eoan and Focal kernels - the flicker
> occurs seemingly during kernel startup following this pattern:
> 
> 1. BIOS logo on a black background
> 2. Display mode resets, no image on a black background briefly
> 3. BIOS logo on a black background
> 
> According to upstream, the required kernel option to achieve it (coupled
> with the quiet cmdline) is FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER.
> 
> Fix:
> 
> Apply the config change, recompile and reboot - a test kernel was
> provided and the reporter of this bug said "it doesn't completely
> solve the issue, but it's a step in the right direction, so please
> enable it".
> 
> Regression potential:
> 
> Low, config change for an option that is upstream.
> 
> Proposing for Eoan and Focal.
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian.master/config/config.common.ubuntu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 5c54854e3e99..ff0ccc7af000 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3309,7 +3309,7 @@ CONFIG_FPGA_MGR_XILINX_SPI=m
>  CONFIG_FPGA_MGR_ZYNQMP_FPGA=m
>  CONFIG_FPGA_REGION=m
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> -# CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER is not set
> +CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER=y
>  CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y
>  CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
>  CONFIG_FRAME_POINTER=y
>
Kleber Sacilotto de Souza Dec. 2, 2019, 1:24 p.m. UTC | #2
On 2019-11-21 13:25, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836858
> 
> Impact:
> 
> Flickerfree boot doesn't work with Eoan and Focal kernels - the flicker
> occurs seemingly during kernel startup following this pattern:
> 
> 1. BIOS logo on a black background
> 2. Display mode resets, no image on a black background briefly
> 3. BIOS logo on a black background
> 
> According to upstream, the required kernel option to achieve it (coupled
> with the quiet cmdline) is FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER.
> 
> Fix:
> 
> Apply the config change, recompile and reboot - a test kernel was
> provided and the reporter of this bug said "it doesn't completely
> solve the issue, but it's a step in the right direction, so please
> enable it".
> 
> Regression potential:
> 
> Low, config change for an option that is upstream.
> 
> Proposing for Eoan and Focal.
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  debian.master/config/config.common.ubuntu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 5c54854e3e99..ff0ccc7af000 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3309,7 +3309,7 @@ CONFIG_FPGA_MGR_XILINX_SPI=m
>  CONFIG_FPGA_MGR_ZYNQMP_FPGA=m
>  CONFIG_FPGA_REGION=m
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> -# CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER is not set
> +CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER=y
>  CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y
>  CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
>  CONFIG_FRAME_POINTER=y
>
Kleber Sacilotto de Souza Dec. 2, 2019, 1:25 p.m. UTC | #3
On 2019-11-21 13:25, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836858
> 
> Impact:
> 
> Flickerfree boot doesn't work with Eoan and Focal kernels - the flicker
> occurs seemingly during kernel startup following this pattern:
> 
> 1. BIOS logo on a black background
> 2. Display mode resets, no image on a black background briefly
> 3. BIOS logo on a black background
> 
> According to upstream, the required kernel option to achieve it (coupled
> with the quiet cmdline) is FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER.
> 
> Fix:
> 
> Apply the config change, recompile and reboot - a test kernel was
> provided and the reporter of this bug said "it doesn't completely
> solve the issue, but it's a step in the right direction, so please
> enable it".
> 
> Regression potential:
> 
> Low, config change for an option that is upstream.
> 
> Proposing for Eoan and Focal.
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.master/config/config.common.ubuntu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 5c54854e3e99..ff0ccc7af000 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3309,7 +3309,7 @@ CONFIG_FPGA_MGR_XILINX_SPI=m
>  CONFIG_FPGA_MGR_ZYNQMP_FPGA=m
>  CONFIG_FPGA_REGION=m
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> -# CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER is not set
> +CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER=y
>  CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y
>  CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
>  CONFIG_FRAME_POINTER=y
> 

Applied to eoan/master-next branch.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 5c54854e3e99..ff0ccc7af000 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -3309,7 +3309,7 @@  CONFIG_FPGA_MGR_XILINX_SPI=m
 CONFIG_FPGA_MGR_ZYNQMP_FPGA=m
 CONFIG_FPGA_REGION=m
 CONFIG_FRAMEBUFFER_CONSOLE=y
-# CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER is not set
+CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER=y
 CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y
 CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
 CONFIG_FRAME_POINTER=y