From patchwork Thu Aug 22 13:20:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauricio Faria de Oliveira X-Patchwork-Id: 1151599 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46DlXR4lpxz9sNk; Thu, 22 Aug 2019 23:20:55 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1i0n1I-0005Gn-0f; Thu, 22 Aug 2019 13:20:52 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1i0n1F-0005G7-Sm for kernel-team@lists.ubuntu.com; Thu, 22 Aug 2019 13:20:49 +0000 Received: from mail-qk1-f197.google.com ([209.85.222.197]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1i0n1F-0007C7-Gr for kernel-team@lists.ubuntu.com; Thu, 22 Aug 2019 13:20:49 +0000 Received: by mail-qk1-f197.google.com with SMTP id b13so5743570qkk.20 for ; Thu, 22 Aug 2019 06:20:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=eDih0JL2ninMTF8pB0ib9vZzoiRtTJxQ4Q9tLfD2RWg=; b=rmMhPD1ltEFEKlvIV8Uu4lsePHhYKUYenotdCgPtOMl/MAWVUYA5BRFoI0855ulRbG K8bEbQKSkkT5Jkv1DZWQUTPGvEcv8+DSmgI8xybadHnwLCXs0PgZI6wnAgEUFKlAj8Ts eG8As+FKZMiCewCDyLB2wvdi8iF3gxFYccFVh6swAXEy492G3Zvo7T9hn/3XMgp3Gfu5 UN31O03PP/oq+s4PiasXy1SYg7qdt2o8ZHejlEGTKpsbVcwCJi0OWeAvXwLglzcG/x5Z EeYHNB8/voVw/E3MWUHYJu+12jGSeJYDrtOfwVNJERE68rSR0FjfUYLT6t1LLX6Zf95H 0kRg== X-Gm-Message-State: APjAAAUG4gBESDaHGhnVXaUD1f8M+JIKRF8F/4K0IMW0niLKTLu+Ba8t hFD+KcwwuKS5ftrMt6gfYL7ur9mjcgCG+WPhC/DCWtbnA5/yfTMxAaqyynaA+8oDfWZRHf0Isji g6pb7xRnyDUyDcJWJ/ompZ6H2CZyDrLk2BzQyfdHgVQ== X-Received: by 2002:a37:6555:: with SMTP id z82mr35181825qkb.319.1566480048522; Thu, 22 Aug 2019 06:20:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxK7h/T1mhhkjDPWHku+/g5d8Abn5vbXfZOgZsV5fKoI5WxX6ec5dGUW6hQHL5FhMh8c9F1RA== X-Received: by 2002:a37:6555:: with SMTP id z82mr35181808qkb.319.1566480048360; Thu, 22 Aug 2019 06:20:48 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:4e7:1017:a993:97d5:bc07:a234]) by smtp.gmail.com with ESMTPSA id p32sm12894483qtb.67.2019.08.22.06.20.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 06:20:47 -0700 (PDT) From: Mauricio Faria de Oliveira To: kernel-team@lists.ubuntu.com Subject: [D][PATCH] bnx2x: Disable multi-cos feature. Date: Thu, 22 Aug 2019 10:20:04 -0300 Message-Id: <20190822132004.31220-1-mfo@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Sudarsana Reddy Kalluru BugLink: https://bugs.launchpad.net/bugs/1840789 Commit 3968d38917eb ("bnx2x: Fix Multi-Cos.") which enabled multi-cos feature after prolonged time in driver added some regression causing numerous issues (sudden reboots, tx timeout etc.) reported by customers. We plan to backout this commit and submit proper fix once we have root cause of issues reported with this feature enabled. Fixes: 3968d38917eb ("bnx2x: Fix Multi-Cos.") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Manish Chopra Signed-off-by: David S. Miller (backported from commit d1f0b5dce8fda09a7f5f04c1878f181d548e42f5) [mfo: backport: essentially revert the mentioned commit; upstream more recently removed the fallback() function and moved to netdev_pick_tx(), the parentheses are left in as done in this commit.] Signed-off-by: Mauricio Faria de Oliveira Acked-by: Stefan Bader --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 78a01880931c..9c5b932c61dd 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -1932,8 +1932,7 @@ u16 bnx2x_select_queue(struct net_device *dev, struct sk_buff *skb, } /* select a non-FCoE queue */ - return fallback(dev, skb, NULL) % - (BNX2X_NUM_ETH_QUEUES(bp) * bp->max_cos); + return fallback(dev, skb, NULL) % (BNX2X_NUM_ETH_QUEUES(bp)); } void bnx2x_set_num_queues(struct bnx2x *bp)