From patchwork Tue May 14 09:00:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1099360 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 453BW22DWkz9sNk; Tue, 14 May 2019 19:01:18 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hQTJC-0006Pb-JC; Tue, 14 May 2019 09:01:14 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hQTJ8-0006Nd-Lw for kernel-team@lists.ubuntu.com; Tue, 14 May 2019 09:01:10 +0000 Received: from mail-pg1-f200.google.com ([209.85.215.200]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hQTJ7-00077m-UY for kernel-team@lists.ubuntu.com; Tue, 14 May 2019 09:01:10 +0000 Received: by mail-pg1-f200.google.com with SMTP id m35so11111442pgl.6 for ; Tue, 14 May 2019 02:01:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=JyvjBjtklMKv/jXrQ0Js4aUpnE9AtJRrcuRYXPO6EBE=; b=feLQKc5+v1pZVd150hLmQ9ERDGA38ScYWwdPDQ2CGJRNGpICeNcjQEZJsQIFtg5fwZ zGyaFnKsPxEk251AFP7OXF2dKrELDflTiWmBVN3z3wZ0bttVAw2DdbqWr/gqA0W0Z1/u 7SsDRanH8OsY2ctH+Z6dBnc8TyyF6moX4ogMZ7JGUI7JDGAJFgZg65aSnhmqnaXVkU+c 7p4c16D8FkODOjz+S8XpiCD0WkXo0o7KgA+siu4/+1h/G2eaOTi0w01nrFpjt7B3UngP ar1Yno7lLfODfsF2Zi7SLQE58Xg7EVl+NPVwrWgAJgauqIl/4+vFIRDJvFfjVkjyWGP2 Z1IQ== X-Gm-Message-State: APjAAAX4v0bNRVmgYiTdO0YZ+wa4k5YuBXeWpXp5jdvUr12sBYrx2B7l z6zeThsdFodrROQTC4kx+VT7RmpwTrtRsvqv6xiB0GJj1KEYi1jxXanX6NtgcaTNqLd137Y3oQU qGJ8mZ8nG52Jfu2efOdb2voL8y+Ap3gJLcKes7lNA X-Received: by 2002:a63:1061:: with SMTP id 33mr10726675pgq.328.1557824468113; Tue, 14 May 2019 02:01:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOwqwN8GnBVVQVQVgDuLUVMcWldez6VuRK65Y/qCWR8qkaKc1HogfbEkJnk2zrBU/ZJxNc4Q== X-Received: by 2002:a63:1061:: with SMTP id 33mr10726605pgq.328.1557824467326; Tue, 14 May 2019 02:01:07 -0700 (PDT) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id r9sm24929639pfc.173.2019.05.14.02.01.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 02:01:06 -0700 (PDT) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [C][SRU][PATCH 1/1] selftests/powerpc: Remove Power9 copy_unaligned test Date: Tue, 14 May 2019 17:00:59 +0800 Message-Id: <20190514090100.5795-2-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190514090100.5795-1-po-hsu.lin@canonical.com> References: <20190514090100.5795-1-po-hsu.lin@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Michael Ellerman BugLink: https://bugs.launchpad.net/bugs/1813118 This is a test of the ISA 3.0 "copy" instruction. That instruction has an L field, which if set to 1 specifies that "the instruction identifies the beginning of a move group" (pp 858). That's also referred to as "copy first" vs "copy". In ISA 3.0B the copy instruction does not have an L field, and the corresponding bit in the instruction must be set to 1. This test is generating a "copy" instruction, not a "copy first", and so on Power9 (which implements 3.0B), this results in an illegal instruction. So just drop the test entirely. We still have copy_first_unaligned to test the "copy first" behaviour. Signed-off-by: Michael Ellerman Acked-by: Michael Neuling Signed-off-by: Michael Ellerman (cherry picked from commit 83039f22ba2f6aff935a2acbb6bf671374e8317d) Signed-off-by: Po-Hsu Lin --- .../testing/selftests/powerpc/alignment/.gitignore | 1 - tools/testing/selftests/powerpc/alignment/Makefile | 2 +- .../selftests/powerpc/alignment/copy_unaligned.c | 41 ---------------------- 3 files changed, 1 insertion(+), 43 deletions(-) delete mode 100644 tools/testing/selftests/powerpc/alignment/copy_unaligned.c diff --git a/tools/testing/selftests/powerpc/alignment/.gitignore b/tools/testing/selftests/powerpc/alignment/.gitignore index 9d38307..78ac678b 100644 --- a/tools/testing/selftests/powerpc/alignment/.gitignore +++ b/tools/testing/selftests/powerpc/alignment/.gitignore @@ -1,4 +1,3 @@ -copy_unaligned copy_first_unaligned paste_unaligned paste_last_unaligned diff --git a/tools/testing/selftests/powerpc/alignment/Makefile b/tools/testing/selftests/powerpc/alignment/Makefile index c3d5129..35349ef 100644 --- a/tools/testing/selftests/powerpc/alignment/Makefile +++ b/tools/testing/selftests/powerpc/alignment/Makefile @@ -1,4 +1,4 @@ -TEST_GEN_PROGS := copy_unaligned copy_first_unaligned paste_unaligned \ +TEST_GEN_PROGS := copy_first_unaligned paste_unaligned \ paste_last_unaligned alignment_handler top_srcdir = ../../../../.. diff --git a/tools/testing/selftests/powerpc/alignment/copy_unaligned.c b/tools/testing/selftests/powerpc/alignment/copy_unaligned.c deleted file mode 100644 index 3a4e264..0000000 --- a/tools/testing/selftests/powerpc/alignment/copy_unaligned.c +++ /dev/null @@ -1,41 +0,0 @@ -/* - * Copyright 2016, Chris Smart, IBM Corporation. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; either version - * 2 of the License, or (at your option) any later version. - * - * Calls to copy which are not 128-byte aligned should be caught - * and sent a SIGBUS. - * - */ - -#include -#include -#include "utils.h" -#include "instructions.h" -#include "copy_paste_unaligned_common.h" - -unsigned int expected_instruction = PPC_INST_COPY; -unsigned int instruction_mask = 0xfc0007fe; - -int test_copy_unaligned(void) -{ - /* Only run this test on a P9 or later */ - SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_00)); - - /* Register our signal handler with SIGBUS */ - setup_signal_handler(); - - /* +1 makes buf unaligned */ - copy(cacheline_buf+1); - - /* We should not get here */ - return 1; -} - -int main(int argc, char *argv[]) -{ - return test_harness(test_copy_unaligned, "test_copy_unaligned"); -}