diff mbox series

UBUNTU: [Packaging] fix a mistype

Message ID 20190301134344.22859-2-ignat.loskutov@gmail.com
State New
Headers show
Series UBUNTU: [Packaging] fix a mistype | expand

Commit Message

Ignat Loskutov March 1, 2019, 1:43 p.m. UTC 
HAVE_CPLUS_DEMANGLE_SUPPORT=1 used to be spelled incorrectly, leading to
missing C++ demangling support in perf.
---
 debian/rules.d/2-binary-arch.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee March 7, 2019, 2:59 p.m. UTC | #1 
On Fri, Mar 01, 2019 at 04:43:45PM +0300, Ignat Loskutov wrote:
> HAVE_CPLUS_DEMANGLE_SUPPORT=1 used to be spelled incorrectly, leading to
> missing C++ demangling support in perf.

Thanks for the patch! We do require a Signed-off-by line for patches
though. Please reply with your sign off and we can add it to the patch
when applying. Thanks!

Seth
Ignat Loskutov March 7, 2019, 8:21 p.m. UTC | #2 
On Thu, Mar 7, 2019 at 5:59 PM Seth Forshee <seth.forshee@canonical.com> wrote:
>
> On Fri, Mar 01, 2019 at 04:43:45PM +0300, Ignat Loskutov wrote:
> > HAVE_CPLUS_DEMANGLE_SUPPORT=1 used to be spelled incorrectly, leading to
> > missing C++ demangling support in perf.
>
> Thanks for the patch! We do require a Signed-off-by line for patches
> though. Please reply with your sign off and we can add it to the patch
> when applying. Thanks!
>
> Seth

Signed-off-by: Ignat Loskutov <ignat.loskutov@gmail.com>


--
Best regards,
Ignat Loskutov
diff mbox series

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index f2c3868c696e..c82fb1be0b39 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -647,7 +647,7 @@  ifeq ($(do_tools_perf),true)
 	cd $(builddirpa) && $(kmake) syncconfig
 	cd $(builddirpa) && $(kmake) prepare
 	cd $(builddirpa)/tools/perf && \
-		$(kmake) prefix=/usr HAVE_NO_LIBBFD=1 HAVE_CPUS_DEMANGLE_SUPPORT=1 CROSS_COMPILE=$(CROSS_COMPILE) NO_LIBPYTHON=1 NO_LIBPERL=1 PYTHON=python2.7
+		$(kmake) prefix=/usr HAVE_NO_LIBBFD=1 HAVE_CPLUS_DEMANGLE_SUPPORT=1 CROSS_COMPILE=$(CROSS_COMPILE) NO_LIBPYTHON=1 NO_LIBPERL=1 PYTHON=python2.7
 endif
 ifeq ($(do_tools_x86),true)
 	cd $(builddirpa)/tools/power/x86/x86_energy_perf_policy && make CROSS_COMPILE=$(CROSS_COMPILE)