From patchwork Tue Jan 15 03:13:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1024987 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43dwTm1ggMz9sCs; Tue, 15 Jan 2019 14:16:11 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gjFCu-00058v-LR; Tue, 15 Jan 2019 03:16:04 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gjFCs-00058E-JP for kernel-team@lists.ubuntu.com; Tue, 15 Jan 2019 03:16:02 +0000 Received: from mail-pg1-f197.google.com ([209.85.215.197]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gjFCs-0003Cd-7z for kernel-team@lists.ubuntu.com; Tue, 15 Jan 2019 03:16:02 +0000 Received: by mail-pg1-f197.google.com with SMTP id o9so829224pgv.19 for ; Mon, 14 Jan 2019 19:16:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Kbk+PvtvXwFVtrS4WYsvuFl0XiWe9GnK0nhzYEg5V8c=; b=Ltn//VGxPMXxK8upTgw8VpHVtFklxdJQC83c9acO2GXDWwLxD7JfmYYHcwUYWKms7/ AjzXyPKCVWtvgu5wFzySkba/+FE0UPGF8AcIFZElY+VliU00hxd734jWarSG6r2am2dY 9xBxfxbVLfrcKBTKUi9VGC8kxsHRSkN2iNsG0/WfG79r9UuXdKiq6maGx4m6hkR5eZtl BVdPv4QlLPJQxFHjpPHKh7XJYBNXxRjQ5TMjD/2pkgLYrFrK1/5TdmMrA5PXB376zG/X Nj48W8+dz1yJEW5RO6LHsgOPhImIt5SizeqBpWdVsy9bkFGqSkWngvm/iKNUtXeQqvkB zLFw== X-Gm-Message-State: AJcUukfJykUaUTFF7vanHxW2zvHHlfgffBOSTGZgQvVn2ZAWHpjJg1SH voK0lQ6IfNBzs+TWUaq6jlvU8IvVmHs41lAKXbhu3irJZmJ53O/d9zFh+zIcOZNIxrwDvAjPK0i iOb/9aWups7+pZUD9XyqMHPZYQMZMYddY4cT4gMpv X-Received: by 2002:a63:1d1d:: with SMTP id d29mr1755884pgd.49.1547522160647; Mon, 14 Jan 2019 19:16:00 -0800 (PST) X-Google-Smtp-Source: ALg8bN6LkWi1z1Vbe4ztKK4qWeqjj71hdM1TEr7mH68OlKzCWfj5C0+/mDvmmhzbAbWGdNKgK+ZhLw== X-Received: by 2002:a63:1d1d:: with SMTP id d29mr1755865pgd.49.1547522160412; Mon, 14 Jan 2019 19:16:00 -0800 (PST) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id w23sm2019768pgc.72.2019.01.14.19.15.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Jan 2019 19:15:59 -0800 (PST) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [C][SRU][PATCH 2/3] ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk for Chromebook Clapper Date: Tue, 15 Jan 2019 11:13:33 +0800 Message-Id: <20190115031334.11447-3-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190115031334.11447-1-po-hsu.lin@canonical.com> References: <20190115031334.11447-1-po-hsu.lin@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Hans de Goede BugLink: https://bugs.launchpad.net/bugs/1811566 The Clapper model Chromebook uses pmc_plt_clk_0 instead of pmc_plt_clk_3 for the mclk, just like the Swanky model. This commit adds a DMI based quirk for this. This fixing audio no longer working on these devices after commit 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") that commit fixes us unnecessary keeping unused clocks on, but in case of the Clapper that was breaking audio support since we were not using the right clock in the cht_bsw_max98090_ti machine driver. Cc: stable@vger.kernel.org Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") Signed-off-by: Hans de Goede Acked-by: Pierre-Louis Bossart Signed-off-by: Mark Brown (cherry picked from commit 984bfb398a3af6fa9b7e80165e524933b0616686) Signed-off-by: Po-Hsu Lin --- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/intel/boards/cht_bsw_max98090_ti.c b/sound/soc/intel/boards/cht_bsw_max98090_ti.c index 9d9f6e4..ad0c983 100644 --- a/sound/soc/intel/boards/cht_bsw_max98090_ti.c +++ b/sound/soc/intel/boards/cht_bsw_max98090_ti.c @@ -390,6 +390,13 @@ static struct snd_soc_card snd_soc_card_cht = { static const struct dmi_system_id cht_max98090_quirk_table[] = { { + /* Clapper model Chromebook */ + .matches = { + DMI_MATCH(DMI_PRODUCT_NAME, "Clapper"), + }, + .driver_data = (void *)QUIRK_PMC_PLT_CLK_0, + }, + { /* Swanky model Chromebook (Toshiba Chromebook 2) */ .matches = { DMI_MATCH(DMI_PRODUCT_NAME, "Swanky"),