From patchwork Fri Jan 11 07:46:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1023414 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="W6RET5KN"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43bZgn2cDqz9sCs; Fri, 11 Jan 2019 18:46:45 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ghrWX-0000pH-SB; Fri, 11 Jan 2019 07:46:37 +0000 Received: from mail-pf1-f196.google.com ([209.85.210.196]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ghrWV-0000ox-Da for kernel-team@lists.ubuntu.com; Fri, 11 Jan 2019 07:46:35 +0000 Received: by mail-pf1-f196.google.com with SMTP id 64so6573562pfr.9 for ; Thu, 10 Jan 2019 23:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=wIrSyZAkvH1oi5Y0ivOe78pX5jhy3UlFWhuZmJdlKmM=; b=W6RET5KNkhfTCL4WJ0asWfIfr0Kxu1Ra19rgsy5s5ZHWO5V1uK6N9Sz7w7hhpgtlEW ueAKp8wiGvROtb7x8DsSUEqHpYjK0oz92cJohIoygikEXO7DPyRECLWFtYkygAAR2fKZ pN0gUIASzuhGhY32hte0PL8IxgvUqpljlrYP+GLZ2lQIynoMxcMFb2z6EEvTYn3VG/u7 rJ+482XX37hRDGGwjC+athn2psie5k5kfxzmBOIMpwbwnjgEmZZFTIwBt+vVmBVZQWYd MQh+LmJ7iB4AtfVykXXK8Vl4VSTL1jQe9MK7yptU5mziP0daQ3um352R2qRL4UItuE0W 1fug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=wIrSyZAkvH1oi5Y0ivOe78pX5jhy3UlFWhuZmJdlKmM=; b=jxfTzeu+jgS1XH1xVM8IGbZCP7kRkm4mr3uL8tuGpTo8I3a2XoBBMxMNz/YMoZXj/x s1Npr25lB1XnuSxRbb2f9a0pjBfxXMB79wVsxtWlgCCUvcIARHTzuyVIkQL8wJkGHLXZ x+Z5jddIoagq8uI2a8gmMnCJZpbtCEWKsi12CgtZtOIk/9xdSM+HUO7XrUDXliolWQGq 3UGWAtJ0EVUFj3BrI4ANhzhjnSaJwoP3nv0b8AZ51KfPkUcKunCUGS+qfodVaufpXh6x wHbUwreeNrVofJcAjsjp0jdfwGfCMk0UqefXFPcbHEe4z9gNmF0yJciUOC5s1wnGzPpj zymw== X-Gm-Message-State: AJcUukdw3MtSrt/8glXTVAOTj2iLbFHPQ1f7qhMS53RsLCNAA3DEaYBP LlTIGuUQ9jmSiAJfl62a0GGUJsaV3yA= X-Google-Smtp-Source: ALg8bN4NXP3WFNKQ+zHhezkJpGkgxKxx9vu/KgzxBCkV5xRYILojK6U+LtAGccY+kifstgK7C6IcjA== X-Received: by 2002:a62:1112:: with SMTP id z18mr13407609pfi.173.1547192793613; Thu, 10 Jan 2019 23:46:33 -0800 (PST) Received: from localhost (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id k14sm123027794pgs.52.2019.01.10.23.46.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 23:46:32 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/2][SRU][B][C] pinctrl: cannonlake: Fix community ordering for H variant Date: Fri, 11 Jan 2019 15:46:26 +0800 Message-Id: <20190111074627.26560-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190111074627.26560-1-acelan.kao@canonical.com> References: <20190111074627.26560-1-acelan.kao@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Andy Shevchenko BugLink: https://bugs.launchpad.net/bugs/1811335 The driver was written based on an assumption that BIOS provides unordered communities in ACPI DSDT. Nevertheless, it seems that BIOS getting fixed before being provisioned to OxM:s. So does driver. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199911 Reported-by: Marc Landolt <2009@marclandolt.ch> Signed-off-by: Andy Shevchenko Fixes: a663ccf0fea1 ("pinctrl: intel: Add Intel Cannon Lake PCH-H pin controller support") Acked-by: Mika Westerberg Signed-off-by: Linus Walleij (cherry picked from commit 17ac526824a8b5544bc2545c76f489e49c6593a2) Signed-off-by: AceLan Kao --- drivers/pinctrl/intel/pinctrl-cannonlake.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-cannonlake.c b/drivers/pinctrl/intel/pinctrl-cannonlake.c index 6243e7d95e7e..b294de0b661a 100644 --- a/drivers/pinctrl/intel/pinctrl-cannonlake.c +++ b/drivers/pinctrl/intel/pinctrl-cannonlake.c @@ -447,12 +447,8 @@ static const struct intel_function cnlh_functions[] = { static const struct intel_community cnlh_communities[] = { CNL_COMMUNITY(0, 0, 50, cnlh_community0_gpps), CNL_COMMUNITY(1, 51, 154, cnlh_community1_gpps), - /* - * ACPI MMIO resources are returned in reverse order for - * communities 3 and 4. - */ - CNL_COMMUNITY(3, 155, 248, cnlh_community3_gpps), - CNL_COMMUNITY(2, 249, 298, cnlh_community4_gpps), + CNL_COMMUNITY(2, 155, 248, cnlh_community3_gpps), + CNL_COMMUNITY(3, 249, 298, cnlh_community4_gpps), }; static const struct intel_pinctrl_soc_data cnlh_soc_data = {