diff mbox

UBUNTU: [Config] set EDAC_MM_EDAC=y for ARM64

Message ID 20170726205825.27417-2-manoj.iyer@canonical.com
State New
Headers show

Commit Message

Manoj Iyer July 26, 2017, 8:58 p.m. UTC
Setting EDAC_MM_EDAC=y automatically enables EDAC_GHES on ARM64. ARMv8.0
systems lack standard RAS architecture (or machine check architecture
equivalent).

EDAC_GHES is essential for ARMv8.0 Servers, it enables firmware-first
error handling of memory and CPU errors. APEI/GHES is the only mechanism
available for reporting hardware errors (e.g. memory and CPU errors),
and helps enable memory fault recovery mechanisms to extend the life of
the system by offlining pages when recoverable uncorrected errors are
encountered.

BugLink: https://launchpad.net/bugs/1706141

Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
 debian.master/config/amd64/config.common.amd64     | 1 +
 debian.master/config/arm64/config.common.arm64     | 1 +
 debian.master/config/armhf/config.common.armhf     | 1 +
 debian.master/config/config.common.ubuntu          | 2 +-
 debian.master/config/i386/config.common.i386       | 1 +
 debian.master/config/ppc64el/config.common.ppc64el | 1 +
 6 files changed, 6 insertions(+), 1 deletion(-)

Comments

Stefan Bader July 27, 2017, 3:59 p.m. UTC | #1
On 26.07.2017 22:58, Manoj Iyer wrote:
> Setting EDAC_MM_EDAC=y automatically enables EDAC_GHES on ARM64. ARMv8.0
> systems lack standard RAS architecture (or machine check architecture
> equivalent).
> 
> EDAC_GHES is essential for ARMv8.0 Servers, it enables firmware-first
> error handling of memory and CPU errors. APEI/GHES is the only mechanism
> available for reporting hardware errors (e.g. memory and CPU errors),
> and helps enable memory fault recovery mechanisms to extend the life of
> the system by offlining pages when recoverable uncorrected errors are
> encountered.
> 
> BugLink: https://launchpad.net/bugs/1706141
> 
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
>  debian.master/config/amd64/config.common.amd64     | 1 +
>  debian.master/config/arm64/config.common.arm64     | 1 +
>  debian.master/config/armhf/config.common.armhf     | 1 +
>  debian.master/config/config.common.ubuntu          | 2 +-
>  debian.master/config/i386/config.common.i386       | 1 +
>  debian.master/config/ppc64el/config.common.ppc64el | 1 +

This should also update debian.master/config/annotations
CONFIG_EDAC_MM_EDAC                             policy<{'amd64': 'm', 'arm64':
-'m', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}>
CONFIG_EDAC_MM_EDAC                             policy<{'amd64': 'm', 'arm64':
+'y', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}>
+CONFIG_EDAC_MM_EDAC                             note<LP:1706141>

>  6 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.master/config/amd64/config.common.amd64 b/debian.master/config/amd64/config.common.amd64
> index f8efb586115e..eeb9f34e50f8 100644
> --- a/debian.master/config/amd64/config.common.amd64
> +++ b/debian.master/config/amd64/config.common.amd64
> @@ -81,6 +81,7 @@ CONFIG_DRM=m
>  CONFIG_DUMMY_IRQ=m
>  CONFIG_DW_WATCHDOG=m
>  CONFIG_ECHO=m
> +CONFIG_EDAC_MM_EDAC=m
>  CONFIG_EEPROM_93CX6=m
>  CONFIG_EFI=y
>  CONFIG_EFI_DEV_PATH_PARSER=y
> diff --git a/debian.master/config/arm64/config.common.arm64 b/debian.master/config/arm64/config.common.arm64
> index 72034ab3d898..0d6b52e5f95b 100644
> --- a/debian.master/config/arm64/config.common.arm64
> +++ b/debian.master/config/arm64/config.common.arm64
> @@ -92,6 +92,7 @@ CONFIG_DRM=m
>  CONFIG_DUMMY_IRQ=m
>  CONFIG_DW_WATCHDOG=m
>  CONFIG_ECHO=m
> +CONFIG_EDAC_MM_EDAC=y
>  CONFIG_EEPROM_93CX6=m
>  CONFIG_EFI=y
>  # CONFIG_EFI_DEV_PATH_PARSER is not set
> diff --git a/debian.master/config/armhf/config.common.armhf b/debian.master/config/armhf/config.common.armhf
> index 2f817ac68808..d04a8eace3ca 100644
> --- a/debian.master/config/armhf/config.common.armhf
> +++ b/debian.master/config/armhf/config.common.armhf
> @@ -84,6 +84,7 @@ CONFIG_DRM=m
>  CONFIG_DUMMY_IRQ=m
>  CONFIG_DW_WATCHDOG=m
>  CONFIG_ECHO=m
> +CONFIG_EDAC_MM_EDAC=m
>  CONFIG_EEPROM_93CX6=m
>  # CONFIG_EFI is not set
>  CONFIG_EFS_FS=m
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 57780e030658..57aacb217664 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -2421,6 +2421,7 @@ CONFIG_EDAC_CPC925=m
>  CONFIG_EDAC_DECODE_MCE=m
>  CONFIG_EDAC_E752X=m
>  CONFIG_EDAC_E7XXX=m
> +CONFIG_EDAC_GHES=y
>  CONFIG_EDAC_HIGHBANK_L2=m
>  CONFIG_EDAC_HIGHBANK_MC=m
>  CONFIG_EDAC_I3000=m
> @@ -2436,7 +2437,6 @@ CONFIG_EDAC_I82975X=m
>  CONFIG_EDAC_IE31200=m
>  CONFIG_EDAC_LAYERSCAPE=m
>  # CONFIG_EDAC_LEGACY_SYSFS is not set
> -CONFIG_EDAC_MM_EDAC=m
>  CONFIG_EDAC_R82600=m
>  CONFIG_EDAC_SBRIDGE=m
>  CONFIG_EDAC_SKX=m
> diff --git a/debian.master/config/i386/config.common.i386 b/debian.master/config/i386/config.common.i386
> index 4efc75aa06b2..b643ab7910d2 100644
> --- a/debian.master/config/i386/config.common.i386
> +++ b/debian.master/config/i386/config.common.i386
> @@ -78,6 +78,7 @@ CONFIG_DRM=m
>  CONFIG_DUMMY_IRQ=m
>  CONFIG_DW_WATCHDOG=m
>  CONFIG_ECHO=m
> +CONFIG_EDAC_MM_EDAC=m
>  CONFIG_EEPROM_93CX6=m
>  CONFIG_EFI=y
>  CONFIG_EFI_DEV_PATH_PARSER=y
> diff --git a/debian.master/config/ppc64el/config.common.ppc64el b/debian.master/config/ppc64el/config.common.ppc64el
> index 95c05e67133a..9dee9c971980 100644
> --- a/debian.master/config/ppc64el/config.common.ppc64el
> +++ b/debian.master/config/ppc64el/config.common.ppc64el
> @@ -78,6 +78,7 @@ CONFIG_DRM=m
>  CONFIG_DUMMY_IRQ=m
>  CONFIG_DW_WATCHDOG=m
>  CONFIG_ECHO=m
> +CONFIG_EDAC_MM_EDAC=m
>  CONFIG_EEPROM_93CX6=m
>  CONFIG_EFS_FS=m
>  # CONFIG_EM_TIMER_STI is not set
>
Manoj Iyer July 27, 2017, 4:36 p.m. UTC | #2
Resending patch incorporating Stefan's reivew comments.
diff mbox

Patch

diff --git a/debian.master/config/amd64/config.common.amd64 b/debian.master/config/amd64/config.common.amd64
index f8efb586115e..eeb9f34e50f8 100644
--- a/debian.master/config/amd64/config.common.amd64
+++ b/debian.master/config/amd64/config.common.amd64
@@ -81,6 +81,7 @@  CONFIG_DRM=m
 CONFIG_DUMMY_IRQ=m
 CONFIG_DW_WATCHDOG=m
 CONFIG_ECHO=m
+CONFIG_EDAC_MM_EDAC=m
 CONFIG_EEPROM_93CX6=m
 CONFIG_EFI=y
 CONFIG_EFI_DEV_PATH_PARSER=y
diff --git a/debian.master/config/arm64/config.common.arm64 b/debian.master/config/arm64/config.common.arm64
index 72034ab3d898..0d6b52e5f95b 100644
--- a/debian.master/config/arm64/config.common.arm64
+++ b/debian.master/config/arm64/config.common.arm64
@@ -92,6 +92,7 @@  CONFIG_DRM=m
 CONFIG_DUMMY_IRQ=m
 CONFIG_DW_WATCHDOG=m
 CONFIG_ECHO=m
+CONFIG_EDAC_MM_EDAC=y
 CONFIG_EEPROM_93CX6=m
 CONFIG_EFI=y
 # CONFIG_EFI_DEV_PATH_PARSER is not set
diff --git a/debian.master/config/armhf/config.common.armhf b/debian.master/config/armhf/config.common.armhf
index 2f817ac68808..d04a8eace3ca 100644
--- a/debian.master/config/armhf/config.common.armhf
+++ b/debian.master/config/armhf/config.common.armhf
@@ -84,6 +84,7 @@  CONFIG_DRM=m
 CONFIG_DUMMY_IRQ=m
 CONFIG_DW_WATCHDOG=m
 CONFIG_ECHO=m
+CONFIG_EDAC_MM_EDAC=m
 CONFIG_EEPROM_93CX6=m
 # CONFIG_EFI is not set
 CONFIG_EFS_FS=m
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 57780e030658..57aacb217664 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -2421,6 +2421,7 @@  CONFIG_EDAC_CPC925=m
 CONFIG_EDAC_DECODE_MCE=m
 CONFIG_EDAC_E752X=m
 CONFIG_EDAC_E7XXX=m
+CONFIG_EDAC_GHES=y
 CONFIG_EDAC_HIGHBANK_L2=m
 CONFIG_EDAC_HIGHBANK_MC=m
 CONFIG_EDAC_I3000=m
@@ -2436,7 +2437,6 @@  CONFIG_EDAC_I82975X=m
 CONFIG_EDAC_IE31200=m
 CONFIG_EDAC_LAYERSCAPE=m
 # CONFIG_EDAC_LEGACY_SYSFS is not set
-CONFIG_EDAC_MM_EDAC=m
 CONFIG_EDAC_R82600=m
 CONFIG_EDAC_SBRIDGE=m
 CONFIG_EDAC_SKX=m
diff --git a/debian.master/config/i386/config.common.i386 b/debian.master/config/i386/config.common.i386
index 4efc75aa06b2..b643ab7910d2 100644
--- a/debian.master/config/i386/config.common.i386
+++ b/debian.master/config/i386/config.common.i386
@@ -78,6 +78,7 @@  CONFIG_DRM=m
 CONFIG_DUMMY_IRQ=m
 CONFIG_DW_WATCHDOG=m
 CONFIG_ECHO=m
+CONFIG_EDAC_MM_EDAC=m
 CONFIG_EEPROM_93CX6=m
 CONFIG_EFI=y
 CONFIG_EFI_DEV_PATH_PARSER=y
diff --git a/debian.master/config/ppc64el/config.common.ppc64el b/debian.master/config/ppc64el/config.common.ppc64el
index 95c05e67133a..9dee9c971980 100644
--- a/debian.master/config/ppc64el/config.common.ppc64el
+++ b/debian.master/config/ppc64el/config.common.ppc64el
@@ -78,6 +78,7 @@  CONFIG_DRM=m
 CONFIG_DUMMY_IRQ=m
 CONFIG_DW_WATCHDOG=m
 CONFIG_ECHO=m
+CONFIG_EDAC_MM_EDAC=m
 CONFIG_EEPROM_93CX6=m
 CONFIG_EFS_FS=m
 # CONFIG_EM_TIMER_STI is not set