| Message ID | 20170323094218.2004-1-shrirang.bagul@canonical.com |
|---|---|
| State | New |
| Headers | show |
Isolated to one bit of HW
Looks to be for a specific SOC. But some background info somewhere on why this should not go upstream would be nice. -Stefan
On Mon, 2017-03-27 at 16:25 +0200, Stefan Bader wrote: > Looks to be for a specific SOC. But some background info somewhere on why this > should not go upstream would be nice. Agreed. We are trying to upstream this ASoC machine driver to support RT5660(ALC3277) codec based sound cards on Baytrail-I SoC. Two versions of the driver were already submitted upstream for review. See: 1. http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115928.html 2. http://mailman.alsa-project.org/pipermail/alsa-devel/2017-January/116510.html Because some Intel audio patches for Baytrail-I are queued to be merged by the maintainer, this audio driver wasn't merged. Meanwhile, in order to meet the deadline of delivering signed kernel for the Dell IoT gateway project, this driver had to be SRU'ed without an upstream candidate. > > -Stefan >
Applied to xenial master-next branch. Thanks. Cascardo.
diff --git a/sound/soc/intel/boards/bytcr_rt5660.c b/sound/soc/intel/boards/bytcr_rt5660.c index b51706a..096e76f 100644 --- a/sound/soc/intel/boards/bytcr_rt5660.c +++ b/sound/soc/intel/boards/bytcr_rt5660.c @@ -85,10 +85,10 @@ static int byt_rt5660_aif1_hw_params(struct snd_pcm_substream *substream, return ret; } - /* use bitclock as PLL input */ + /* use mclk as PLL input */ /* 2x15 bit slots on SSP2 */ - ret = snd_soc_dai_set_pll(codec_dai, 0, RT5660_PLL1_S_BCLK, - params_rate(params) * 50, + ret = snd_soc_dai_set_pll(codec_dai, 0, RT5660_PLL1_S_MCLK, + 19200000, params_rate(params) * 512); if (ret < 0) {
BugLink: http://bugs.launchpad.net/bugs/1675327 Replace bitclock by mclk as PLL source to fix noise in audio output from line-out jack. Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com> --- sound/soc/intel/boards/bytcr_rt5660.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)