diff mbox

tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Message ID 20170320201701.29024-1-manoj.iyer@canonical.com
State New
Headers show

Commit Message

Manoj Iyer March 20, 2017, 8:17 p.m. UTC 
From: Timur Tabi <timur@codeaurora.org>

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
the ACPI oem_revision field is actually set to 1, not 0.

Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")

BugLink: https://bugs.launchpad.net/bugs/1674466
Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
Signed-off-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
 drivers/acpi/spcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee March 20, 2017, 9:44 p.m. UTC | #1 
On Mon, Mar 20, 2017 at 03:17:01PM -0500, manoj.iyer@canonical.com wrote:
> From: Timur Tabi <timur@codeaurora.org>
> 
> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
> the ACPI oem_revision field is actually set to 1, not 0.
> 
> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
> 
> BugLink: https://bugs.launchpad.net/bugs/1674466
> Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>

The patch looks fine, but we need a buglink.
Manoj Iyer March 20, 2017, 10:11 p.m. UTC | #2 
On Mon, 20 Mar 2017, Seth Forshee wrote:

> On Mon, Mar 20, 2017 at 03:17:01PM -0500, manoj.iyer@canonical.com wrote:
>> From: Timur Tabi <timur@codeaurora.org>
>>
>> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
>> the ACPI oem_revision field is actually set to 1, not 0.
>>
>> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
>>
>> BugLink: https://bugs.launchpad.net/bugs/1674466
>> Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
>> Signed-off-by: Timur Tabi <timur@codeaurora.org>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> (cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>
> The patch looks fine, but we need a buglink.

The buglink is right there before the signoffs

>
>

--
============================
Manoj Iyer
Ubuntu/Canonical
ARM Servers - Cloud
============================
Seth Forshee March 20, 2017, 10:19 p.m. UTC | #3 
On Mon, Mar 20, 2017 at 05:11:21PM -0500, Manoj Iyer wrote:
> 
> On Mon, 20 Mar 2017, Seth Forshee wrote:
> 
> >On Mon, Mar 20, 2017 at 03:17:01PM -0500, manoj.iyer@canonical.com wrote:
> >>From: Timur Tabi <timur@codeaurora.org>
> >>
> >>For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
> >>the ACPI oem_revision field is actually set to 1, not 0.
> >>
> >>Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
> >>
> >>BugLink: https://bugs.launchpad.net/bugs/1674466
> >>Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
> >>Signed-off-by: Timur Tabi <timur@codeaurora.org>
> >>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>(cherry picked from commit 542ed784671d4678406c77ed6dd01593a0cdbea1)
> >>Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> >
> >The patch looks fine, but we need a buglink.
> 
> The buglink is right there before the signoffs

D'oh, so it is.

Applied to zesty master-next.
diff mbox

Patch

diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 2b5d0fa..2051a8c 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -30,7 +30,7 @@  static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
 		return true;
 
 	if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
-			h->oem_revision == 0)
+			h->oem_revision == 1)
 		return true;
 
 	return false;