| Message ID | 20170131180216.17317-1-cascardo@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 31.01.2017 19:02, Thadeu Lima de Souza Cascardo wrote: > For the main package, linux, set the upload-to-ppa assignee to > canonical-kernel-team. > Generally ok, just wondering from previous days discussion whether that task is of any use. From last turning the crank I remember that the prepare-package-* tasks seemed to switch state based on ppa upload. Of course the upload-to-ppa one maybe is or will be used as an accumulated state reflecting the status of all prepare-package-* ones. -Stefan > Otherwise, the task would be set to invalid, as no assignee was found. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- > ktl/workflow.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ktl/workflow.py b/ktl/workflow.py > index 2d0eb6c..18f0410 100644 > --- a/ktl/workflow.py > +++ b/ktl/workflow.py > @@ -134,6 +134,7 @@ class Workflow: > 'prepare-package-ports-meta' : 'canonical-kernel-team', > 'prepare-package-signed' : 'canonical-kernel-team', > 'automated-testing' : 'canonical-kernel-team', > + 'upload-to-ppa' : 'canonical-kernel-team', > 'promote-to-proposed' : 'ubuntu-sru', > 'verification-testing' : 'canonical-kernel-team', > 'certification-testing' : 'canonical-hw-cert', >
On Wed, Feb 01, 2017 at 11:12:26AM +0100, Stefan Bader wrote: > On 31.01.2017 19:02, Thadeu Lima de Souza Cascardo wrote: > > For the main package, linux, set the upload-to-ppa assignee to > > canonical-kernel-team. > > > > Generally ok, just wondering from previous days discussion whether that task is > of any use. From last turning the crank I remember that the prepare-package-* > tasks seemed to switch state based on ppa upload. Of course the upload-to-ppa > one maybe is or will be used as an accumulated state reflecting the status of > all prepare-package-* ones. > My plan is to use the bug.uploaded() to shank the task to 'Fix Released'. Does it make sense? Cascardo. > -Stefan > > > Otherwise, the task would be set to invalid, as no assignee was found. > > > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > > --- > > ktl/workflow.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ktl/workflow.py b/ktl/workflow.py > > index 2d0eb6c..18f0410 100644 > > --- a/ktl/workflow.py > > +++ b/ktl/workflow.py > > @@ -134,6 +134,7 @@ class Workflow: > > 'prepare-package-ports-meta' : 'canonical-kernel-team', > > 'prepare-package-signed' : 'canonical-kernel-team', > > 'automated-testing' : 'canonical-kernel-team', > > + 'upload-to-ppa' : 'canonical-kernel-team', > > 'promote-to-proposed' : 'ubuntu-sru', > > 'verification-testing' : 'canonical-kernel-team', > > 'certification-testing' : 'canonical-hw-cert', > > > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 01.02.2017 11:15, Thadeu Lima de Souza Cascardo wrote: > On Wed, Feb 01, 2017 at 11:12:26AM +0100, Stefan Bader wrote: >> On 31.01.2017 19:02, Thadeu Lima de Souza Cascardo wrote: >>> For the main package, linux, set the upload-to-ppa assignee to >>> canonical-kernel-team. >>> >> >> Generally ok, just wondering from previous days discussion whether that task is >> of any use. From last turning the crank I remember that the prepare-package-* >> tasks seemed to switch state based on ppa upload. Of course the upload-to-ppa >> one maybe is or will be used as an accumulated state reflecting the status of >> all prepare-package-* ones. >> > > My plan is to use the bug.uploaded() to shank the task to 'Fix Released'. > > Does it make sense? Honestly, I think I need more background to understand that (maybe in the daily meeting). But as long as there is any plan behind this, there is no reason to not ACK this. :) -Stefan > > Cascardo. > >> -Stefan >> >>> Otherwise, the task would be set to invalid, as no assignee was found. >>> >>> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> >>> --- >>> ktl/workflow.py | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/ktl/workflow.py b/ktl/workflow.py >>> index 2d0eb6c..18f0410 100644 >>> --- a/ktl/workflow.py >>> +++ b/ktl/workflow.py >>> @@ -134,6 +134,7 @@ class Workflow: >>> 'prepare-package-ports-meta' : 'canonical-kernel-team', >>> 'prepare-package-signed' : 'canonical-kernel-team', >>> 'automated-testing' : 'canonical-kernel-team', >>> + 'upload-to-ppa' : 'canonical-kernel-team', >>> 'promote-to-proposed' : 'ubuntu-sru', >>> 'verification-testing' : 'canonical-kernel-team', >>> 'certification-testing' : 'canonical-hw-cert', >>> >> >> > > > > >> -- >> kernel-team mailing list >> kernel-team@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/kernel-team >
I'm fine with the change as long as you thoroughly test it out. Brad
diff --git a/ktl/workflow.py b/ktl/workflow.py index 2d0eb6c..18f0410 100644 --- a/ktl/workflow.py +++ b/ktl/workflow.py @@ -134,6 +134,7 @@ class Workflow: 'prepare-package-ports-meta' : 'canonical-kernel-team', 'prepare-package-signed' : 'canonical-kernel-team', 'automated-testing' : 'canonical-kernel-team', + 'upload-to-ppa' : 'canonical-kernel-team', 'promote-to-proposed' : 'ubuntu-sru', 'verification-testing' : 'canonical-kernel-team', 'certification-testing' : 'canonical-hw-cert',
For the main package, linux, set the upload-to-ppa assignee to canonical-kernel-team. Otherwise, the task would be set to invalid, as no assignee was found. Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> --- ktl/workflow.py | 1 + 1 file changed, 1 insertion(+)