diff mbox

[V2] ACPI / blacklist: add _REV quirks for Dell Precision 5520 and 3520

Message ID 20161216021056.4468-2-alex.hung@canonical.com
State New
Headers show

Commit Message

Alex Hung Dec. 16, 2016, 2:10 a.m. UTC
Precision 5520 and 3520 either hang at login and during suspend or reboot.

It turns out that that adding them to acpi_rev_dmi_table[] helps to work
around those issues.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

(cherry picked from commit 9523b9bf6dceef6b0215e90b2348cd646597f796)
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/acpi/blacklist.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Tim Gardner Dec. 16, 2016, 12:48 p.m. UTC | #1
On 12/15/2016 07:10 PM, Alex Hung wrote:
> Precision 5520 and 3520 either hang at login and during suspend or reboot.
> 
> It turns out that that adding them to acpi_rev_dmi_table[] helps to work
> around those issues.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> [ rjw: Changelog ]
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> (cherry picked from commit 9523b9bf6dceef6b0215e90b2348cd646597f796)

Should be "back ported from"
Colin Ian King Dec. 16, 2016, 1:52 p.m. UTC | #2
On 16/12/16 02:10, Alex Hung wrote:
> Precision 5520 and 3520 either hang at login and during suspend or reboot.
> 
> It turns out that that adding them to acpi_rev_dmi_table[] helps to work
> around those issues.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> [ rjw: Changelog ]
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> (cherry picked from commit 9523b9bf6dceef6b0215e90b2348cd646597f796)
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/acpi/blacklist.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index 94e4390..8f4f198 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -429,6 +429,22 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		      DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"),
>  		},
>  	},
> +	{
> +	 .callback = dmi_enable_rev_override,
> +	 .ident = "DELL Precision 5520",
> +	 .matches = {
> +		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		      DMI_MATCH(DMI_PRODUCT_NAME, "Precision 5520"),
> +		},
> +	},
> +	{
> +	 .callback = dmi_enable_rev_override,
> +	 .ident = "DELL Precision 3520",
> +	 .matches = {
> +		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		      DMI_MATCH(DMI_PRODUCT_NAME, "Precision 3520"),
> +		},
> +	},
>  #endif
>  	{}
>  };
> 

Limited platform impact, is upstream fix.

Not sure which kernel series this is for. If that can be clarified, that
would be useful, otherwise ACK.

Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox

Patch

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 94e4390..8f4f198 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -429,6 +429,22 @@  static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		      DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"),
 		},
 	},
+	{
+	 .callback = dmi_enable_rev_override,
+	 .ident = "DELL Precision 5520",
+	 .matches = {
+		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		      DMI_MATCH(DMI_PRODUCT_NAME, "Precision 5520"),
+		},
+	},
+	{
+	 .callback = dmi_enable_rev_override,
+	 .ident = "DELL Precision 3520",
+	 .matches = {
+		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		      DMI_MATCH(DMI_PRODUCT_NAME, "Precision 3520"),
+		},
+	},
 #endif
 	{}
 };