From patchwork Mon Dec 25 06:20:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Duan X-Patchwork-Id: 1880060 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Sz78Q0K3xz20Rq for ; Mon, 25 Dec 2023 17:21:26 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rHeKs-0006q9-W5; Mon, 25 Dec 2023 06:21:11 +0000 Received: from mail-bn8nam11on2041.outbound.protection.outlook.com ([40.107.236.41] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rHeKg-0006o6-1V for kernel-team@lists.ubuntu.com; Mon, 25 Dec 2023 06:20:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NOyN3C4bArUe9L1erD43HUD8xYrn/8lMqjCQWmWIFg9EmemZ4DE37nFsHVdAGoxE5RN/oupSLL7Y8evKd4G6vXCp/MwaaujiYTj/3A4zIRhqCLxeGWovtcC6JOTIlWjEYnlMmlXQfpAvU0CP2784ES1ZRphgQlBENoesD6saZifHBZ7S5cCXn+9Q1Ew1/if70J9rZHPV0a9v71Sv5IIP1VpaES0hLAsfum3c/0GT0whvdZ3GzH1B4iQ/ebQzx1V9eg/vNJBAJgwBkDUBtc2vGGOqWBK7TSzWu1G1CgRcXngfJLbMZRPAfKNL5kcZUREsmz8/b6+iC4AD8AeTWemE3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jlM+Rq26XfIGFMev518RUZnvFc+Lv2nV4s15f4b7EqQ=; b=dK7d6WbodNKDQabV7yOGtO0oJa9tVXKnJnNCfpk4ZYCuQpNyjfPdu8PXu6hfrqNp5YYZrdUi/HDmRfDI1Fxfo497scTFDzYk6KWXccjOsefJy3S5lWZ5P1XoVSab9JgDcwaOn2vmmYU79zuL+nawC4u4kUqAGZzRt+6zLL9F5nh9UR70EdCxCALrsPJ2e4Hi4qWBA/npqPwRX8phaYlXWdYHbCBFUQCvYq7xGdowMla7sqmH4VghT9u7TRIuwiLbmbLyxsO5Z4toZQo7v8BMFz6lFNR/3cpxiRswKOsxxgIfM3kP3ZUu6CtTDzY0IlxB2QgjMxChDeBW9DtP74Rweg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) Received: from SJ2PR07CA0006.namprd07.prod.outlook.com (2603:10b6:a03:505::18) by SJ0PR12MB5454.namprd12.prod.outlook.com (2603:10b6:a03:304::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.26; Mon, 25 Dec 2023 06:20:52 +0000 Received: from SJ5PEPF000001CF.namprd05.prod.outlook.com (2603:10b6:a03:505:cafe::75) by SJ2PR07CA0006.outlook.office365.com (2603:10b6:a03:505::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.26 via Frontend Transport; Mon, 25 Dec 2023 06:20:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SJ5PEPF000001CF.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.14 via Frontend Transport; Mon, 25 Dec 2023 06:20:52 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 24 Dec 2023 22:20:42 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 24 Dec 2023 22:20:41 -0800 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Sun, 24 Dec 2023 22:20:41 -0800 Received: from sw-mtx-008.mtx.labs.mlnx. (sw-mtx-008.mtx.labs.mlnx [10.9.150.35]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 3BP6KW6F031863; Mon, 25 Dec 2023 08:20:38 +0200 From: Tony Duan To: Subject: [SRU][J:linux-bluefield][PATCH v1 3/9] xfrm: Flush xfrm state synchronously on netdev close or unregister Date: Mon, 25 Dec 2023 00:20:25 -0600 Message-ID: <1703485231-27098-4-git-send-email-yifeid@nvidia.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1703485231-27098-1-git-send-email-yifeid@nvidia.com> References: <1703485231-27098-1-git-send-email-yifeid@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CF:EE_|SJ0PR12MB5454:EE_ X-MS-Office365-Filtering-Correlation-Id: f2297baf-646c-47f3-ea53-08dc0511a50a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lK0YMypEpLudgexxz5Vrabd3P9lChm2SRBOs7qSE1zyEUrPpzah3NE7oEk7iCOXc629gfd60JQV164UG8zOHftdeY8uOu0Lt8DXjucFISc+kxP258x6f2Z1oqiwX0ac1UPDRe4lGfDy52MronmAwE4upd1U3HSLLwooqViKYztNBdL2ZTBnlD+qD9jwMyrAs6vBB3S5W1gk+h52n+XOExi6968hPMu+aAEaxGuKQVa102Dl6WP6UPEKQlTfarjo6hUcbRWkJZjj30XFq3RrIxN9AKsp8FHZBzVhVqivwxrTSO4zSV1Mp7GVnvxSWlZJRo7kI0P74mB+NP3oiiumlijxOQ/OdohIPZyvAWNJkWd45gYJMGep/29lBa6/+cA4QIii1jo0c2vTN4qlpedy3I3Xhe4gfiWDml2qAaytjakJsRPdHZdQCjD0nepdTt1dGqTmYDSk8De6+BsHPT9rdwljBGdZYB0FgBv3l548Oa8F4z33FiMKgdaReHbYUV0ME5bltONRNYrddh0KsAKHFk02C2lC6VYFHXGH5SS3ioAj0KbAy0QUWVGOlSSpLkClBqRD9ab3EZ2k+B+l+gSWuGi5BwVBWkge+VYib+J0/V5oGwyu024piNPdixX27ofcskVpdqR921nAer0szrXHG7PB+LpnAy9jhcjgk3kvfxytye2Y3U93r4YS8SDvaB+Xj7EKglj+DdjbOZBH1Dv0D7dqysdvRZbSWw0tbNf/w4AOcMAiMDKQln61VVPFJRKLQNXM5DZqUrKeFRup7vBR6mT50cYUkWtnZUaZbPMXVob8= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(376002)(346002)(136003)(230922051799003)(451199024)(1800799012)(82310400011)(186009)(64100799003)(40470700004)(46966006)(36840700001)(47076005)(356005)(7636003)(36860700001)(41300700001)(86362001)(26005)(336012)(36756003)(2616005)(83380400001)(40480700001)(40460700003)(82740400003)(478600001)(316002)(6916009)(966005)(54906003)(70586007)(70206006)(6666004)(8676002)(8936002)(5660300002)(4326008)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2023 06:20:52.1150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2297baf-646c-47f3-ea53-08dc0511a50a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5454 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vlad@nvidia.com, dann.frazier@canonical.com, bodong@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Jianbo Liu BugLink: https://bugs.launchpad.net/bugs/2044427 When NETDEV_DOWN or NETDEV_UNREGISTER is received, netdev is being closed or unregistered, and all xfrm_states are being flushed. It's better to bypass GC and destroy them directly, so the hardware resources for those offloaded xfrm_state can be safely freed. Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") Signed-off-by: Jianbo Liu Signed-off-by: Leon Romanovsky (cherry picked from commit ebf036124a1df1eed16ab752212854495cbb8264) Signed-off-by: Tony Duan --- net/xfrm/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 05686ac..950761a 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -870,7 +870,7 @@ int xfrm_dev_state_flush(struct net *net, struct net_device *dev, bool task_vali err = xfrm_state_delete(x); xfrm_audit_state_delete(x, err ? 0 : 1, task_valid); - xfrm_state_put(x); + xfrm_state_put_sync(x); if (!err) cnt++;