From patchwork Thu Oct 27 21:26:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bodong Wang X-Patchwork-Id: 1695683 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=BAo6WYnC; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MyzKd6Tz5z23l4 for ; Fri, 28 Oct 2022 08:27:32 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ooAPM-0004eu-7A; Thu, 27 Oct 2022 21:27:24 +0000 Received: from mail-bn7nam10on2070.outbound.protection.outlook.com ([40.107.92.70] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ooAPH-0004cx-H4 for kernel-team@lists.ubuntu.com; Thu, 27 Oct 2022 21:27:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ioA6qAfCGwhArMnlCw6/PfI72jMuirOk+/j/X2s/RQhZYEkBJspL2Y4Cx5lL1nR7nFZEpijLucFBWO8ALVpYbHpT/vvbjs7yq4uenFN/wmlibq4W1NKeEjKGIzXisUHKPeX1aA24fbvy7dls/jN2NWffbWuXTNIpQyi6yk2i2eqXzkYpRRaNDkfIqnNkqYP+4Bpni1x7ZiD9Jfjwn8DEaBbsQqwbMcOTylDvwApEHludTrVyZ9VgVM8MKdFyMH7BuuxfpuF9kwNpjneN/BHt5WIoobwpo9KJoVQiefLCxy5H57RyK/XHWG6FWAlfZB6cgECZBCSLa40JyyO6atqB3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GDYf/mzZ19rHOFRg2sVqhLkgWalQsAc+7C7NjH7DRDw=; b=WwNXitN6KGcujjd98bCPSGNv0923IV6v9vlOqeZT1qxpvEMYWquz076OjnYkZdNzVww9PsUlFsap+yYWAqgloFRhvyFqZFGAwjqr9O8qjJbgilDNw/JXUByNd0ViQUu3Jl+pnnIPxjmrbqiOyDlgpjXVdzwJBWbogev8Zi54ayqEe/Cn5xNKwUVSQ++SIVW2HowOBPYduahHwnjciroUTIgFIr/YZ6r3zYGErTXe9kigwUUAJhStfI5Q8teysOQRGK+gTgfhXD9gdsYhktotPXyZQgn0XdWf28hgyDZM7rI6qVV8u1CnERy/Xavv3WRKF0fPQykHBFUKwskQmVp4kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GDYf/mzZ19rHOFRg2sVqhLkgWalQsAc+7C7NjH7DRDw=; b=BAo6WYnCgAK/1M+mRtUJiy3UGGXQMmgmeEh1of29ubcybKSUPX588XsiuZkpBKH16u6TPXAuL0IQNJKO2a45gp+fOWgOl8LSiJHAniEq7TEXf+ZxFhobC07+b1kDGtqwYaRfJqAgEYnPSHr4Nmhsd5jDJYrxPsXCWkFd8uum6MM4Kziy2KPWUavWtYektsiK9KKK9f8O0EHhSucpECn3Zyehte/R3IQr8rdE6guQP4CkC+2iFo4k8eGZB60OQo2g5nTNYFgEyjTPLxw8rpWhU04iPEzamauL9eZZhNbTsZSFzO8udkDMCl4xVqSJ1EVcLUF5UjCvxpE2Dji2k1+Izg== Received: from MW4PR04CA0252.namprd04.prod.outlook.com (2603:10b6:303:88::17) by PH7PR12MB6858.namprd12.prod.outlook.com (2603:10b6:510:1b4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 27 Oct 2022 21:27:16 +0000 Received: from CO1NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:303:88:cafe::af) by MW4PR04CA0252.outlook.office365.com (2603:10b6:303:88::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.29 via Frontend Transport; Thu, 27 Oct 2022 21:27:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CO1NAM11FT090.mail.protection.outlook.com (10.13.175.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Thu, 27 Oct 2022 21:27:16 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Thu, 27 Oct 2022 14:27:09 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 27 Oct 2022 14:27:09 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Thu, 27 Oct 2022 14:27:08 -0700 Received: from sw-mtx-hparm-006.mtx.labs.mlnx. (sw-mtx-hparm-006.mtx.labs.mlnx [10.9.151.93]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 29RLR02E032221; Fri, 28 Oct 2022 00:27:06 +0300 From: Bodong Wang To: Subject: [SRU][F:linux-bluefield][PATCH 05/10] netfilter: flowtable: Make sure GC works periodically in idle system Date: Thu, 27 Oct 2022 16:26:43 -0500 Message-ID: <1666906019-80328-6-git-send-email-bodong@nvidia.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1666906019-80328-1-git-send-email-bodong@nvidia.com> References: <1666906019-80328-1-git-send-email-bodong@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT090:EE_|PH7PR12MB6858:EE_ X-MS-Office365-Filtering-Correlation-Id: 6084108b-5ef6-463b-a28f-08dab8620585 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t9lorxlyDOwutX8TD/OkH0Z4JE5SZmFyPk1bXI7DKdEKH2CsbIWy2QQpK/4dFnzgNKfEQkOEKJk6ikr0TVzXogKM63ywZvIQx2L+xKUBwpJX7EIIeoS2iABek2Ql1jdrO/NtSaeZp1sEQk5itig7OaaDLj7tzgkSgNrKwdBATE+MXmDJi5I1OsA8yG5J5avg5mtGXx5KOj1gFYgewx6ROhwpgqX78DOBE54wikl7Or/lrBJnXHsDI5cx7BkwBzvu+XGxI360jHdMbAZ1VvUyYJ1EyTuJUOTM6cX3mXGLZVQG0hyQHD1ni2nqRceeyzmzXSNki2GD6VIfKdFRviC6TFje4ot/acbzl84xC2DJd8/w6dFl7Ldj0UHw/GAM0VbDIE9GC+Nf7edeFnOXFz1QUnWem2JNvRJIBI31ywpHQPcHAHihsJeoO2wJ6+5kasvrI+TPOWrFW5w+bOlH+s9w7OHjcD8oYBfMeF6kG+/ZAbKevZZVm0/sV72opepzi/TlhTnVweoUjOg76eyT3X5SUCzj2qOMUwIpSafDHeKGYhbPtIgJtcSx8seXlENpcx9Q0ZwYJUadTKD7FNpkhKfRx/B/AHzVa9hdI+TJ2Hod7bFtAKgdei4uB2DZowD8C8x5fQdGzxUT23QHXDOQeSdNdPmM+ylv1KffCwyEn7viROHhV46SQfPJ8LTWy5K7rY8aOzjyWJGPfs+mBceggPiIzEpDJLYgcMyWJaoXY8Hak9ewdKLIbvYRNNMXTq5dGh6mqW2uSqcNp/fRGyIoRo952HRSMx5pO9GshyU+m5/yUc9nIj0rr9xzpfp4AT4bscbqguC1PQKPqbjSdpCy6DhB2cKh9t0FPh17jsBm5J7NnIk= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199015)(46966006)(36840700001)(40470700004)(54906003)(966005)(336012)(2906002)(478600001)(356005)(7636003)(82740400003)(186003)(6916009)(47076005)(107886003)(6666004)(40480700001)(26005)(41300700001)(86362001)(316002)(2616005)(70586007)(4326008)(40460700003)(8676002)(82310400005)(36860700001)(70206006)(36756003)(83380400001)(5660300002)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 21:27:16.4358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6084108b-5ef6-463b-a28f-08dab8620585 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6858 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vlad@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Yinjun Zhang BugLink: https://bugs.launchpad.net/bugs/1995004 Currently flowtable's GC work is initialized as deferrable, which means GC cannot work on time when system is idle. So the hardware offloaded flow may be deleted for timeout, since its used time is not timely updated. Resolve it by initializing the GC work as delayed work instead of deferrable. Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support") Change-Id: I99843e5974c9bbb41dfbaf1dc062e538e1938f34 Signed-off-by: Yinjun Zhang Signed-off-by: Louis Peens Signed-off-by: Simon Horman Signed-off-by: Pablo Neira Ayuso Signed-off-by: Bodong Wang --- net/netfilter/nf_flow_table_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_flow_table_core.c b/net/netfilter/nf_flow_table_core.c index dd29f4f..d60a206 100644 --- a/net/netfilter/nf_flow_table_core.c +++ b/net/netfilter/nf_flow_table_core.c @@ -522,7 +522,7 @@ int nf_flow_table_init(struct nf_flowtable *flowtable) { int err; - INIT_DEFERRABLE_WORK(&flowtable->gc_work, nf_flow_offload_work_gc); + INIT_DELAYED_WORK(&flowtable->gc_work, nf_flow_offload_work_gc); flow_block_init(&flowtable->flow_block); init_rwsem(&flowtable->flow_block_lock);