From patchwork Thu Apr 12 06:42:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Talat Batheesh X-Patchwork-Id: 897646 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="N2nqI7x7"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 40MLQl28vsz9s3R; Thu, 12 Apr 2018 22:52:15 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1f6bhw-00052H-6I; Thu, 12 Apr 2018 12:52:08 +0000 Received: from mail-eopbgr00056.outbound.protection.outlook.com ([40.107.0.56] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1f6Vww-0000Ju-P8 for kernel-team@lists.ubuntu.com; Thu, 12 Apr 2018 06:43:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uDF333k6k0m+PquverEQ8fLdNsleManbIKdU9IaNyOY=; b=N2nqI7x7OzYYXiAPk/jZGZALu+byY8XaHI3ZEXX+SEJ0e7D8Nkek6JuuYIRCY5yisxO1Vh9vz6d87fr9Y13bHGZCTyP4nwIlUs5Qj7dAEDTISqWaeNLHnFjXkyWYt7mhKPJauA8GE4ZVL7rQFOMZIEse3RXeJ/sO5DKxOLoTxoo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=talatb@mellanox.com; Received: from dev-h-vrt-015.mth.labs.mlnx (193.47.165.251) by DB6PR0501MB2087.eurprd05.prod.outlook.com (2603:10a6:4:7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.11; Thu, 12 Apr 2018 06:43:13 +0000 From: Talat Batheesh To: kernel-team@lists.ubuntu.com Subject: [PATCH] [bionic] net/mlx5e: Fix int overflow Date: Thu, 12 Apr 2018 09:42:56 +0300 Message-Id: <1523515376-28554-1-git-send-email-talatb@mellanox.com> X-Mailer: git-send-email 2.7.5 MIME-Version: 1.0 X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: DB7PR08CA0026.eurprd08.prod.outlook.com (2603:10a6:5:16::39) To DB6PR0501MB2087.eurprd05.prod.outlook.com (2603:10a6:4:7::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2087; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2087; 3:jFTalzJzrTF9Kz32gqD3qas29wzzrZV5eBY+LTtxbmE4d3nYB0thIpbf+tNbggk7/FqK6PTAByU63iQNYYIovyqW9HVZNzE0sM9SZthYIj8QWwTGdZ3Rqd6d+UT/g3/WbroXblvFFMLEo/KmNAtNp/ju5tacIONxANH70cOW0EMNPvYAVevidrAoeCioiW7p/mBXjCUHe8YZOHBS/3M3wN/TLJxPTcGhmIcBeBFY6Y5UsxkgBfR/qP9GtUEUg9z8; 25:BDnfh1obDtGWNpr3NMVfSwHEcxdHR3MqOPKsG87g7iM2WFhNVZvNl4YhcP3t5+tVjw5bIJr1ds+dnaXbFadbCXBeT3w5cXUBiuX88XKH1EOIkCdoXiEx7NJ13nyTOeSidbQlNmvLl6oJaSaIZ++SY8P8pvQfbw8DOIUSyciQhAUVSrTSlO6ZTpnxJbozkFMF+lNjiB/4yQh28BIZew5QeMZZNBtQrX4PWiPLc1ZkpuxT3cWg9qHuKSXnvGSXA3u7XGQ0YoXskWC0jLC0bC/GT/9RfTHEbFuK9cYhnmnCbXn+0V+oHpfigvvs4CbIKQN9lcGHUkRaDppsMtgJakJbRQ==; 31:3We/qcdZSOD/IwJZvjLnsTrH7r2EeW0b4R1v8SaMpkBWx+B3XodAT/BDPMOachWCQ0Ai87xi4oJKkFm5ggUhru5+TL9Er3Sue4hN6Lbb7wM+fpehwHE93VdUVH7wZY11W+2dYEXYkfFSe4tiCaHw6P9UHGgYUOzyAIOw47gfLg0U9CPFvzzX+BKvMSFeizbgMPedPWLGf5L6DWsl2iws7mmq7kpztlt/IB2MINSif1k= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2087: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2087; 20:xXQizEEL2Zh+AlN+nyRKqmPiccXrzs4kqIH4tiWzZ2nP59+1mQAbKtqdPjBRzX4DoxgvqiZAdm897vRzWcRPNNMcWfG3W4zM5/F2UZj56eN6sPFbsevRTfUU0+xHS956pRZOrYZRbTvLzbo8Lg4Q3nUe7BL+o0ccpP2uxm+PAlXfVbeD6uKweubErZkpxjJDoTHIOn64EefwG1sP2dpP9JQXKFvbJPrAZjQNzB1g3BqUXGFAh/D74o6HeYh3jbf5NVKJXcQTKr5E9vbi1O8WfG/7bQ2RWZiK4HTG7dQG4/DN86HvlyHqls73l9aFoymZT2tW8wUnEPv/xlw2Uz/8qhGp/R/qP8oLqglT+PLIxclY4RlytHx/UW27NDvfRWsNemv8RaMkZnqQjhhH0a3iQ2eOH38ZmUKJ9segfo+ESfKEpk8KSurgDEL7tLvh6I+yWzRFiNfVOBYcGGMwYMykNXpa1t8NI+QGlvJ4wF4910+ql15VbQ4SeZ3wAD2HaZvD; 4:asWn5NhR9uaCWsw72tqtm7MNQLuKHRGpChPeZPsDVd0zTrqpRHImaqySY0Ew1hKFe4bw0GdTgQwBkOWDlQ7Q6Xo5f0ftcdKYunIsmf6rXm5IaU3GJ83R07lFX70PwMtccJecepjid5YCxfJern0kXe4Xg3YiRHRwQRycnMUFoCwpZULrKON4pjwFSWiZFictHx7D3ASkKhf0x94FbrHi7Pu2rarxKFzdTnZNGhEjtSOX4/oWM0BPxC3A9eg+QnBdP0T9sxedqZghPsG83DAFqLl8yqoRdNcaHm2aR05/h5UxVQdKZsw8WYWkJGuvQmGgPcdP/6cV9CvC7RKxk3AZv1JX4wMRT+VnIvYIMqoA5hY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211254476889703)(24339691489775); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR0501MB2087; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2087; X-Forefront-PRVS: 06400060E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(39860400002)(376002)(366004)(346002)(199004)(189003)(50466002)(1720100001)(5660300001)(68736007)(1857600001)(48376002)(956004)(106356001)(105586002)(107886003)(486006)(53936002)(6512007)(6306002)(305945005)(966005)(6486002)(2351001)(386003)(8936002)(6506007)(25786009)(6916009)(6666003)(16526019)(186003)(8676002)(81156014)(81166006)(2361001)(97736004)(59450400001)(316002)(86362001)(51416003)(478600001)(52116002)(47776003)(36756003)(16586007)(3846002)(6116002)(50226002)(4326008)(2616005)(26005)(66066001)(2906002)(476003)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2087; H:dev-h-vrt-015.mth.labs.mlnx; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2087; 23:20aU+BN3W6jzkyraW5PszOp+1SnOisWhB6di4D8?= bXYHClvp+7JjINX/fkS0Kso/iAXhz9mgdU4OTEbdK6RUROoqQJAWOP+Eny1NNRZgeJ4+kC9xXibKmIEC/T6epCLIb8lWY13ycKLiDwdSZ63Ph1cOwgkEtcOln7VWyu5kbxOxrz6tjaTNIp+tYDGLdulACGmITrDb9r1i9jH/M9lj3Ubg5R7E9CnIlQJhVJELSZ5XbAYn5DJqF+hw21yBU6ZWoQIDPsz3mH/PYZTQFg3ASYkSUozXOUSAb65ZnQC0zn5yJwFaJU0fAvczlJtPV8HQtolXyCevbjr2mp08ZqszYqmDPttJ34OC/jQWx+LiDcyBFn0QOz4FN4lxTnhhLTuT0KIF7127duoMMgyiO1jixdOUYtkWiSPqXUma73fJlRBRdBWs8QnHZE++tsaJmCxwwWIkfINxgTDqQ5rNPEOmdRfvVui9+Z1duz4sAKJS/C4zGXI60lA0NtRNbyms1Ijgvn1/kKv2ZOhPaHsnJRereudY22R+ArBQbPN2SRtpks+AGvXtgnACFmL7c1ilrTETdgkOIXcD+/6U9+6iMVjIaudQmJCBt6whkw4u/eAchRHpRIE7kBe8BHB/sx1MpyGUzwHlx6fC/sn4evFFZMsFBw5TUAcIxY3JXTErdnOcoA1kHvKIvJdN+a2UPm9+DC2nWDaLd5u1nbfHXX/Vzfh3m+G+R3wGF48Sf+AuM6/MEDO00yPw/lZIARKxYhiEPIT9zS138cpUm2N8whPampWcL6BV/DS7RpaDRN97x8amHI0yPV8Dm4Bwx2JaMEfsBgkPaN9CL/RfwvuVZLJMUDKLSOdut8diJFgWC033rIR+SJCvWTu+KtvL4cnDYogsQZDpV3S0IGuc74TSVAMLpo8YNG97ltEmLlib3x0OSQXA/OPLHkUX5x7lEDttMLrpzlYZ8xFYk32JSOUkHQO6v2DhXCk3E0q/jebJ/YdZ4JNUKMBz4rkKzRV62tlUac9gTeVzw/2yEmAmFjW9NzraGkIUzpGBh5cr0FoRT8+TZTDUYd0vmohsLGaOy2GWoik7k463ms1+9gj1egoOfUiIfGMdKyuN/9SmFq1HK48YHXiQhJUiDuV1+cuh3Gh2CtzKlUW8DOMZtCo8msWXwjQN5JA1QgL6EdFONsVP+79CFLx5Ro2Ij2I1XZXU4zYsfKp8uN7Q/mGGF6hpanECwJ3ZoVsRsRn98qfkJbL9Ye85o2Q2g4ZMnWdbd8XhrUqJpBrGUFlOwXrwrwO6ixSoDL9OjlkWqHQ== X-Microsoft-Antispam-Message-Info: BpfSent4HKFdKWGXy0gcoINLcsvv1AjhS9iwcZd7f4vaAqx9d3v63tCH+VyiZl6oCdSm+r3H/DBdxWZBxjfgTTqMvaJTKzb5P2rZJtRIH7wDsbefgt3xftUcANndPDy+ghSIful4VkzKTScWNxeKtoUE5axJYw/IXESFmvKRQaQFzUV+757RJbU/ojqAhQSA X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2087; 6:v8iCfcO/fkP8LCRIDkvt9yuOv7MeaFlGUf2xKRpA+Gzy/Qm+0PHTx24SzombynAFbJJrwaeJl0t1fLJJz9qEkT6NPtAKWTRsB939xR21mpF6TkTW9OJmYGxAkGhVoomG5+KkTCiyLy38T8sj7t6exaaqdiNEH3WIX65rGxUqg/P2ifPKsJTfa7CBHgL/zNQkchqDB0vLEtylNIrLPDRNJEYogJtxYfoxHMRBGLKgDJF0/QLrBZRxcfz2sGlRjlgZO8XpcyFH1nPd4Em+VJeoh9vI5bosj2OkqtdfO2BAIqKpnp8FGoKkcVoRb+yIqPMc3sfophixlbOZB3248wQ/SrGq6cgbBX7s4LsTmM0FiRkZNbt4YXyLD8JAL5phHzhl94//Wb55If5rVZibvKImDaK/9w5JnXtyBriTnPgKkB1nEB8TAv6isDi564ROH0zbKhf+xFJpvu4XpndL6k/QIw==; 5:vFK3viH+Mz3KqfjlU6XeYgbnTuohDz51JjXPprtU1krat+bbpN78pGooC/zIYHZxvkxd3Ux0VR8ELZqdOdBOesKMNEnZC4JYz4kZF/qk3KWLbdaRSXyTWOAF8U2W4jxxPPkh4bozfnLTSRtqCtdv9soZCxwbHiHhR8BS+dVvQpY=; 24:R/COxcGDkGdJnnsc4x6iopEk0trmsWtL1eamsqkyvqtd+1dixTW2PmtMTk3GJ9B4aA/C9qN1HCTdEMpnKVhhsUQacz1RhCCWYw9h5nOBYvU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2087; 7:PHUHMRj0W0QKNgJXJh00nUxDrZS7muORVB1rJJS1r2n6fzOt768NkjgpIEZWuNWTjiifPBYHoZ2/PW7UTIAP69BAkpqaGO4UmUIfpTowzJzHf6G8cz2QvfPDtLvBerKB/+5qFu6II75hk29zVVLqdGdz2kp0XcckGaV78HhUn+crjcELVr5E2zdoAzLjAf8PXG+LOCNXGwMlPuY/TOhbgRUYQanj4+UcM6ZcMiZVdBlrCjnfFJK5+3mExA7VKsL4 X-MS-Office365-Filtering-Correlation-Id: 614ac52e-3117-46aa-4434-08d5a040aa0d X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2018 06:43:13.0390 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 614ac52e-3117-46aa-4434-08d5a040aa0d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2087 X-Mailman-Approved-At: Thu, 12 Apr 2018 12:52:07 +0000 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: noas@mellanox.com, talg@mellanox.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: http://bugs.launchpad.net/bugs/1763269 When calculating difference between samples, the values are multiplied by 100. Large values may cause int overflow when multiplied (usually on first iteration). Fixed by forcing 100 to be of type unsigned long. This patch exist in upstream 4.16 under net_dim.h library. It need to be adjusted to the 4.15 kernel code location. Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux") Signed-off-by: Talat Batheesh --- drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c index b69a705..c362b93 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c @@ -188,7 +188,7 @@ static void mlx5e_am_exit_parking(struct mlx5e_rx_am *am) } #define IS_SIGNIFICANT_DIFF(val, ref) \ - (((100 * abs((val) - (ref))) / (ref)) > 10) /* more than 10% difference */ + (((100UL * abs((val) - (ref))) / (ref)) > 10) /* more than 10% difference */ static int mlx5e_am_stats_compare(struct mlx5e_rx_am_stats *curr, struct mlx5e_rx_am_stats *prev)