From patchwork Thu Mar 29 17:23:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Henrique Cerri X-Patchwork-Id: 892903 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 40Bs6X31jLz9s0m; Fri, 30 Mar 2018 04:23:48 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1f1bH6-0002Xp-El; Thu, 29 Mar 2018 17:23:44 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1f1bH3-0002X5-Ui for kernel-team@lists.ubuntu.com; Thu, 29 Mar 2018 17:23:41 +0000 Received: from mail-qt0-f197.google.com ([209.85.216.197]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1f1bH3-0000SJ-KK for kernel-team@lists.ubuntu.com; Thu, 29 Mar 2018 17:23:41 +0000 Received: by mail-qt0-f197.google.com with SMTP id t24so4423656qtn.21 for ; Thu, 29 Mar 2018 10:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=NutGJAOzTeNh2RmHTLX6rrV1b9+Wt/0FelghwF9/1GA=; b=EpsW2ZrN0juIY/rpYzKyzdYo9di+C+3EQeh1kvonQKolyjxgK9azQTd00a9zWELKNm T+22sEZ0FN8ZYfHKQja127PfYajyDC8EHJbvtuqr2t0JJ+91d+PqLnB8kTBmeYzC7j5K SjGDJ3h5SSeH+3LH6IYFb4bu10tjsDc+jZew1VNzdK5wUcHV4htfHQmftlqi8MVTtM+Z BHK4YP9Uq6ulXDALg8V3hZBphMmcDbpG1CmROZYs9gZ4VLdgh36SaFFF3LNAEELV4m83 Mpj7nsCMuFxV1AuYm+UonIFpkFZxB6hN9CctgvPoR+kjFQcF3lbqbu9O9s54wQLIeIRn R4FQ== X-Gm-Message-State: AElRT7GHC5Kw+cyc2AWEMKE8LitiegHbrs4I51s6s7gc5MA6Z2YmHj6P smlOLcVu1TLOhdLkmP0sB33Vi4bO5D/W6bz1fsd0a6KW77Zm2mPMwsT6Tp3zsClEh1PKSNQsZtm mTHkRFrRmJovocs9sItAQBHIRbPoZs3KGCjlka6i4 X-Received: by 10.55.23.101 with SMTP id i98mr12434306qkh.91.1522344220380; Thu, 29 Mar 2018 10:23:40 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+qZpDWPYdVow7jgjoW2fZ+rzeZaVyOhwJTjrLdS8lW5BuQ9znKUY7Y30vm3WXkJCyES/UcvQ== X-Received: by 10.55.23.101 with SMTP id i98mr12434287qkh.91.1522344220142; Thu, 29 Mar 2018 10:23:40 -0700 (PDT) Received: from localhost.localdomain ([191.255.48.253]) by smtp.gmail.com with ESMTPSA id p12sm5050815qkl.41.2018.03.29.10.23.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Mar 2018 10:23:39 -0700 (PDT) From: Marcelo Henrique Cerri To: kernel-team@lists.ubuntu.com Subject: [azure-edge:x][PATCH 1/2] hv_netvsc: fix filter flags Date: Thu, 29 Mar 2018 14:23:28 -0300 Message-Id: <1522344209-8022-2-git-send-email-marcelo.cerri@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522344209-8022-1-git-send-email-marcelo.cerri@canonical.com> References: <1522344209-8022-1-git-send-email-marcelo.cerri@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Stephen Hemminger BugLink: http://bugs.launchpad.net/bugs/1759885 The recent change to not always enable all multicast and broadcast was broken; meant to set filter, not change flags. Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast") Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller (cherry picked from commit de3d50aadd40bf68614db9fd157b275ce9c2d467) Signed-off-by: Marcelo Henrique Cerri --- drivers/net/hyperv/rndis_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 6b7f342ccdd1..c4bf28d5ba92 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -862,9 +862,9 @@ static void rndis_set_multicast(struct work_struct *w) filter = NDIS_PACKET_TYPE_PROMISCUOUS; } else { if (flags & IFF_ALLMULTI) - flags |= NDIS_PACKET_TYPE_ALL_MULTICAST; + filter |= NDIS_PACKET_TYPE_ALL_MULTICAST; if (flags & IFF_BROADCAST) - flags |= NDIS_PACKET_TYPE_BROADCAST; + filter |= NDIS_PACKET_TYPE_BROADCAST; } rndis_filter_set_packet_filter(rdev, filter);