diff mbox

dell-wmi: Add a WMI event code for display on/off

Message ID 1499323844-7254-2-git-send-email-alex.hung@canonical.com
State New
Headers show

Commit Message

Alex Hung July 6, 2017, 6:50 a.m. UTC 
Some new Dell AIO systems have a button that generates a WMI event to
turn the LCD on/off.

BugLink: http://bugs.launchpad.net/bugs/1702541

Signed-off-by: Alex Hung <alex.hung@canonical.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
(backported from commit ab9bb11ccbaa9e84be2534b677fe5350c2cc2014)
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/platform/x86/dell-wmi.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Colin Ian King July 6, 2017, 6:59 a.m. UTC | #1 
On 06/07/17 07:50, Alex Hung wrote:
> Some new Dell AIO systems have a button that generates a WMI event to
> turn the LCD on/off.
> 
> BugLink: http://bugs.launchpad.net/bugs/1702541
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> Acked-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> (backported from commit ab9bb11ccbaa9e84be2534b677fe5350c2cc2014)
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/platform/x86/dell-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index f2d77fe..88dd7b5 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -90,6 +90,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
>  	{ KE_IGNORE, 0xe025, { KEY_RESERVED } },
>  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
>  
> +	/* LCD Display On/Off Control key */
> +	{ KE_KEY,    0xe027, { KEY_DISPLAYTOGGLE } },
> +
>  	{ KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
>  	{ KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
>  	{ KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
> 

Limited to Dell WMI devices with WMI magic code 0xe027. Looks good to me.

Acked-by: Colin Ian King <colin.king@canonical.com>
AceLan Kao July 10, 2017, 7:47 a.m. UTC | #2
diff mbox

Patch

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index f2d77fe..88dd7b5 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -90,6 +90,9 @@  static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
 	{ KE_IGNORE, 0xe025, { KEY_RESERVED } },
 	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
 
+	/* LCD Display On/Off Control key */
+	{ KE_KEY,    0xe027, { KEY_DISPLAYTOGGLE } },
+
 	{ KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
 	{ KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
 	{ KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },