From patchwork Wed Aug 24 21:29:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 662571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3sKL7d36vMz9sXx; Thu, 25 Aug 2016 07:30:21 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical-com.20150623.gappssmtp.com header.i=@canonical-com.20150623.gappssmtp.com header.b=UZFlqzzS; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bcfkY-0007la-5m; Wed, 24 Aug 2016 21:30:18 +0000 Received: from mail-it0-f44.google.com ([209.85.214.44]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1bcfkA-0007aE-2s for kernel-team@lists.ubuntu.com; Wed, 24 Aug 2016 21:29:54 +0000 Received: by mail-it0-f44.google.com with SMTP id x131so235960159ite.0 for ; Wed, 24 Aug 2016 14:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=xTpl+q2LEFw1A6+QLeN7DwXf6NWoCMfsyQdjtR8dbMU=; b=UZFlqzzSqdadoVHn8HdzB7QVm8DJbwlY3RUFu0i7BSKNgLZPEj3mmoxOl3bnQsxif9 oWgODoaSMqpnVzxV9nTzNUni6ARqsvTga2u3lWy5CdZo5rl7vblxHVfAQOQhwbTHBN7G XV3UFQgAeYhB14Bm8fkAZuShwyLc8KG+pu+OmFpIK1uceuK8ysTviCaWwuAqcGvOLst3 ckDNbKX0FaLIOBuKgxfUmcc35P0S92QNHfK4VSGLal53vX/mpDtsF3crqkY4jzldUPT1 9Y2WFTODRqNkISh6aSIVdZTYvZghHqhNoGd9raIjsr2N6l/RUcSQ5cY+JWjUcSk8LTzQ 9erw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=xTpl+q2LEFw1A6+QLeN7DwXf6NWoCMfsyQdjtR8dbMU=; b=LXpOj2O7FClmYKty/4S6w6IjooU6R/dsbxvv/niojdb+6b0NZBk0I7/RBPT7bP0h2H BkXnnPIngeVO5sSoAW0JPhpP5QPIM2ShQYRpnpD6Uwi6wMq5Kc+RFI9Y6LbvfWhRxw+r OtfFaINGecPHh9A+14LNNHUnO2KCvePgimNrFp4Xs69F8yApOg5EUjKL76eh3Qqmf5Fx 9lfAbgG2XWehAlOE14wzaUpllsWYLPFRFOo0L8PS5PBfhZWhYZ0qRp9bvS4/fPpfwcsY BVI/kXXXT6b8SgN43rcQkjxHe20pPePUJtRo1yVZYcObvCoG6tamim4O3Ev59aXFfdqQ dYOA== X-Gm-Message-State: AEkoouu2TKorwc/Qtp7pETvBQiMxxdFHOm356D28zfi0HRyKCQwSfpSNC2VHUBxscDsj0Imi X-Received: by 10.107.18.154 with SMTP id 26mr6262953ios.85.1472074192851; Wed, 24 Aug 2016 14:29:52 -0700 (PDT) Received: from gbyte.rtg.local (host-174-45-44-32.hln-mt.client.bresnan.net. [174.45.44.32]) by smtp.gmail.com with ESMTPSA id o5sm12370305ith.20.2016.08.24.14.29.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Aug 2016 14:29:52 -0700 (PDT) From: Tim Gardner To: kernel-team@lists.ubuntu.com Subject: [PATCH 03/16] intel_idle: Remove redundant initialization calls. Date: Wed, 24 Aug 2016 15:29:33 -0600 Message-Id: <1472074186-21406-4-git-send-email-tim.gardner@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1472074186-21406-1-git-send-email-tim.gardner@canonical.com> References: <1472074186-21406-1-git-send-email-tim.gardner@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Richard Cochran BugLink: http://bugs.launchpad.net/bugs/1591821 The function, intel_idle_cpuidle_driver_init, makes calls on each CPU to auto_demotion_disable() and c1e_promotion_disable(). These calls are redundant, as intel_idle_cpu_init() does the same calls just a bit later on. They are also premature, as the driver registration may yet fail. This patch removes the redundant code. Signed-off-by: Richard Cochran Signed-off-by: Len Brown Signed-off-by: Rafael J. Wysocki (cherry picked from commit 4a3dfb3fc0fb0fc9acd36c94b7145f9c9dd4d93a) Signed-off-by: Tim Gardner --- drivers/idle/intel_idle.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index dfa9055..cb85c4c 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -1163,16 +1163,10 @@ static void __init intel_idle_cpuidle_driver_init(void) drv->state_count += 1; } - if (icpu->auto_demotion_disable_flags) - on_each_cpu(auto_demotion_disable, NULL, 1); - if (icpu->byt_auto_demotion_disable_flag) { wrmsrl(MSR_CC6_DEMOTION_POLICY_CONFIG, 0); wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0); } - - if (icpu->disable_promotion_to_c1e) /* each-cpu is redundant */ - on_each_cpu(c1e_promotion_disable, NULL, 1); }