diff mbox

[X/Y,SRU] block: atari: Return early for unsupported sector size

Message ID 1469198716-31393-1-git-send-email-tim.gardner@canonical.com
State New
Headers show

Commit Message

Tim Gardner July 22, 2016, 2:45 p.m. UTC 
From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>

BugLink: http://bugs.launchpad.net/bugs/1604995

For 4K LBA or very large disks, atari_partition can easily get tricked
into thinking it has found an Atari partition table.  Depending on the
data in the disk, it ends up creating partitions with awkward lengths.

We saw logs like this while playing with fio.

[5.625867] nvme2n1: AHDI p2
[5.625872] nvme2n1: p2 size 2910030523 extends beyond EOD, truncated

People has had issues with misinterpreted AHDI partition tables for a long
time, see this BSD thread from 1995, for example.

https://mail-index.netbsd.org/port-atari/1995/11/19/0001.html

Since the atari partition, according to the spec, doesn't even support
sector sizes with more than 512, a quick sanity check is reasonable to
just bail out early, before even attempting to read sector 0.

Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
(cherry picked from linux-next commit 9c8747167e204b3fe0ff143e1642c921e382e1d6)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 block/partitions/atari.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Kamal Mostafa July 25, 2016, 4:36 p.m. UTC | #1
Brad Figg July 27, 2016, 11:46 a.m. UTC | #2
Kamal Mostafa July 27, 2016, 5:07 p.m. UTC | #3 
Applied to X.

 -Kamal
diff mbox

Patch

diff --git a/block/partitions/atari.c b/block/partitions/atari.c
index 9875b05..ff1fb93 100644
--- a/block/partitions/atari.c
+++ b/block/partitions/atari.c
@@ -42,6 +42,13 @@  int atari_partition(struct parsed_partitions *state)
 	int part_fmt = 0; /* 0:unknown, 1:AHDI, 2:ICD/Supra */
 #endif
 
+	/*
+	 * ATARI partition scheme supports 512 lba only.  If this is not
+	 * the case, bail early to avoid miscalculating hd_size.
+	 */
+	if (bdev_logical_block_size(state->bdev) != 512)
+		return 0;
+
 	rs = read_part_sector(state, 0, &sect);
 	if (!rs)
 		return -1;