From patchwork Tue Jul 19 14:55:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris J Arges X-Patchwork-Id: 650250 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3rv3585nYmz9t2L; Wed, 20 Jul 2016 00:55:56 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bPWR7-0006MW-KI; Tue, 19 Jul 2016 14:55:53 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bPWR1-0006K3-Se for kernel-team@lists.ubuntu.com; Tue, 19 Jul 2016 14:55:47 +0000 Received: from cpe-70-112-162-223.austin.res.rr.com ([70.112.162.223] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1bPWR1-0004t1-6H for kernel-team@lists.ubuntu.com; Tue, 19 Jul 2016 14:55:47 +0000 From: Chris J Arges To: kernel-team@lists.ubuntu.com Subject: [xenial][SRU][PATCH 2/3] HID: wacom: Initialize hid_data.inputmode to -1 Date: Tue, 19 Jul 2016 09:55:43 -0500 Message-Id: <1468940144-30237-3-git-send-email-chris.j.arges@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468940144-30237-1-git-send-email-chris.j.arges@canonical.com> References: <1468940144-30237-1-git-send-email-chris.j.arges@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Jason Gerecke Commit 5ae6e89 introduced hid_data.inputmode with a comment that it would have the value -1 if undefined, but then forgot to actually perform the initialization. Although this doesn't appear to have caused any problems in practice, it should still be remedied. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires Signed-off-by: Jiri Kosina (cherry picked from commit c6fa1aeba02111ed8676494ac7cd453a03efef3c) Signed-off-by: Chris J Arges --- drivers/hid/wacom_sys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 2275e88..718a1ba 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -1844,6 +1844,8 @@ static int wacom_probe(struct hid_device *hdev, goto fail_type; } + wacom_wac->hid_data.inputmode = -1; + wacom->usbdev = dev; wacom->intf = intf; mutex_init(&wacom->lock);