diff mbox

[Xenial,SRU,media] tda10071: Fix dependency to REGMAP_I2C

Message ID 1466425332-6020-1-git-send-email-tim.gardner@canonical.com
State New
Headers show

Commit Message

Tim Gardner June 20, 2016, 12:22 p.m. UTC
From: Matthias Schwarzott <zzam@gentoo.org>

BugLink: http://bugs.launchpad.net/bugs/1592531

Without I get this error for by dvb-card:
  tda10071: Unknown symbol devm_regmap_init_i2c (err 0)
  cx23885_dvb_register() dvb_register failed err = -22
  cx23885_dev_setup() Failed to register dvb adapters on VID_B

Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
(cherry picked from commit b046d3ad38d90276379c862f15ddd99fa8739906)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/media/dvb-frontends/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kamal Mostafa June 22, 2016, 5:04 p.m. UTC | #1

Andy Whitcroft June 22, 2016, 6:31 p.m. UTC | #2
On Mon, Jun 20, 2016 at 06:22:12AM -0600, Tim Gardner wrote:
> From: Matthias Schwarzott <zzam@gentoo.org>
> 
> BugLink: http://bugs.launchpad.net/bugs/1592531
> 
> Without I get this error for by dvb-card:
>   tda10071: Unknown symbol devm_regmap_init_i2c (err 0)
>   cx23885_dvb_register() dvb_register failed err = -22
>   cx23885_dev_setup() Failed to register dvb adapters on VID_B
> 
> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> Reviewed-by: Antti Palosaari <crope@iki.fi>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> (cherry picked from commit b046d3ad38d90276379c862f15ddd99fa8739906)
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  drivers/media/dvb-frontends/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig
> index 292c947..310e4b8 100644
> --- a/drivers/media/dvb-frontends/Kconfig
> +++ b/drivers/media/dvb-frontends/Kconfig
> @@ -264,7 +264,7 @@ config DVB_MB86A16
>  config DVB_TDA10071
>  	tristate "NXP TDA10071"
>  	depends on DVB_CORE && I2C
> -	select REGMAP
> +	select REGMAP_I2C
>  	default m if !MEDIA_SUBDRV_AUTOSELECT
>  	help
>  	  Say Y when you want to support this frontend.

Looks sensible, and I assume is eminantly testable.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Kamal Mostafa June 22, 2016, 6:51 p.m. UTC | #3
Applied to X.

 -Kamal
diff mbox

Patch

diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig
index 292c947..310e4b8 100644
--- a/drivers/media/dvb-frontends/Kconfig
+++ b/drivers/media/dvb-frontends/Kconfig
@@ -264,7 +264,7 @@  config DVB_MB86A16
 config DVB_TDA10071
 	tristate "NXP TDA10071"
 	depends on DVB_CORE && I2C
-	select REGMAP
+	select REGMAP_I2C
 	default m if !MEDIA_SUBDRV_AUTOSELECT
 	help
 	  Say Y when you want to support this frontend.