diff mbox

[P,T,U,V,W] UBUNTU: [debian] BugLink: close LP: bugs only for Launchpad urls

Message ID 1459541867-11419-1-git-send-email-kamal@canonical.com
State New
Headers show

Commit Message

Kamal Mostafa April 1, 2016, 8:17 p.m. UTC
Generate "LP: #NNNNNNN" bug-close changelog comments only for BugLink's
which actually refer to Launchpad URL's, not other bug trackers.

Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
 debian/scripts/misc/git-ubuntu-log | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kamal Mostafa April 1, 2016, 8:20 p.m. UTC | #1
Note that Xenial doesn't need this patch because its git-ubuntu-log
(recently rewritten) already only scans for Launchpad URL's.

On Fri, Apr 01, 2016 at 01:17:47PM -0700, Kamal Mostafa wrote:
> Generate "LP: #NNNNNNN" bug-close changelog comments only for BugLink's
> which actually refer to Launchpad URL's, not other bug trackers.
> 
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> ---
>  debian/scripts/misc/git-ubuntu-log | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Stefan Bader April 4, 2016, 9:09 a.m. UTC | #2
On 01.04.2016 22:17, Kamal Mostafa wrote:
> Generate "LP: #NNNNNNN" bug-close changelog comments only for BugLink's
> which actually refer to Launchpad URL's, not other bug trackers.
> 
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> ---
>  debian/scripts/misc/git-ubuntu-log | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/scripts/misc/git-ubuntu-log b/debian/scripts/misc/git-ubuntu-log
> index 2967d87..3937216 100755
> --- a/debian/scripts/misc/git-ubuntu-log
> +++ b/debian/scripts/misc/git-ubuntu-log
> @@ -194,7 +194,7 @@ sub changelog_input {
>  						$bugz{$k} = 1 if (($k ne '') and ($k =~ /[0-9]+/));
>  					}
>  				}
> -				elsif (/^ *BugLink: *http.*:\/\/.*\/([0-9]+)/i) {
> +				elsif (/^ *BugLink: *.*launchpad.net\/.*\/([0-9]+)/i) {

Sounds reasonable... may or may not be "\.launchpad\.net" to ensure real dots at
the right places...

>  					$bugz{$1} = 1;
>  				}
>  				elsif (/^ *(CVE-.*)/) {
>
diff mbox

Patch

diff --git a/debian/scripts/misc/git-ubuntu-log b/debian/scripts/misc/git-ubuntu-log
index 2967d87..3937216 100755
--- a/debian/scripts/misc/git-ubuntu-log
+++ b/debian/scripts/misc/git-ubuntu-log
@@ -194,7 +194,7 @@  sub changelog_input {
 						$bugz{$k} = 1 if (($k ne '') and ($k =~ /[0-9]+/));
 					}
 				}
-				elsif (/^ *BugLink: *http.*:\/\/.*\/([0-9]+)/i) {
+				elsif (/^ *BugLink: *.*launchpad.net\/.*\/([0-9]+)/i) {
 					$bugz{$1} = 1;
 				}
 				elsif (/^ *(CVE-.*)/) {