Message ID | 1455589902-3889-1-git-send-email-tim.gardner@canonical.com |
---|---|
State | New |
Headers | show |
On 16.02.2016 03:31, tim.gardner@canonical.com wrote: > From: Tim Gardner <tim.gardner@canonical.com> I'd ACK if we could at least copy some of wgrant's nice explanation into the commit message... probably using something like the bug title as patch subject also would help to understand why those other 3 options get set... -Stefan > > BugLink: http://bugs.launchpad.net/bugs/1545542 > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > debian.master/config/config.common.ubuntu | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu > index 9f7e659..cc330a5 100644 > --- a/debian.master/config/config.common.ubuntu > +++ b/debian.master/config/config.common.ubuntu > @@ -466,7 +466,7 @@ CONFIG_ARMADA_38X_CLK=y > CONFIG_ARMADA_39X_CLK=y > CONFIG_ARMADA_THERMAL=y > CONFIG_ARMADA_XP_CLK=y > -# CONFIG_ARMV8_DEPRECATED is not set > +CONFIG_ARMV8_DEPRECATED=y > CONFIG_ARM_AMBA=y > CONFIG_ARM_APPENDED_DTB=y > CONFIG_ARM_ARCH_TIMER=y > @@ -1385,6 +1385,7 @@ CONFIG_CORENET_GENERIC=y > # CONFIG_CORESIGHT is not set > CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y > CONFIG_COSA=m > +CONFIG_CP15_BARRIER_EMULATION=y > # CONFIG_CPA_DEBUG is not set > CONFIG_CPM=y > CONFIG_CPM2=y > @@ -6875,6 +6876,7 @@ CONFIG_SERIO_PS2MULT=m > CONFIG_SERIO_RAW=m > CONFIG_SERIO_SERPORT=m > CONFIG_SERIO_XILINX_XPS_PS2=m > +CONFIG_SETEND_EMULATION=y > CONFIG_SFC=m > CONFIG_SFC_MCDI_LOGGING=y > CONFIG_SFC_MCDI_MON=y > @@ -7558,6 +7560,7 @@ CONFIG_SWAP=y > CONFIG_SWIOTLB=y > CONFIG_SWIOTLB_XEN=y > CONFIG_SWP_EMULATE=y > +CONFIG_SWP_EMULATION=y > CONFIG_SX9500=m > CONFIG_SXGBE_ETH=m > CONFIG_SYNCLINK=m >
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 02/16/2016 02:01 AM, Stefan Bader wrote: > On 16.02.2016 03:31, tim.gardner@canonical.com wrote: >> From: Tim Gardner <tim.gardner@canonical.com> > > I'd ACK if we could at least copy some of wgrant's nice explanation > into the commit message... probably using something like the bug > title as patch subject also would help to understand why those > other 3 options get set... > > -Stefan > Isn't that what the bug link is for ? Seems like duplication otherwise. - -- Tim Gardner tim.gardner@canonical.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWwxGlAAoJED12yEX6FEfKJJEP/1+kB2xXHE5dWZraKhwhPML7 9qSj6wYIsxVKo5DO5sUu8OttZTdjXs6TGv3ZAttaz829CDjPXPs4rBSmoJIrOyxG 9OFMeuX4D7JP0rcYM3zHVkCm2K5kLcZN+hvBGfOkE0YuVlL9JoAY34tm25wPhQge 4gBLj9XrjfeZkNqQd4lMjjRLBnyy+tG/H1JU5UUy8/7uN4Z3vtD7DeQTFoojsqOd OI+qK20ZRAE2k+PtK/PPREYd89xGQ8TWaBXw9ZwUL9xSryYx2/eLgaQm3NHRYL3X 19g+I6t0PXc+vzjyhXd+klnmYndod3AGRH2qHnRqZPvP5GysBGP5MIz1mRD1dk8n aEItsM/VU/Wq7E4CKxRpu4cFoEXel49CwU0yIvxgiVjQrUoI1CQ2NxcqEH09MrVF 70sIMqw4MiVPCfO3YKUhihNjDqJZVfTlF88gYDYz8BVSAMruj5LePf21COzw3mSy 2Q2mv4xXR9UegjFU1IUgqJgK9YllRlShzcVTKJiROVbQqfA0y//7MBSveMT8HM4H 9S6kIQzpect2zXHvj7zFTosOm6B046gVMWKJUqnWOj356QM9fbv2MCsFd5JBD0U4 Dvtc0Q6KhfT+Ba9J79yDHJl/D2H+FWBbXXF4xvP7YqHPdA4tcSC1MSImNgu8JdE4 ZM9T/fPRHctA/mDNOomU =K0T7 -----END PGP SIGNATURE-----
On 16.02.2016 13:10, Tim Gardner wrote: > On 02/16/2016 02:01 AM, Stefan Bader wrote: >> On 16.02.2016 03:31, tim.gardner@canonical.com wrote: >>> From: Tim Gardner <tim.gardner@canonical.com> > >> I'd ACK if we could at least copy some of wgrant's nice explanation >> into the commit message... probably using something like the bug >> title as patch subject also would help to understand why those >> other 3 options get set... > >> -Stefan > > > Isn't that what the bug link is for ? Seems like duplication otherwise. Just a personal preference to have at least as much info in a git commit to understand it without needing to resort to some external source of information. This case is probably even worse to my standards because I would understand an option named ARMV8_DEPRECATED completely contrary to what it seems to do (not deprecating armv8 but enabling to pick software emulation for certain instructions which were deprecated with armv8).
Applied to the master-next branch of Wily.
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu index 9f7e659..cc330a5 100644 --- a/debian.master/config/config.common.ubuntu +++ b/debian.master/config/config.common.ubuntu @@ -466,7 +466,7 @@ CONFIG_ARMADA_38X_CLK=y CONFIG_ARMADA_39X_CLK=y CONFIG_ARMADA_THERMAL=y CONFIG_ARMADA_XP_CLK=y -# CONFIG_ARMV8_DEPRECATED is not set +CONFIG_ARMV8_DEPRECATED=y CONFIG_ARM_AMBA=y CONFIG_ARM_APPENDED_DTB=y CONFIG_ARM_ARCH_TIMER=y @@ -1385,6 +1385,7 @@ CONFIG_CORENET_GENERIC=y # CONFIG_CORESIGHT is not set CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y CONFIG_COSA=m +CONFIG_CP15_BARRIER_EMULATION=y # CONFIG_CPA_DEBUG is not set CONFIG_CPM=y CONFIG_CPM2=y @@ -6875,6 +6876,7 @@ CONFIG_SERIO_PS2MULT=m CONFIG_SERIO_RAW=m CONFIG_SERIO_SERPORT=m CONFIG_SERIO_XILINX_XPS_PS2=m +CONFIG_SETEND_EMULATION=y CONFIG_SFC=m CONFIG_SFC_MCDI_LOGGING=y CONFIG_SFC_MCDI_MON=y @@ -7558,6 +7560,7 @@ CONFIG_SWAP=y CONFIG_SWIOTLB=y CONFIG_SWIOTLB_XEN=y CONFIG_SWP_EMULATE=y +CONFIG_SWP_EMULATION=y CONFIG_SX9500=m CONFIG_SXGBE_ETH=m CONFIG_SYNCLINK=m