From patchwork Thu Nov 20 17:01:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 412797 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id D5A6414017B; Fri, 21 Nov 2014 04:03:08 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1XrV8L-0002XC-9e; Thu, 20 Nov 2014 17:03:05 +0000 Received: from mail-ob0-f176.google.com ([209.85.214.176]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1XrV7Z-0002E0-8u for kernel-team@lists.ubuntu.com; Thu, 20 Nov 2014 17:02:17 +0000 Received: by mail-ob0-f176.google.com with SMTP id vb8so2541540obc.35 for ; Thu, 20 Nov 2014 09:02:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=7P4v0pZ4OLF6ysTdtALphQysf3okOAC25Uft3cboj8M=; b=FTKMUbMl62kRpPCcChw09xSNMv5IyWlPFo8GPne4yuZa5MjUH+BtmebXsLEaAsmofw O6hdXIo/cuQoz5yb8gs7oUrrXL+2+NkdnCcT1QK0NUb7M2eHfTXlX+2RptqlPRRP2IT8 XhvpDDcC2mWFio8xABbuIy2YAqBYMQgLy2mV0QV+kRul8JleXQecXMAo4K/hpRvVCvXi 2BFQablc3JUZlJnsXqzIvnoVtOWrsX67NXUE7jpL9/gMZuzXhz0usQuoIP2NMiWJtIwn 7T8KPcOZgNaI440MxIAzejVM1sHWTwBuRmG5YifDgJxQ+3TWRBRw7k5oDPiVu4ordR83 pRxg== X-Gm-Message-State: ALoCoQndKDb3nzck3RSnypMWUXuakr8+0FAPsb9DZvKyu2qmu0a8EMMgrWiVCTXaFk1u1dtmQnDm X-Received: by 10.202.221.132 with SMTP id u126mr1608998oig.76.1416502936809; Thu, 20 Nov 2014 09:02:16 -0800 (PST) Received: from localhost.localdomain (rrcs-67-79-14-250.sw.biz.rr.com. [67.79.14.250]) by mx.google.com with ESMTPSA id w81sm1088156oiw.10.2014.11.20.09.02.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Nov 2014 09:02:16 -0800 (PST) From: tim.gardner@canonical.com To: kernel-team@lists.ubuntu.com Subject: [PATCH 06/13] arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files Date: Thu, 20 Nov 2014 11:01:50 -0600 Message-Id: <1416502917-15820-7-git-send-email-tim.gardner@canonical.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1416502917-15820-1-git-send-email-tim.gardner@canonical.com> References: <1416502917-15820-1-git-send-email-tim.gardner@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Rusty Russell BugLink: http://bugs.launchpad.net/bugs/1391953 If you don't have a store function, you're not writable anyway! Signed-off-by: Rusty Russell Signed-off-by: Tim Gardner --- arch/powerpc/platforms/powernv/opal-dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c index 79b44d2..23260f7 100644 --- a/arch/powerpc/platforms/powernv/opal-dump.c +++ b/arch/powerpc/platforms/powernv/opal-dump.c @@ -102,9 +102,9 @@ static ssize_t dump_ack_store(struct dump_obj *dump_obj, * due to the dynamic size of the dump */ static struct dump_attribute id_attribute = - __ATTR(id, 0666, dump_id_show, NULL); + __ATTR(id, S_IRUGO, dump_id_show, NULL); static struct dump_attribute type_attribute = - __ATTR(type, 0666, dump_type_show, NULL); + __ATTR(type, S_IRUGO, dump_type_show, NULL); static struct dump_attribute ack_attribute = __ATTR(acknowledge, 0660, dump_ack_show, dump_ack_store);