diff mbox

[v2,trusty] SAUCE: Add use native backlight quirk for Dell Inspiron 5547/5447

Message ID 1404973258-2679-1-git-send-email-yidi.lin@canonical.com
State New
Headers show

Commit Message

Edward Lin July 10, 2014, 6:20 a.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1332437

The ACPI backlight control is broken on these 2 models.
Since backlight control works on 3.16.0-999-generic #201406200205,
and also works on 3.13.0-29 with video.use_native_backlight=1.
Add use native backlight quirk for these 2 models as the workaround.

This patch can be ignored after 3.16-r2.

Changes v1 -> v2:
  - exclude Dell Inspiron 5737 from quirk

Signed-off-by: Edward Lin <yidi.lin@canonical.com>
---
 drivers/acpi/video.c |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Brad Figg July 10, 2014, 7:50 a.m. UTC | #1
On 07/10/2014 07:20 AM, Edward Lin wrote:
> BugLink: http://bugs.launchpad.net/bugs/1332437
> 
> The ACPI backlight control is broken on these 2 models.
> Since backlight control works on 3.16.0-999-generic #201406200205,
> and also works on 3.13.0-29 with video.use_native_backlight=1.
> Add use native backlight quirk for these 2 models as the workaround.
> 
> This patch can be ignored after 3.16-r2.
> 
> Changes v1 -> v2:
>   - exclude Dell Inspiron 5737 from quirk
> 
> Signed-off-by: Edward Lin <yidi.lin@canonical.com>
> ---
>  drivers/acpi/video.c |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 5b6f970..ffdd2c6 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -500,6 +500,22 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  	},
>  	{
>  	 .callback = video_set_use_native_backlight,
> +	 .ident = "Dell Inspiron 5547",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5547"),
> +		},
> +	},
> +	{
> +	 .callback = video_set_use_native_backlight,
> +	 .ident = "Dell Inspiron 5447",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5447"),
> +		},
> +	},
> +	{
> +	 .callback = video_set_use_native_backlight,
>  	 .ident = "Acer Aspire 5733Z",
>  	 .matches = {
>  		DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
>
Tim Gardner July 10, 2014, 9:56 a.m. UTC | #2

diff mbox

Patch

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 5b6f970..ffdd2c6 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -500,6 +500,22 @@  static struct dmi_system_id video_dmi_table[] __initdata = {
 	},
 	{
 	 .callback = video_set_use_native_backlight,
+	 .ident = "Dell Inspiron 5547",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5547"),
+		},
+	},
+	{
+	 .callback = video_set_use_native_backlight,
+	 .ident = "Dell Inspiron 5447",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5447"),
+		},
+	},
+	{
+	 .callback = video_set_use_native_backlight,
 	 .ident = "Acer Aspire 5733Z",
 	 .matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "Acer"),