| Message ID | 1362982360-13760-1-git-send-email-adam.lee@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 11.03.2013 07:12, Adam Lee wrote: > BugLink: https://launchpad.net/bugs/1153448 > > These devices require external patchram firmware to work. > > T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=04ca ProdID=2007 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM43142A0 > S: SerialNumber=20689DD16A22 > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > > Signed-off-by: Adam Lee <adam.lee@canonical.com> > Signed-off-by: Bruce Ma <bruce.ma@canonical.com> > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) > Where does this patch come from? I tried to find it upstream and in linux-next but could not find it. Since this is for Quantal, there should be a bit more information. Like why only Quantal? Has the patch sent upstream? What is the status? Looking at the patch it is simple, has little chance of regression and so is something suitable for SRU, but for a SRU you should explain a bit more as I as a reviewer do not have more information than is in the email or the bug report. My main concern would be upstreaming because that way a patch cannot get lost (or via upstream stable may get into more releases than just the one the SRU is for). There could be a good reason why this doe not apply here but just from looking at the patch I do not know. ;) -Stefan
2013/3/11 Stefan Bader <stefan.bader@canonical.com>: > On 11.03.2013 07:12, Adam Lee wrote: >> BugLink: https://launchpad.net/bugs/1153448 >> >> These devices require external patchram firmware to work. >> >> T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=04ca ProdID=2007 Rev=01.12 >> S: Manufacturer=Broadcom Corp >> S: Product=BCM43142A0 >> S: SerialNumber=20689DD16A22 >> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) >> >> Signed-off-by: Adam Lee <adam.lee@canonical.com> >> Signed-off-by: Bruce Ma <bruce.ma@canonical.com> >> --- >> drivers/bluetooth/btusb.c | 1 + >> 1 file changed, 1 insertion(+) >> > > Where does this patch come from? I tried to find it upstream and in linux-next > but could not find it. > Since this is for Quantal, there should be a bit more information. Like why only > Quantal? Has the patch sent upstream? What is the status? > Looking at the patch it is simple, has little chance of regression and so is > something suitable for SRU, but for a SRU you should explain a bit more as I as > a reviewer do not have more information than is in the email or the bug report. > My main concern would be upstreaming because that way a patch cannot get lost > (or via upstream stable may get into more releases than just the one the SRU is > for). There could be a good reason why this doe not apply here but just from > looking at the patch I do not know. ;) Hi Stefan, This patch would not be accepted by upstream since it depends on the patchram stuff which is a SAUCE in ubuntu kernel. The discussions about this patchram interim solution can be found at https://launchpad.net/bugs/1065400 Thanks, Jesse
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 6cd5874..6420245 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -110,6 +110,7 @@ static struct usb_device_id btusb_table[] = { { USB_DEVICE(0x0b05, 0x17b5) }, { USB_DEVICE(0x04ca, 0x2003) }, { USB_DEVICE(0x0489, 0xe042) }, + { USB_DEVICE(0x04ca, 0x2007), .driver_info = BTUSB_BCM_PATCHRAM }, { USB_DEVICE(0x13d3, 0x3388), .driver_info = BTUSB_BCM_PATCHRAM }, { USB_DEVICE(0x13d3, 0x3389), .driver_info = BTUSB_BCM_PATCHRAM }, { USB_DEVICE(0x413c, 0x8197), .driver_info = BTUSB_BCM_PATCHRAM },