| Message ID | 1314124714-4854-1-git-send-email-seth.forshee@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 08/23/2011 12:38 PM, Seth Forshee wrote: > BugLink: https://bugs.launcpad.net/bugs/828550 > > According to Chris Wilson this BUG_ON was just paranoia and never > something the kernel should explode on. He later removed it in > upstream commit e39a01501b228e1be2037d5bddccae2a820af902. So let's > just remove it. > > Signed-off-by: Seth Forshee<seth.forshee@canonical.com> > --- > drivers/gpu/drm/i915/i915_gem_evict.c | 7 ------- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_evict.c b/drivers/gpu/drm/i915/i915_gem_evict.c > index 9c1ec78..c4c6b6f 100644 > --- a/drivers/gpu/drm/i915/i915_gem_evict.c > +++ b/drivers/gpu/drm/i915/i915_gem_evict.c > @@ -175,13 +175,6 @@ found: > list_del_init(&obj_priv->evict_list); > } > > - /* The just created free hole should be on the top of the free stack > - * maintained by drm_mm, so this BUG_ON actually executes in O(1). > - * Furthermore all accessed data has just recently been used, so it > - * should be really fast, too. */ > - BUG_ON(!drm_mm_search_free(&dev_priv->mm.gtt_space, min_size, > - alignment, 0)); > - > return 0; > } > Fix the BugLink. Acked-by: Tim Gardner <tim.gardner@canonical.com>
diff --git a/drivers/gpu/drm/i915/i915_gem_evict.c b/drivers/gpu/drm/i915/i915_gem_evict.c index 9c1ec78..c4c6b6f 100644 --- a/drivers/gpu/drm/i915/i915_gem_evict.c +++ b/drivers/gpu/drm/i915/i915_gem_evict.c @@ -175,13 +175,6 @@ found: list_del_init(&obj_priv->evict_list); } - /* The just created free hole should be on the top of the free stack - * maintained by drm_mm, so this BUG_ON actually executes in O(1). - * Furthermore all accessed data has just recently been used, so it - * should be really fast, too. */ - BUG_ON(!drm_mm_search_free(&dev_priv->mm.gtt_space, min_size, - alignment, 0)); - return 0; }
BugLink: https://bugs.launcpad.net/bugs/828550 According to Chris Wilson this BUG_ON was just paranoia and never something the kernel should explode on. He later removed it in upstream commit e39a01501b228e1be2037d5bddccae2a820af902. So let's just remove it. Signed-off-by: Seth Forshee <seth.forshee@canonical.com> --- drivers/gpu/drm/i915/i915_gem_evict.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)