| Message ID | 1285439199-7352-2-git-send-email-eballetbo@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Leann Ogasawara |
| Headers | show |
SRU Justification: Impact: GPIO for various devices are missing from the board initialization. This patch adds support for the VBUS and over current gpios. Without this patch, input/outputs from these two sources are ignored. BugLink: https://bugs.launchpad.net/bugs/651589 On Sat, 2010-09-25 at 20:26 +0200, Enric Balletbo i Serra wrote: > Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com> > --- > arch/arm/mach-omap2/board-igep0020.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c > index 175f043..1052a63 100644 > --- a/arch/arm/mach-omap2/board-igep0020.c > +++ b/arch/arm/mach-omap2/board-igep0020.c > @@ -274,6 +274,20 @@ static int igep2_twl_gpio_setup(struct device *dev, > igep2_vmmc1_supply.dev = mmc[0].dev; > igep2_vmmc2_supply.dev = mmc[1].dev; > > + /* > + * REVISIT: need ehci-omap hooks for external VBUS > + * power switch and overcurrent detect > + */ > + gpio_request(gpio + 1, "GPIO_EHCI_NOC"); > + gpio_direction_input(gpio + 1); > + > + /* > + * TWL4030_GPIO_MAX + 0 == ledA, GPIO_USBH_CPEN > + * (out, active low) > + */ > + gpio_request(gpio + TWL4030_GPIO_MAX, 0); > + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0); > + > return 0; > }; > > -- > 1.7.0.4 > >
On 09/29/2010 04:19 PM, Mathieu Poirier wrote: > SRU Justification: > > Impact: GPIO for various devices are missing from the board > initialization. This patch adds support for the VBUS and over current > gpios. Without this patch, input/outputs from these two sources are > ignored. > > BugLink: https://bugs.launchpad.net/bugs/651589 > > > On Sat, 2010-09-25 at 20:26 +0200, Enric Balletbo i Serra wrote: >> Signed-off-by: Enric Balletbo i Serra<eballetbo@gmail.com> >> --- >> arch/arm/mach-omap2/board-igep0020.c | 14 ++++++++++++++ >> 1 files changed, 14 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c >> index 175f043..1052a63 100644 >> --- a/arch/arm/mach-omap2/board-igep0020.c >> +++ b/arch/arm/mach-omap2/board-igep0020.c >> @@ -274,6 +274,20 @@ static int igep2_twl_gpio_setup(struct device *dev, >> igep2_vmmc1_supply.dev = mmc[0].dev; >> igep2_vmmc2_supply.dev = mmc[1].dev; >> >> + /* >> + * REVISIT: need ehci-omap hooks for external VBUS >> + * power switch and overcurrent detect >> + */ >> + gpio_request(gpio + 1, "GPIO_EHCI_NOC"); >> + gpio_direction_input(gpio + 1); >> + >> + /* >> + * TWL4030_GPIO_MAX + 0 == ledA, GPIO_USBH_CPEN >> + * (out, active low) >> + */ >> + gpio_request(gpio + TWL4030_GPIO_MAX, 0); >> + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0); >> + >> return 0; >> }; >> >> -- >> 1.7.0.4 >> >> > > > This ain't gonna work so well. The email does not contain a clear text patch, nor is there a plain text patch in the LP report, and I'm _way_ too lazy to clean it up myself. I assume this is intended for Maverick master? That is the implication, but I'd like it made explicit. What about ti-omap4 ? The subject says this is the 1st of 6 patches. Should I expect more? Is this a SAUCE patch, or is it on its way upstream? rtg
diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c index 175f043..1052a63 100644 --- a/arch/arm/mach-omap2/board-igep0020.c +++ b/arch/arm/mach-omap2/board-igep0020.c @@ -274,6 +274,20 @@ static int igep2_twl_gpio_setup(struct device *dev, igep2_vmmc1_supply.dev = mmc[0].dev; igep2_vmmc2_supply.dev = mmc[1].dev; + /* + * REVISIT: need ehci-omap hooks for external VBUS + * power switch and overcurrent detect + */ + gpio_request(gpio + 1, "GPIO_EHCI_NOC"); + gpio_direction_input(gpio + 1); + + /* + * TWL4030_GPIO_MAX + 0 == ledA, GPIO_USBH_CPEN + * (out, active low) + */ + gpio_request(gpio + TWL4030_GPIO_MAX, 0); + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0); + return 0; };
Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com> --- arch/arm/mach-omap2/board-igep0020.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)